From f99258ea4d169516a58527f47982953da835eff9 Mon Sep 17 00:00:00 2001 From: parthp2107 <83201188+parthp2107@users.noreply.github.com> Date: Wed, 2 Feb 2022 13:05:39 +0530 Subject: [PATCH] added webdriver path to selenium config (#2553) * added webdriver path to selenium config * addressing style check --- openmetadata-ui/selenium.properties | 8 +++++++- .../catalog/selenium/pages/common/CommonTests.java | 4 +++- .../pages/common/PaginationAndFilterTest.java | 4 +++- .../selenium/pages/common/PostIngestionTests.java | 4 +++- .../selenium/pages/common/UiExceptionHandling.java | 4 +++- .../dashboardDetails/DashboardDetailsPageTest.java | 4 +++- .../dashboardService/DashboardServiceTestPage.java | 4 +++- .../databaseService/DatabaseServicePageTest.java | 4 +++- .../pages/ingestion/IngestionPageTest.java | 4 +++- .../messagingService/MessagingServicePageTest.java | 4 +++- .../selenium/pages/myData/MyDataPageTest.java | 4 +++- .../pipelineDetails/PipelineDetailsPageTest.java | 4 +++- .../pipelineService/PipelineServiceTestPage.java | 4 +++- .../selenium/pages/roles/RolesPageTest.java | 4 +++- .../pages/tableDetails/TableDetailsPageTest.java | 4 +++- .../catalog/selenium/pages/tags/TagsPageTest.java | 4 +++- .../selenium/pages/teams/TeamsPageTest.java | 4 +++- .../pages/topicDetails/TopicDetailsPageTest.java | 4 +++- .../selenium/pages/users/UsersPageTest.java | 4 +++- .../pagesWithoutData/myData/MyDataPageTest.java | 4 +++- .../catalog/selenium/properties/Property.java | 14 ++++++++++++++ 21 files changed, 78 insertions(+), 20 deletions(-) diff --git a/openmetadata-ui/selenium.properties b/openmetadata-ui/selenium.properties index 34e56a6c5ee..d39e7eb7a6a 100644 --- a/openmetadata-ui/selenium.properties +++ b/openmetadata-ui/selenium.properties @@ -9,8 +9,14 @@ # See the License for the specific language governing permissions and # limitations under the License. -#OpenMetadata Url +# OpenMetadata Url openMetadataUrl = http://localhost:8585 +# WebDriver +webDriver = webdriver.chrome.driver + +# WebDriver's path +webDriverPath = src/test/resources/drivers/linux/chromedriver + # Enter Time In Milliseconds waitTime = 700 diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/CommonTests.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/CommonTests.java index 016f441cc0d..9178bdd786b 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/CommonTests.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/CommonTests.java @@ -57,10 +57,12 @@ public class CommonTests { static String url = Property.getInstance().getURL(); static String urlTag = "/api/v1/tags/"; String tableName = "dim_address"; + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java index f06cf48e72c..c9900d22d92 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PaginationAndFilterTest.java @@ -47,10 +47,12 @@ public class PaginationAndFilterTest { static Actions actions; static WebDriverWait wait; Integer waitTime = Property.getInstance().getSleepTime(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PostIngestionTests.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PostIngestionTests.java index 1f0ab3e880a..c949871041f 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PostIngestionTests.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/PostIngestionTests.java @@ -26,10 +26,12 @@ public class PostIngestionTests { static WebDriverWait wait; static String dashboard = "Unicode Test"; Integer waitTime = Property.getInstance().getSleepTime(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/UiExceptionHandling.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/UiExceptionHandling.java index 23fa6d76a9b..cc4876d6856 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/UiExceptionHandling.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/common/UiExceptionHandling.java @@ -33,6 +33,8 @@ public class UiExceptionHandling { static String enterDescription = "//div[@data-testid='enterDescription']/div/div[2]/div/div/div/div/div/div"; static Faker faker = new Faker(); static String serviceName = faker.name().firstName(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); public void interceptor(String content, String replaceContent) { devTools.createSession(); @@ -65,7 +67,7 @@ public class UiExceptionHandling { @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardDetails/DashboardDetailsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardDetails/DashboardDetailsPageTest.java index 127f4119be3..d515c901fe2 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardDetails/DashboardDetailsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardDetails/DashboardDetailsPageTest.java @@ -42,10 +42,12 @@ public class DashboardDetailsPageTest { static String enterDescription = "//div[@data-testid='enterDescription']/div/div[2]/div/div/div/div/div/div"; static Actions actions; static WebDriverWait wait; + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardService/DashboardServiceTestPage.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardService/DashboardServiceTestPage.java index f6b249b1f4b..285d6231f14 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardService/DashboardServiceTestPage.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/dashboardService/DashboardServiceTestPage.java @@ -44,10 +44,12 @@ public class DashboardServiceTestPage { static Actions actions; static WebDriverWait wait; Integer waitTime = Property.getInstance().getSleepTime(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/databaseService/DatabaseServicePageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/databaseService/DatabaseServicePageTest.java index f2902b19480..d3e88958f81 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/databaseService/DatabaseServicePageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/databaseService/DatabaseServicePageTest.java @@ -47,10 +47,12 @@ public class DatabaseServicePageTest { static Actions actions; static WebDriverWait wait; Integer waitTime = Property.getInstance().getSleepTime(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); webDriver = new ChromeDriver(options); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/ingestion/IngestionPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/ingestion/IngestionPageTest.java index 492d4f51585..4b5696d18c2 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/ingestion/IngestionPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/ingestion/IngestionPageTest.java @@ -41,10 +41,12 @@ public class IngestionPageTest { static Actions actions; static WebDriverWait wait; Integer waitTime = Property.getInstance().getSleepTime(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/messagingService/MessagingServicePageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/messagingService/MessagingServicePageTest.java index 531d521bed7..f44da40a207 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/messagingService/MessagingServicePageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/messagingService/MessagingServicePageTest.java @@ -44,10 +44,12 @@ public class MessagingServicePageTest { static Actions actions; static WebDriverWait wait; Integer waitTime = Property.getInstance().getSleepTime(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java index 5ca5712aa9d..8cb2553ea01 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/myData/MyDataPageTest.java @@ -46,10 +46,12 @@ public class MyDataPageTest { static WebDriverWait wait; static String table = "dim_product_variant"; Integer waitTime = Property.getInstance().getSleepTime(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineDetails/PipelineDetailsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineDetails/PipelineDetailsPageTest.java index 930bac95300..0a96df4fb91 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineDetails/PipelineDetailsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineDetails/PipelineDetailsPageTest.java @@ -43,10 +43,12 @@ public class PipelineDetailsPageTest { static String enterDescription = "//div[@data-testid='enterDescription']/div/div[2]/div/div/div/div/div/div"; static Actions actions; static WebDriverWait wait; + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); webDriver = new ChromeDriver(options); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineService/PipelineServiceTestPage.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineService/PipelineServiceTestPage.java index 52f49aa7698..8bafa260aae 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineService/PipelineServiceTestPage.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/pipelineService/PipelineServiceTestPage.java @@ -44,10 +44,12 @@ public class PipelineServiceTestPage { static Actions actions; static WebDriverWait wait; Integer waitTime = Property.getInstance().getSleepTime(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/roles/RolesPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/roles/RolesPageTest.java index 75132f7f013..7f613a6ddc5 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/roles/RolesPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/roles/RolesPageTest.java @@ -35,10 +35,12 @@ public class RolesPageTest { static Actions actions; static WebDriverWait wait; Integer waitTime = Property.getInstance().getSleepTime(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java index 74035e57ccf..74f9e9bb59a 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tableDetails/TableDetailsPageTest.java @@ -44,10 +44,12 @@ public class TableDetailsPageTest { static WebDriverWait wait; Integer waitTime = Property.getInstance().getSleepTime(); String tableName = "dim_address"; + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tags/TagsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tags/TagsPageTest.java index d65ab1c7780..2ae6849bfab 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tags/TagsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/tags/TagsPageTest.java @@ -52,10 +52,12 @@ public class TagsPageTest { static Actions actions; static WebDriverWait wait; Integer waitTime = Property.getInstance().getSleepTime(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/teams/TeamsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/teams/TeamsPageTest.java index 28a2ec58faf..c4c52647aa1 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/teams/TeamsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/teams/TeamsPageTest.java @@ -47,10 +47,12 @@ public class TeamsPageTest { static Actions actions; static WebDriverWait wait; String teamsFilterCountXpath = "//div[@data-testid='terms-summary']//span[@data-testid='filter-count']"; + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--no-sandbox"); options.addArguments("--disable-dev-shm-usage"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/topicDetails/TopicDetailsPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/topicDetails/TopicDetailsPageTest.java index 66b530e7a86..427ff3796ce 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/topicDetails/TopicDetailsPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/topicDetails/TopicDetailsPageTest.java @@ -42,10 +42,12 @@ public class TopicDetailsPageTest { static Actions actions; static WebDriverWait wait; Integer waitTime = Property.getInstance().getSleepTime(); + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/users/UsersPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/users/UsersPageTest.java index 36c28a158ec..746bf18b426 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/users/UsersPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pages/users/UsersPageTest.java @@ -32,10 +32,12 @@ public class UsersPageTest { Integer waitTime = Property.getInstance().getSleepTime(); static String url = Property.getInstance().getURL(); static String urlTag = "/api/v1/tags/"; + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pagesWithoutData/myData/MyDataPageTest.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pagesWithoutData/myData/MyDataPageTest.java index 2a76e2a9800..da9d4e4f745 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pagesWithoutData/myData/MyDataPageTest.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/pagesWithoutData/myData/MyDataPageTest.java @@ -23,10 +23,12 @@ public class MyDataPageTest { static String url = Property.getInstance().getURL(); static Actions actions; static WebDriverWait wait; + String webDriverInstance = Property.getInstance().getWebDriver(); + String webDriverPath = Property.getInstance().getWebDriverPath(); @BeforeEach public void openMetadataWindow() { - System.setProperty("webdriver.chrome.driver", "src/test/resources/drivers/linux/chromedriver"); + System.setProperty(webDriverInstance, webDriverPath); ChromeOptions options = new ChromeOptions(); options.addArguments("--headless"); options.addArguments("--window-size=1280,800"); diff --git a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/properties/Property.java b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/properties/Property.java index 4cfc6267875..05187a7a009 100644 --- a/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/properties/Property.java +++ b/openmetadata-ui/src/test/java/org/openmetadata/catalog/selenium/properties/Property.java @@ -21,10 +21,14 @@ public class Property { private static Integer waitTime; private static String URL; + private static String webDriver; + private static String webDriverPath; private static final Object LOCK = new Object(); private static Property instance; String openMetadataUrl = "openMetadataUrl"; String openMetadataWaitTime = "waitTime"; + String openMetadataWebDriver = "webDriver"; + String openMetadataWebDriverPath = "webDriverPath"; public static Property getInstance() { if (instance == null) { @@ -45,6 +49,8 @@ public class Property { } URL = properties.getProperty(openMetadataUrl); waitTime = Integer.parseInt(properties.getProperty(openMetadataWaitTime)); + webDriver = properties.getProperty(openMetadataWebDriver); + webDriverPath = properties.getProperty(openMetadataWebDriverPath); } public static String getURL() { @@ -54,4 +60,12 @@ public class Property { public static Integer getSleepTime() { return waitTime; } + + public static String getWebDriver() { + return webDriver; + } + + public static String getWebDriverPath() { + return webDriverPath; + } }