yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-09-26 17:34:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR -- propagate result to suites (#18823)

Browse Source 
* fix: update result summary for test suite

* fix: stream pattern

* fix: inverse null conditional logic
This commit is contained in:
Teddy 2024-11-28 08:09:56 +01:00 committed by GitHub
parent 804e3defb2
commit fb826b2c68
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TestCaseResultRepository.java
View File

@ -4,6 +4,7 @@ import static org.openmetadata.schema.type.EventType.ENTITY_DELETED;
import static org.openmetadata.service.Entity.TEST_CASE; import static org.openmetadata.service.Entity.TEST_CASE;
import static org.openmetadata.service.Entity.TEST_CASE_RESULT; import static org.openmetadata.service.Entity.TEST_CASE_RESULT;
import static org.openmetadata.service.Entity.TEST_DEFINITION; import static org.openmetadata.service.Entity.TEST_DEFINITION;
import static org.openmetadata.service.Entity.TEST_SUITE;
import java.io.IOException; import java.io.IOException;
import java.util.Arrays; import java.util.Arrays;
@ -17,7 +18,9 @@ import javax.ws.rs.core.UriInfo;
import lombok.SneakyThrows; import lombok.SneakyThrows;
import org.openmetadata.common.utils.CommonUtil; import org.openmetadata.common.utils.CommonUtil;
import org.openmetadata.schema.api.tests.CreateTestCaseResult; import org.openmetadata.schema.api.tests.CreateTestCaseResult;
import org.openmetadata.schema.tests.ResultSummary;
import org.openmetadata.schema.tests.TestCase; import org.openmetadata.schema.tests.TestCase;
import org.openmetadata.schema.tests.TestSuite;
import org.openmetadata.schema.tests.type.TestCaseResult; import org.openmetadata.schema.tests.type.TestCaseResult;
import org.openmetadata.schema.tests.type.TestCaseStatus; import org.openmetadata.schema.tests.type.TestCaseStatus;
import org.openmetadata.schema.type.EntityReference; import org.openmetadata.schema.type.EntityReference;
@ -222,6 +225,45 @@ public class TestCaseResultRepository extends EntityTimeSeriesRepository<TestCas
EntityRepository.EntityUpdater entityUpdater = EntityRepository.EntityUpdater entityUpdater =
testCaseRepository.getUpdater(original, updated, EntityRepository.Operation.PATCH); testCaseRepository.getUpdater(original, updated, EntityRepository.Operation.PATCH);
entityUpdater.update(); entityUpdater.update();
updateTestSuiteSummary(updated);
}
private void updateTestSuiteSummary(TestCase testCase) {
List<String> fqns =
testCase.getTestSuites() != null
? testCase.getTestSuites().stream().map(TestSuite::getFullyQualifiedName).toList()
: null;
TestSuiteRepository testSuiteRepository = new TestSuiteRepository();
if (fqns != null) {
for (String fqn : fqns) {
TestSuite testSuite = Entity.getEntityByName(TEST_SUITE, fqn, "*", Include.ALL);
if (testSuite != null) {
TestSuite original = JsonUtils.deepCopy(testSuite, TestSuite.class);
List<ResultSummary> resultSummaries = testSuite.getTestCaseResultSummary();
if (resultSummaries != null) {
resultSummaries.stream()
.filter(s -> s.getTestCaseName().equals(testCase.getFullyQualifiedName()))
.findFirst()
.ifPresent(
s -> {
s.setStatus(testCase.getTestCaseStatus());
s.setTimestamp(testCase.getTestCaseResult().getTimestamp());
});
} else {
testSuite.setTestCaseResultSummary(
List.of(
new ResultSummary()
.withTestCaseName(testCase.getFullyQualifiedName())
.withStatus(testCase.getTestCaseStatus())
.withTimestamp(testCase.getTestCaseResult().getTimestamp())));
}
EntityRepository.EntityUpdater entityUpdater =
testSuiteRepository.getUpdater(original, testSuite, EntityRepository.Operation.PATCH);
entityUpdater.update();
}
}
}
} }
@Override @Override