From fc00b61e59232a22f079db75818139646def3ee4 Mon Sep 17 00:00:00 2001
From: Ashish Gupta <ashish@getcollate.io>
Date: Thu, 16 May 2024 14:27:56 +0530
Subject: [PATCH] MINOR: fix the dropdown not showing in case of no data in
 glossary (#16256)

* fix the dropdown not showing in case of no data in glossary

* minor fix
---
 .../common/AsyncSelectList/TreeAsyncSelectList.tsx        | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx b/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx
index b56d94bea90..24d6d4eace5 100644
--- a/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx
+++ b/openmetadata-ui/src/main/resources/ui/src/components/common/AsyncSelectList/TreeAsyncSelectList.tsx
@@ -73,6 +73,7 @@ const TreeAsyncSelectList: FC<Omit<AsyncSelectListProps, 'fetchOptions'>> = ({
   const form = Form.useFormInstance();
 
   const fetchGlossaryListInternal = async () => {
+    setIsLoading(true);
     try {
       const { data } = await getGlossariesList({
         limit: PAGE_SIZE_LARGE,
@@ -91,11 +92,12 @@ const TreeAsyncSelectList: FC<Omit<AsyncSelectListProps, 'fetchOptions'>> = ({
 
   const dropdownRender = (menu: React.ReactElement) => (
     <>
-      {menu}
+      {isLoading ? <Loader size="small" /> : menu}
       <Space className="p-sm p-b-xss p-l-xs custom-dropdown-render" size={8}>
         <Button
           className="update-btn"
           data-testid="saveAssociatedTag"
+          disabled={isEmpty(glossaries)}
           htmlType="submit"
           loading={isSubmitLoading}
           size="small"
@@ -211,7 +213,6 @@ const TreeAsyncSelectList: FC<Omit<AsyncSelectListProps, 'fetchOptions'>> = ({
     if (!params?.glossary) {
       return;
     }
-    setIsLoading(true);
     try {
       const results = await queryGlossaryTerms(params.glossary);
 
@@ -229,8 +230,6 @@ const TreeAsyncSelectList: FC<Omit<AsyncSelectListProps, 'fetchOptions'>> = ({
       );
     } catch (error) {
       showErrorToast(error as AxiosError);
-    } finally {
-      setIsLoading(false);
     }
   };
 
@@ -282,7 +281,6 @@ const TreeAsyncSelectList: FC<Omit<AsyncSelectListProps, 'fetchOptions'>> = ({
 
         return Promise.resolve();
       }}
-      notFoundContent={isLoading ? <Loader size="small" /> : null}
       showCheckedStrategy={TreeSelect.SHOW_ALL}
       style={{ width: '100%' }}
       switcherIcon={