yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-11-04 04:29:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check if user is bot before updateOrCreate bot user (#10178)

Browse Source
This commit is contained in:
Nahuel 2023-02-10 17:40:07 +01:00 committed by GitHub
parent 2a99114c94
commit fc78d03cc4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
openmetadata-service/src/main/java/org/openmetadata/service/resources/teams/UserResource.java
View File

@ -1138,7 +1138,9 @@ public class UserResource extends EntityResource<User, UserRepository> {
String botName = create.getBotName();
EntityInterface bot = retrieveBot(botName);
// check if the bot user exists
if (!botHasRelationshipWithUser(bot, original)
if (original != null && (original.getIsBot() == null || Boolean.FALSE.equals(original.getIsBot()))) {
throw new IllegalArgumentException(String.format("User [%s] already exists.", original.getName()));
} else if (!botHasRelationshipWithUser(bot, original)
&& original != null
&& userHasRelationshipWithAnyBot(original, bot)) {
// throw an exception if user already has a relationship with a bot