yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-07-13 03:59:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

minor: improve rule card actions dropdown (#18717)

Browse Source
This commit is contained in:
Sachin Chaurasiya 2024-11-21 16:35:57 +05:30 committed by GitHub
parent 0169aad418
commit fca85cdfe7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 40 additions and 49 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

89
openmetadata-ui/src/main/resources/ui/src/pages/PoliciesPage/PoliciesDetailPage/PoliciesDetailPage.tsx
View File

@ -18,7 +18,6 @@ import {
Card, Card,
Col, Col,
Dropdown, Dropdown,
Menu,
Modal, Modal,
Row, Row,
Space, Space,
@ -236,55 +235,47 @@ const PoliciesDetailPage = () => {
(rule: Rule) => { (rule: Rule) => {
return ( return (
<Dropdown <Dropdown
overlay={ menu={{
<Menu items: [
items={[ {
{ label: (
label: ( <Space align="center" data-testid="edit-rule">
<Button <Icon
className="p-0" className="align-middle"
data-testid="edit-rule" component={EditIcon}
type="text" style={{ fontSize: '14px' }}
onClick={(e) => { />
e.stopPropagation();
history.push(
getEditPolicyRulePath(fqn, rule.name || '')
);
}}>
<Space align="center">
<EditIcon width="16px" />
{t('label.edit')}
</Space>
</Button>
),
key: 'edit-button',
},
{
label: (
<Button
className="p-0"
data-testid="delete-rule"
type="text"
onClick={(e) => {
e.stopPropagation();
handleRuleDelete(rule);
}}>
<Space align="center">
<Icon
className="align-middle"
component={IconDelete}
style={{ fontSize: '16px' }}
/>
{t('label.delete')} {t('label.edit')}
</Space> </Space>
</Button> ),
), key: 'edit-button',
key: 'delete-button', },
}, {
]} label: (
/> <Space align="center" data-testid="delete-rule">
} <Icon
className="align-middle"
component={IconDelete}
style={{ fontSize: '14px' }}
/>
{t('label.delete')}
</Space>
),
key: 'delete-button',
},
],
onClick: (menuInfo) => {
if (menuInfo.key === 'edit-button') {
history.push(getEditPolicyRulePath(fqn, rule.name || ''));
} else if (menuInfo.key === 'delete-button') {
handleRuleDelete(rule);
} else {
return;
}
},
}}
placement="bottomRight" placement="bottomRight"
trigger={['click']}> trigger={['click']}>
<Tooltip <Tooltip