yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-10-31 02:29:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #14331 - Add Test Case Incident Manager Migration (#14386)

Browse Source 
* feat: add test case resolution task workflow

* chore: add migration for test case resolution feature

* fix: removed required field for object compatibiity in older migrations

* fix: minor testCaseResolution status logic

* chore: revert migration for test case incident

* chore: update migration file

* chore: clean up code

* style: fix java stylecheck
This commit is contained in:
Teddy 2023-12-22 11:01:51 +01:00 committed by GitHub
parent cdddc0c891
commit fe4c353bf3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 28 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
bootstrap/sql/migrations/native/1.3.0/mysql/postDataMigrationSQLScript.sql
View File

@ -4,5 +4,17 @@ SET json = REPLACE(json, '"customMetricsProfile"', '"customMetrics"');
-- Delete customMetricsProfile from entity_extension
-- This was not supported on the processing side before 1.3.
DELETE FROM openmetadata_db.entity_extension ee
DELETE FROM entity_extension ee
where extension like '%customMetrics';
-- BEGIN: Incident Manager Migration
-- STEP 1: Update test case testCaseResult.testCaseFailureStatus field
UPDATE test_case
SET json = JSON_REMOVE(json, '$.testCaseResult.testCaseFailureStatus')
WHERE json -> '$.testCaseResult.testCaseFailureStatus' IS NOT NULL;
-- STEP 2: remove all `testCaseFailureStatus` field in test results
UPDATE data_quality_data_time_series d
SET json = JSON_REMOVE(json, '$.testCaseFailureStatus');
-- END: Incident Manager Migration

9
bootstrap/sql/migrations/native/1.3.0/postgres/postDataMigrationSQLScript.sql
View File

@ -6,3 +6,12 @@ SET json = REPLACE(json::text, '"customMetricsProfile"', '"customMetrics"')::jso
-- This was not supported on the processing side before 1.3.
DELETE FROM entity_extension ee
where extension like '%customMetrics';
-- BEGIN: Incident Manager Migration
-- STEP 1: Update test case testCaseResult.testCaseFailureStatus field
UPDATE test_case
SET json = json::jsonb#-'{testCaseResult,testCaseFailureStatus}';
-- STEP 2: remove all `testCaseFailureStatus` field in test results
UPDATE data_quality_data_time_series d
SET json = json::jsonb#-'{testCaseFailureStatus}';
-- END: Incident Manager Migration

1
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/TestCaseResolutionStatusRepository.java
View File

@ -110,6 +110,7 @@ public class TestCaseResolutionStatusRepository
TestCaseResolutionStatus recordEntity, String extension, String recordFQN) {
TestCaseResolutionStatus latestTestCaseFailure =
getLatestRecord(recordEntity.getTestCaseReference().getFullyQualifiedName());
recordEntity.setStateId(
((latestTestCaseFailure != null)
&& (latestTestCaseFailure.getTestCaseResolutionStatusType()

2
openmetadata-service/src/test/java/org/openmetadata/service/resources/dqtests/TestCaseResourceTest.java
View File

@ -1770,7 +1770,7 @@ public class TestCaseResourceTest extends EntityResourceTest<TestCase, CreateTes
}
}
private ResultList<TestCaseResolutionStatus> getTestCaseFailureStatus(
public ResultList<TestCaseResolutionStatus> getTestCaseFailureStatus(
Long startTs,
Long endTs,
String assignee,

3
openmetadata-spec/src/main/resources/json/schema/tests/basic.json
View File

@ -90,8 +90,7 @@
"description": "Reference to the failure status object for the test case result.",
"$ref": "./testCaseResolutionStatus.json"
}
},
"additionalProperties": false
}
},
"testSuiteExecutionFrequency": {
"description": "How often the test case should run.",

2
openmetadata-spec/src/main/resources/json/schema/tests/resolved.json
View File

@ -34,6 +34,6 @@
"$ref": "../type/entityReference.json"
}
},
"required": ["testCaseFailureReason", "resolvedBy", "testCaseFailureComment"],
"required": ["testCaseFailureReason", "testCaseFailureComment"],
"additionalProperties": false
}