From fe7151e8707553df7193071b4052237d0d06e263 Mon Sep 17 00:00:00 2001 From: Vivek Ratnavel Subramanian Date: Thu, 28 Jul 2022 21:19:22 -0700 Subject: [PATCH] Fix flaky Cypress test (#6415) * Fix flaky Cypress test * Add jest fake timers --- openmetadata-ui/src/main/resources/ui/cypress/common/common.js | 1 - openmetadata-ui/src/main/resources/ui/jest.config.js | 3 +++ .../ui/src/components/common/popover/PopOver.test.jsx | 2 ++ .../ui/src/components/common/searchbar/Searchbar.test.js | 2 ++ .../src/pages/DatasetDetailsPage/DatasetDetailsPage.test.tsx | 2 ++ .../resources/ui/src/pages/GlossaryPage/GlossaryPage.test.tsx | 2 ++ .../ui/src/pages/TeamsAndUsersPage/TeamsAndUsersPage.test.tsx | 2 ++ .../src/main/resources/ui/src/pages/tags/index.test.tsx | 2 ++ 8 files changed, 15 insertions(+), 1 deletion(-) diff --git a/openmetadata-ui/src/main/resources/ui/cypress/common/common.js b/openmetadata-ui/src/main/resources/ui/cypress/common/common.js index fbdbdb4ab49..9f9f9039c97 100644 --- a/openmetadata-ui/src/main/resources/ui/cypress/common/common.js +++ b/openmetadata-ui/src/main/resources/ui/cypress/common/common.js @@ -197,7 +197,6 @@ export const deleteCreatedService = (typeOfService, service_Name) => { .type('DELETE'); cy.get('[data-testid="confirm-button"]').should('be.visible').click(); cy.wait(2000); - cy.get('.tw-modal-container').should('not.exist'); cy.get('[class="Toastify__toast-body"] >div') .eq(1) .should('exist') diff --git a/openmetadata-ui/src/main/resources/ui/jest.config.js b/openmetadata-ui/src/main/resources/ui/jest.config.js index c0e98feb833..94b48d9afdb 100644 --- a/openmetadata-ui/src/main/resources/ui/jest.config.js +++ b/openmetadata-ui/src/main/resources/ui/jest.config.js @@ -56,4 +56,7 @@ module.exports = { // Sonar Cloud Configuration testResultsProcessor: 'jest-sonar-reporter', + + // use fake timers + timers: 'fake', }; diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/popover/PopOver.test.jsx b/openmetadata-ui/src/main/resources/ui/src/components/common/popover/PopOver.test.jsx index a07ae814dd1..97753a16740 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/popover/PopOver.test.jsx +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/popover/PopOver.test.jsx @@ -23,6 +23,8 @@ import PopOver from './PopOver'; let global; +jest.useRealTimers(); + global.document.createRange = () => ({ setStart: jest.fn(), setEnd: jest.fn(), diff --git a/openmetadata-ui/src/main/resources/ui/src/components/common/searchbar/Searchbar.test.js b/openmetadata-ui/src/main/resources/ui/src/components/common/searchbar/Searchbar.test.js index e0cb5558c27..a9a3f2a19eb 100644 --- a/openmetadata-ui/src/main/resources/ui/src/components/common/searchbar/Searchbar.test.js +++ b/openmetadata-ui/src/main/resources/ui/src/components/common/searchbar/Searchbar.test.js @@ -15,6 +15,8 @@ import { fireEvent, getByTestId, render } from '@testing-library/react'; import React from 'react'; import Searchbar from './Searchbar'; +jest.useRealTimers(); + describe('Test Searchbar Component', () => { it('Renders the searchbar with the search text sent to it', () => { const onSearch = jest.fn(); diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/DatasetDetailsPage/DatasetDetailsPage.test.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/DatasetDetailsPage/DatasetDetailsPage.test.tsx index 1bdadcd9bbf..b52e5b9ad0e 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/DatasetDetailsPage/DatasetDetailsPage.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/DatasetDetailsPage/DatasetDetailsPage.test.tsx @@ -57,6 +57,8 @@ const mockUseHistory = { push: jest.fn(), }; +jest.useRealTimers(); + jest.mock('../../AppState', () => ({ userDetails: { name: 'test', diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/GlossaryPage/GlossaryPage.test.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/GlossaryPage/GlossaryPage.test.tsx index 8a6183bf070..60b61b63d46 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/GlossaryPage/GlossaryPage.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/GlossaryPage/GlossaryPage.test.tsx @@ -21,6 +21,8 @@ import { import { MOCK_GLOSSARY } from './glossary.mock'; import GlossaryPageV1 from './GlossaryPageV1.component'; +jest.useRealTimers(); + jest.mock('react-router-dom', () => ({ useHistory: () => ({ push: jest.fn(), diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/TeamsAndUsersPage/TeamsAndUsersPage.test.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/TeamsAndUsersPage/TeamsAndUsersPage.test.tsx index 9555c18b605..e6b8ea67dde 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/TeamsAndUsersPage/TeamsAndUsersPage.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/TeamsAndUsersPage/TeamsAndUsersPage.test.tsx @@ -43,6 +43,8 @@ const MOCK_HISTORY = { push: jest.fn(), }; +jest.useRealTimers(); + jest.mock('../../components/containers/PageContainerV1', () => { return jest .fn() diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/tags/index.test.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/tags/index.test.tsx index 3a5b3cb78ad..58b09c12915 100644 --- a/openmetadata-ui/src/main/resources/ui/src/pages/tags/index.test.tsx +++ b/openmetadata-ui/src/main/resources/ui/src/pages/tags/index.test.tsx @@ -30,6 +30,8 @@ import { } from '../../axiosAPIs/tagAPI'; import { getTagCategories } from '../../utils/TagsUtils'; +jest.useRealTimers(); + jest.mock('../../authentication/auth-provider/AuthProvider', () => { return { useAuthContext: jest.fn(() => ({