yujunjun/OpenMetadata
1
0
Fork 0
mirror of https://github.com/open-metadata/OpenMetadata.git synced 2025-07-27 03:10:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added Webhook type filter in list api (#7221)

Browse Source 
* added webhook type filter in list api

* added webhook type filter in list api
This commit is contained in:
Parth Panchal 2022-09-06 00:16:12 +05:30 committed by GitHub
parent cecd3ca342
commit fe8fb625e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
catalog-rest-service/src/main/java/org/openmetadata/catalog/jdbi3/ListFilter.java
View File

@ -43,6 +43,7 @@ public class ListFilter {
condition = addCondition(condition, getParentCondition(tableName)); condition = addCondition(condition, getParentCondition(tableName));
condition = addCondition(condition, getCategoryCondition(tableName)); condition = addCondition(condition, getCategoryCondition(tableName));
condition = addCondition(condition, getWebhookCondition(tableName)); condition = addCondition(condition, getWebhookCondition(tableName));
condition = addCondition(condition, getWebhookTypeCondition(tableName));
return condition.isEmpty() ? "WHERE TRUE" : "WHERE " + condition; return condition.isEmpty() ? "WHERE TRUE" : "WHERE " + condition;
} }
@ -82,12 +83,23 @@ public class ListFilter {
return webhookStatus == null ? "" : getStatusPrefixCondition(tableName, escape(webhookStatus)); return webhookStatus == null ? "" : getStatusPrefixCondition(tableName, escape(webhookStatus));
} }
public String getWebhookTypeCondition(String tableName) {
String webhookType = queryParams.get("webhookType");
return webhookType == null ? "" : getWebhookTypePrefixCondition(tableName, escape(webhookType));
}
private String getFqnPrefixCondition(String tableName, String fqnPrefix) { private String getFqnPrefixCondition(String tableName, String fqnPrefix) {
return tableName == null return tableName == null
? String.format("fullyQualifiedName LIKE '%s%s%%'", fqnPrefix, Entity.SEPARATOR) ? String.format("fullyQualifiedName LIKE '%s%s%%'", fqnPrefix, Entity.SEPARATOR)
: String.format("%s.fullyQualifiedName LIKE '%s%s%%'", tableName, fqnPrefix, Entity.SEPARATOR); : String.format("%s.fullyQualifiedName LIKE '%s%s%%'", tableName, fqnPrefix, Entity.SEPARATOR);
} }
private String getWebhookTypePrefixCondition(String tableName, String typePrefix) {
return tableName == null
? String.format("webhookType LIKE '%s%%'", typePrefix)
: String.format("%s.webhookType LIKE '%s%%'", tableName, typePrefix);
}
private String getCategoryPrefixCondition(String tableName, String category) { private String getCategoryPrefixCondition(String tableName, String category) {
return tableName == null return tableName == null
? String.format("category LIKE '%s%s%%'", category, "") ? String.format("category LIKE '%s%s%%'", category, "")

8
catalog-rest-service/src/main/java/org/openmetadata/catalog/resources/events/WebhookResource.java
View File

@ -120,6 +120,11 @@ public class WebhookResource extends EntityResource<Webhook, WebhookRepository>
@Parameter(description = "Filter webhooks by status", schema = @Schema(type = "string", example = "active")) @Parameter(description = "Filter webhooks by status", schema = @Schema(type = "string", example = "active"))
@QueryParam("status") @QueryParam("status")
String statusParam, String statusParam,
@Parameter(
description = "Filter webhooks by type",
schema = @Schema(type = "string", example = "generic, slack, msteams"))
@QueryParam("webhookType")
String typeParam,
@Parameter(description = "Limit the number webhooks returned. (1 to 1000000, default = " + "10) ") @Parameter(description = "Limit the number webhooks returned. (1 to 1000000, default = " + "10) ")
@DefaultValue("10") @DefaultValue("10")
@Min(0) @Min(0)
@ -139,7 +144,8 @@ public class WebhookResource extends EntityResource<Webhook, WebhookRepository>
@DefaultValue("non-deleted") @DefaultValue("non-deleted")
Include include) Include include)
throws IOException { throws IOException {
ListFilter filter = new ListFilter(Include.ALL).addQueryParam("status", statusParam); ListFilter filter =
new ListFilter(Include.ALL).addQueryParam("status", statusParam).addQueryParam("webhookType", typeParam);
return listInternal(uriInfo, securityContext, "", filter, limitParam, before, after); return listInternal(uriInfo, securityContext, "", filter, limitParam, before, after);
} }