181 Commits

Author SHA1 Message Date
Karan Hotchandani
04ebabc593
fix glossary playwright flakiness (#19667) 2025-02-04 19:12:26 +05:30
Sweta Agarwalla
ca3fa6dcea
Add alert bar (#19047)
* add alert bar

* add mock for PageLayotuV1

* fix sonar issues

* update glossary page

* add PageLayout in Pages

* update test locator

* update as per tests

* add mock for page layout v1

* update alert styles

* remove pagelayout from pipeline details

* update layouting for ErrorPlaceholder

* update to remove render function

* update as per comments

* updated local files

* update as per comments

* update tests

* update pages to remove pagelayout v1

* updated locales

* update test

* fix sonar cloud issue

* updated as per comments

* add visible state to alert

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2025-02-03 10:18:16 +05:30
Ashish Gupta
647bab6019
#18008: global search should persist quick filter in explore (#19611)
* gloabl search should have applied quick filter

* added playwright test for it
2025-01-31 22:16:47 +05:30
Ashish Gupta
bef4b1f6a3
fix tags page flaky playwright test (#19582) 2025-01-30 17:10:41 +05:30
Shrushti Polekar
d1710c8125
Fix #19068: While user in Pagination, Browser Back button takes them to start page (#19229)
* fix browser back btn issue related to pagination

* common function to handle cursor based data fetches

* Revert "common function to handle cursor based data fetches"

This reverts commit a585f3aaec49c966ae8c1aa5436d41c2456073c5.

* updated usePaging hook to store and retrieve cursor

* address PR comments

* address pr comments

* refactor handle paging cursor

* updated handlPageChange to setPage and cursorValues

* used useCustomLocation inplace of useLocation

* added Pagesize and refactor the history state object

* issue fix

* handle filter issue

* address pr comments

* fix failing unit test cases

* fix sonarqube issue

* address pr comment

* address pr comment

* added useTableFilters hook

* address pr comments

* update useTableFilter to handle multiple query params

* update useTableFilter

* fix failing unit test

* address pr comments

* address pr comments

* playwright test cases

* address pr comments

* issue fix

* issue fix

* revert generated file changes

* address pr comment for playwright test

* minor fix

* fix breadcrumb issue

* revert location changes

* address pr comment

* fix failing e2e test

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2025-01-29 11:36:19 +00:00
Ashish Gupta
3924e58073
MINOR: fix the lineage and DataAssetsWidget flaky playwright test failure (#19560)
* fix the lineage flaky test failure

* fix the DataAssetsWidget falky test failure

* fix falky test around the pipeline modal and teams
2025-01-29 11:38:01 +05:30
sonika-shah
5b63c36ef1
Fix #19116 : Support for domain hierarchy listing (#19191)
* Backend support for domain hierarchy listing

* use linkedHashmap to maintain order of results in hierarchy

* Revert changes to generated files to match main

* show all domains for non admin user

* change select domain layout

* fix multiple save

* fix playwright

* cleanup

* fix domain tests

* fix domain tests

* fix icon styling

* show icons on navbar domain list

* update tests

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
2025-01-27 15:43:42 +05:30
Ashish Gupta
c406cceb9a
#19432: fix the description renderer in glossary import (#19450)
* fix the description renderer in glossary import

* added test for the same
2025-01-22 16:22:44 +05:30
Ashish Gupta
5e7847e2f5
fix the description not rendered in Glossary Modal while edit (#19453) 2025-01-21 12:42:23 +05:30
Chirag Madlani
00a37c6180
Fix(ui): refresh call concurrency for multiple browser tabs (#19303)
* fix(ui): refresh auth token for multi browser tabs

* update refresh logic

* fix multiple tab issue

* fix tests

* added tests

* fix ingestion bot failure

* fix sonar cloud

* update test description

* remove unused code and reset test on after all

* bump playwright

* avoid running refresh tests as it's been flaky for postgres

* revert playwright version bump changes

* Put 500 status

---------

Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
2025-01-20 23:31:56 +05:30
Aniket Katkar
7fea955338
Tests #19066: Playwright coverage for ViewAll rule with matchAnyTag() and isOwner() condition (#19374)
* Modify the setup for the tests and add teardown to reset the organization policies

* Fix the loader shown in case of no permission

* Add playwright tests to cover the viewAll permission with conditions

* Add description for the commented code
2025-01-17 09:08:54 +05:30
Ashish Gupta
58f95e9e98
MINOR: fix the wrong team count displayed on team tab (#19368)
* fix the wrong team count displayed on team tab

* added playwright test for checking counts
2025-01-15 17:47:53 +05:30
Shailesh Parmar
7d30995399
playwright: fixed failing incident manager test (#19367) 2025-01-15 14:56:40 +05:30
Karan Hotchandani
94cbadb772
fix glossary tests (#19352) 2025-01-14 21:44:40 +05:30
Chirag Madlani
8599aab9b4
fix(ui): update glossary term table upon new term added (#19296)
* fix(ui): update glossary term table upon new term added

* fix the active tab getting change and added the playwright test

---------

Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Co-authored-by: Aniket Katkar <aniketkatkar97@gmail.com>
2025-01-10 10:33:55 +05:30
Sriharsha Chintalapani
490ebdebc3
Issue-19197: Deleting Data Product should delete the data asset relationships (#19208)
* Issue-19197: Deleting Data Product should delete the data asset relationships

* Issue-19197: Deleting Data Product should delete the data asset relationships

* Minor: Fix the deleteByName

* add tests for data product delete case

* fix flaky tests

* update data products fqn keyword mapping

* Update table_index_mapping.json

* fix flaky test

* fix tests

* fix flaky tests

* fix flakiness

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
2025-01-08 15:08:08 +05:30
Ashish Gupta
2179b43232
fix the search for custom properties in advance search for some types (#19113)
* fix the search in advance search custom properties

* modify v1/metadata/types/customProperties api to get customPropertyConfig along with name and type

* added config list in the entity ref list

* fix type of duration, timestamp and other types

* minor ui changes

* remove customProperty type which are not supported for now

* added playwright test around the duration type property

* fix flaky test

---------

Co-authored-by: sonikashah <sonikashah94@gmail.com>
2025-01-08 11:08:34 +05:30
Sweta Agarwalla
0a1ab95f8b
Add utils for login as admin (#19223)
* add utils for login as admin

* update as per comments

* fix java checkstyle issue

---------

Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
2025-01-06 13:58:13 +05:30
Ashish Gupta
87c07f3ecc
#16465 : supported glossary table column resizable (#17918)
* supported glossary table column resizable

* code cleanup

* fix the column resizing affecting other column width

* fix the playwright failure around the glossary due to re-sizable added
2025-01-03 10:09:33 +05:30
Ashish Gupta
ceeba2ad75
fix tag page flaky playwright test (#19150)
* fix tag page flaky playwright failures

* removed commented code
2024-12-31 17:12:15 +05:30
Sachin Chaurasiya
4f3ae5d083
feat(#15380): replace description editor with block editor (#19003)
* feat(#15380): replace the description editor with a new block editor.

* chore: Add placeholder support to BlockEditor

* feat: Add autofocus support to BlockEditor

* chore: implement block editor in richtext editor

* chore: Remove unused CSS import in RichTextEditor

* fix: ensure safe access to getEditorContent in Markdown editor components

* minor change

* fix: add support for ttf file extension in pom.xml

* fix: adjust block editor styles for better usability and overflow handling

* fix: update RichTextEditorPreviewer to RichTextEditorPreviewerV1 and adjust block editor styles

* fix: update description box selector to use om-block-editor for consistency

* fix: disable autoFocus on BlockEditor in RichTextEditorPreviewerV1

* refactor: update RichTextEditorPreviewer references to RichTextEditorPreviewerV1 in tests

* test: update timer handling in ApplicationCard and SuggestionsAlert tests

* fix(diff): update diff view rendering and attributes for consistency

* fix(RichTextEditor): add placeholder for empty markdown descriptions

* Add data-diff in <span>

* Fix test

* fix: update description box selector to use locator method for better reliability

* feat: integrate RichTextEditorPreviewerV1 for description rendering in Notification and Observability Alerts pages

* feat: add markdown conversion for mentions and hashtags in BlockEditorUtils

* fix: update initial value handling in TagsForm and formUtils

* MINOR - Update description handling in Playwright tests and utilities

* Refactor Playwright tests to use descriptionBox for tag and team descriptions

* Refactor custom property handling and update description check logic

* Enhance entity version page tests by adding description box read-only check and updating data-testid attributes

* Refactor description handling and improve diff rendering logic in task pages

* Fix user description clearing logic in UserDetails.spec.ts

* Enhance Rich Text Editor by adding custom styles and converting markdown to HTML for backward compatibility

* Remove test for rendering alert description when not present in AlertDetailsPage

* Clean up RichTextEditorPreviewerV1 by removing unnecessary comments and improving readability

* Update SearchIndexApplication.spec.ts to select 'Table' instead of 'Topic' in the tree widget

* Refactor BlockEditor and FeedUtils to improve code organization and readability

* Fix regex in getTextFromHtmlString to correctly remove HTML tags

* Add tests for getTextFromHtmlString and improve HTML tag removal regex

---------

Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
2024-12-27 20:57:37 +05:30
Shailesh Parmar
f87b0662fa
playwright: reset the profiler bot token in AUT (#19156)
* playwright: reset the profiler bot token in AUT

* addressing comment
2024-12-20 20:19:11 +05:30
Karan Hotchandani
9a76b07025
Fix flaky e2e tests (#19038)
* fix lineage flaky tests

* fix glossary flakiness
2024-12-19 23:05:55 +05:30
Chirag Madlani
4d30c83c55
fix(ui): sync search value with url and state value (#19050)
* fix(ui): sync search value with url and state value

* fix flaky for user spec
2024-12-16 21:02:16 +05:30
Pranita Fulsundar
57e814c15d
test(e2e): Explore page tests (#19074)
* test: add e2e tests

* test for listing of entities when index is dataAsset and all

* fix: validateBucketsForIndex function

* fix: add expect to bucket and its doc_count
2024-12-16 15:47:35 +05:30
Chirag Madlani
605d205f8b
test(e2e): Ingestion bot e2e tests (#19055)
* test(e2e): domain ingestion tests
support for ingestionBot login in playwright

* added tests

* add ingestion bot tests

* update bot tests

* revert unwanted changes

* comment skipped test

* check for service within domain
2024-12-16 15:41:36 +05:30
Ashish Gupta
9e6078f654
supported editUser permission in user tab for team page (#18987)
* supported editUser permission in user tab for team page

* remove edit all permission check in teams add/remove user api

* added playwright test for the editUser permission

* Added playwright test for data consumer user and remove no used field from the advance api call

---------

Co-authored-by: sonikashah <sonikashah94@gmail.com>
Co-authored-by: sonika-shah <58761340+sonika-shah@users.noreply.github.com>
2024-12-13 23:41:40 +05:30
Aniket Katkar
4f9627d860
Fix the flaky Tag.spec.ts test (#18984) 2024-12-11 19:56:42 +05:30
Mohit Yadav
5263858067
Create Change Events on import and update in es (#18953)
* Create Change Events on import and update in es

* add glossary tests

* minor test cleanup

* Make Change Event Update Async

* Fix Test case

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
Co-authored-by: Sriharsha Chintalapani <harshach@users.noreply.github.com>
2024-12-09 07:45:33 -08:00
Shailesh Parmar
7d7bc5b48b
playwright: fixed aut failure in playwright (#18958)
* playwright: fixed aut failure in playwright

* Temporarily increased the timeout for lineage tests which timeout often

* Fix the flaky tests

* removing linage changes

---------

Co-authored-by: Aniket Katkar <aniketkatkar97@gmail.com>
2024-12-09 18:03:13 +05:30
Aniket Katkar
f6b4434e4a
Improvements: Playwright tests (#18849)
* Resolve all the type errors in playwright code

* Fix the playwright tests

* Improve the ingestion test connection logic and autoClassification

* Fix flaky tests

* SearchIndexApplication fix

* Fix the flaky tests

* flaky test fixes and trace on for debugging

* Fix the flaky tests

* update the trace config for data insights setup

* Fix flaky tests

* Fix the flaky tests
2024-12-05 17:53:14 +05:30
Karan Hotchandani
fe661a2f49
Change lineage positioning algorithm (#18897)
* use elk algorithm to position nodes

* change positioning

* fix spacing

* do not reset zoom value

* minor pw fix

* force click on lineage edge
2024-12-04 21:27:43 +05:30
Sachin Chaurasiya
811feea515
Minor: improve custom properties e2e test (#18861) 2024-12-02 09:22:22 +05:30
Siddhant
8fcb8ecdd7
Add trigger option 'TestSuiteStatusUpdates' for TestSuite status changes (#18836)
* fix: Provide trigger option as TestSuiteStatusUpdates for TestSuite source

* add the playwright change to test the test suite status field in alert

* localization changes

---------

Co-authored-by: Aniket Katkar <aniketkatkar97@gmail.com>
2024-11-28 23:28:36 +05:30
Shailesh Parmar
4720a8da2b
playwright: added initial db setup for playwright test (#18832)
* playwright: fixed service ingestion aut

* updated the initial start of the playwright test
2024-11-28 20:26:30 +05:30
Karan Hotchandani
e22fc6ddeb
Fix Glossary tree hierarchy state (#18703)
* fix the tree state on edit glossary term

* add playwright tests

* fix permission loading

* fix tests

* adding timeout for in review state

* adding timeout for in review state

* increasing timeout

* fix tests

* update tests

* add a poll for checking tasks created

* testing response

* adding limit

* fix tests

* change user for testing

* Catch Exceptions on the Consumer to avoid losing records

---------

Co-authored-by: Pablo Takara <pjt1991@gmail.com>
2024-11-28 16:36:45 +05:30
Ashish Gupta
7877d5c14c
Allow Asset add and remove operation for editTag permission user (#18786)
* Allow Asset add and remove operation for editTag permission user

* remove edit all permission check in bulkAssetTag api for tag

* fix the permission check by checking specific and the index used to exclude

* check editTag permission before updating assets by bulkTagAsset api

* fix the button not visible for the non admin user

* added playwright for the limited user check aroud asset

* restrict add asset button in certification page

* minor fix

* cleanup aroud tag page and fix usertab count around Team page

* use entity type instead of search index

---------

Co-authored-by: sonikashah <sonikashah94@gmail.com>
Co-authored-by: karanh37 <karanh37@gmail.com>
2024-11-28 16:15:07 +05:30
Chirag Madlani
3ff11d8518
Revert "Add alert bar component (#17230)" (#18812)
This reverts commit e32f9cf8623cbe96cce8d0cc6c063b489c3f9590.
2024-11-27 16:43:33 +05:30
Aniket Katkar
c101c7cf30
Minor: Auto classification UI (#18785)
* Add the auto classification pipeline option in the service ingestion

* Localization changes for other languages

* Improve the logic for getSupportedPipelineTypes function and add unit tests for newly added logic

* Add playwright tests for the auto classification feature

* Improve the getSupportedPipelineTypes function logic to reduce the cognitive complexity

* update md docs

* Add classificationFilterPattern in the UI schema form order

* fix logs from backend for auto classification

* Changes to view the auto classification logs

* Fix the sonar errors

---------

Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>
2024-11-27 14:51:59 +05:30
Sweta Agarwalla
e32f9cf862
Add alert bar component (#17230)
* add alert bar component

* updated as per comments

* updated as per comments

* updated alert bar component

* remove styles attributes

* update styles

* add alert store and use alert in page layout

* update component to have reset method

* refactor: update reset calling method

* update reset method name

* updated as per feedbacks

* refcator: update CrossIcon component usage

* chore: remove condition for CrossIcon

* update animation for opening alert bar.

* add autoCloseTimer to alert banner

* remove cross icon component

* add cross icon svg

* update to fix the height issue

* fix height glitch issue when alert appears

* update the alert notification tests

* update alert transition issue

* revert the changes for height issue

* add alert in mydata

* update alert animation issue

* update alert position in page layout

* update as per feedbacks

* fix tests failure

* update test for toast

* remove dummy alert bar

* made alert fixed to top

* fix check failing issue

* fix activity feed playwright test issue

* update test

* fix test issues

* update page layout

* fix sonar cloud failure

* fix sonar cloud failure

* fix test issues

* resolve sonar issue

* update lineage spec

* update as per comments

* update domain page css

* fix sonar issue

* fix sonar cloud issue

* remove react-toastify

* fix sonar error

* yarn install command run

* update yarn lock

* revert yarn lock changes

* update yarn lock

* revert yarn

* revert yarn changes

* remove toastify instance

* update message type

* fix sonar issue

* add alert bar in Alert details page

* create mock for page layout

---------

Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com>
Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2024-11-27 00:35:23 +05:30
Ashish Gupta
490bbf6241
fix: tag page issue around disabled badge and Certification data in ES (#18697)
* fix tag page issue around disabled badge and other

* reset the unwanted code

* modify playwright test for consumer and steward

* modify tag es query to check the prefix in fqn

* fix query and sonar issue

* fix the asset not coming in Tier and Certification page tab

* fix the playwright failure
2024-11-26 19:07:46 +05:30
Aniket Katkar
998cbd1558
Improvements: Alerts bug fixes and improvements (#18753)
* Add and improve the permission logic for the notifications and observability alerts pages
Add logic to update the description from alert details page.
Add logic to set the logged in user as the owner while alert creation

* Remove the permission check for the `/{alertType}/resources` API since it's not necessary

* Update the playwright tests to cover the new alert features

* Add playwright to test the test destinations filter

* Fix the unit tests

* Add unit test for AlertRecentEventsTab component

* update the variable.less import to reference

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2024-11-26 18:00:58 +05:30
Sriharsha Chintalapani
9484d838a4
Minor: fix Lineage export when there is no column / pipeline edge (#18737)
* Minor: fix Lineage export when there is no column / pipeline edge

* add test for lineage export (#18709)

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>

* add lineage export tests

---------

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
Co-authored-by: Sweta Agarwalla <105535990+sweta1308@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>
2024-11-22 08:21:19 -08:00
Shailesh Parmar
cda201b1b8
Minor: supporting PR for UI/UX improvement in DQ (#18663)
* Minor: supporting PR for UI/UX improvement in DQ

* updated feedback

* move incidents tab to data observabilty tab

* fixed failing unit test

* fixed failing unit test

* fixed AUT failure!

* fixed failing aut

* minor fixes

* minor fix

* updated icon

* fixed failing unit test
2024-11-21 16:41:32 +05:30
Teddy
429e48aa3a
#18677 - Added Lineage Field back to SearchLineage (#18687)
* fix: add lineage field back to searchLineage

* add lineage tests

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
2024-11-20 11:13:09 +01:00
sonika-shah
853bbc205b
GEN-1983 : Feat - Support Tag Asset Page (#18505)
* Feat :  Support bulk adding tag to Assets

* remove warnings

* add apis for assets remove

* Fix: Add tag page (#18461)

* add tag page which all Assets

* update as per feedbacks

* update as per feedbacks

* add divider in header badge

* remove styling

* update permission and refactoring code

* updated as per comments

* fix sonar cloud issues

* add delete asset functionality

* refactor entityTypeString

* made the top bar fixed to top

* add tests for tag page

* fix check failures issue

* fix tag page check failure

* fix flaky test issue

* add tag page tests

* update the add asset test

* update playwright tests

* add right panel in tag page

* updated as per feedbacks

* remove usage test

* updated as per feedbacks

---------

* Backend: make bulkAssets api async

* Backend: limit bulkAssets api async to Tag Assets page

* Update Tag page Assets API (#18622)

* create branch

* update add asset API

* add websocket on tags page

---------

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>

* add failed case for socket operation

---------

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
Co-authored-by: Sweta Agarwalla <105535990+sweta1308@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>
2024-11-18 17:57:07 +05:30
Sachin Chaurasiya
be642e7253
GEN-1694: metric entity improvement (#18659)
* GEN-1694: metric entity improvement

* add clike and python language mode in schemaeditor

* add getMetricExpressionLanguageName util to extract the language from metric expression
2024-11-15 20:30:42 +05:30
Sweta Agarwalla
6cdfff35b5
MINOR: fix owner link and update search index in navbar (#18609)
* fix minor issues

* update owner column component

* update list sequence

* add database search indexes

* add navbar search dropdown tests

* updated owner snapshot

* update wait for response API

* fix tests

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
2024-11-15 13:22:59 +05:30
Aniket Katkar
bfc12feafc
GEN-1976: Alert improvements (#18448)
* Move the alert components to the components folder from pages folder

* auto generated localization changes and linting changes

* Fix the imports

* Add AlertConfigDetails component

* Add tabs in the alert details page

* auto generated localization changes

* Apply permissions for alert and add owner update functionality

* Change the alert update method from PUT to PATCH

* Add the recent events tab

* auto generated localization changes

* Improve the recent events tab for alert details

* Implement the logic to show alert events count on the alert details page

* auto generated localization and linting changes

* Add the pagination logic for the recent events list on the alert details page

* Fix the logic for previous click in NextPreviousWithOffset

* Localization change for other languages

* Hide pagination when not required

* Add pagination and permissions to API; create eventsRecord API; fix timestamp issue

* fix: remove publisherName from test destination message.

* Fix the recent events tab error

* fix: Resolve PATCH API issue with destination ID creation.

* fix: Delete associated alert metrics upon alert deletion

* feat: Detailed HTTP Response for Destination Test

* Add the test external destination functionality

* localization changes for other languages

* fix: Set status for testing destination in EmailPublisher

* Add advanced configurations for webhook destinations

* Localization changes for other languages

* Fix the destination status not showing
Add the POST and PUT radio button in advanced configs

* Localization changes for other languages

* Update the API to fetch the alert event diagnostic counts

* Improve the AlertConfigDetails component to show the alert configs properly

* fix: Display displayName instead of fullyQualifiedName in templates

* Fix the test destination result not showing the first time

* Fix the test destination status not showing for already existing destinations

* Fix the unit tests

* Fix playwright tests

* refactor: Separate sendMessage and sendTestMessage methods; add statusContext

* fix: Use name or fqn as fallback if displayName is null or empty

* fix: upsert successfulChangeEvent

* eliminate the GovernanceWorkflowChangeEvent option from external destination

* Add code comments

* Fix the unit test

---------

Co-authored-by: Siddhant <86899184+Siddhanttimeline@users.noreply.github.com>
Co-authored-by: Siddhanttimeline <siddhanttimeline9@gmail.com>
2024-11-14 17:39:45 +05:30
Shrushti Polekar
626464f443
Feat: Support for column customization for Glossary term table (#18584) 2024-11-14 10:22:11 +05:30