7194 Commits

Author SHA1 Message Date
Mohit Yadav
ee4f1b4e51
Add Stop Functionality For Reindex (#10971)
* Add stop Reindexing Job

* Languages

* Add Status

* Add Status

* Add messages
2023-04-10 13:15:44 +05:30
Shailesh Parmar
751919e6ca
fixes App Analytics summary not adjusting to the datetime [UI] #10571 (#10961)
* fixes App Analytics summary not adjusting to the datetime [UI] #10571

* added comments to the code

* updated sum logic, used sumBy method from lodash

* addressing comment
2023-04-10 07:38:44 +00:00
Chirag Madlani
6568d0df08
fix(test): reduce machin to 2 2023-04-10 12:45:09 +05:30
Shailesh Parmar
d79974dba1
ui: move queries from ES to REST API (#10947)
* initial commit for moving from ES to REST

* updated filters

* miner fix

* fixed failing unit test

* fixed failing cypress
2023-04-10 10:21:27 +05:30
karanh37
445ac90ef9
feat(ui): glossary versions page (#10966)
* fix: glossary right panel position fix

* fix: review comments

* feat: add deeplinks to tabs in glossary terms page

https://github.com/open-metadata/OpenMetadata/issues/10713

* fix: glossary feedback

* chore: update svg icon

* fix: missing localization keys

* fix: review comments

* fix: missing localization keys

* fix: review comments

* fix: jest tests

* feat: glossary ui improvements

* fix: missing localization keys

* fix: added error placeholder for assets

* fix: add icon to references

* fix: table issues

* feat: add glossary versions page

* fix: remove display name validations

* fix: localization keys

* fix cypress

* fix: button alignment

* fix: glossary version improvements

* fix: remove tooltip as not needed

* fix: update space direction

* fix cypress failure for ingestion tab

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-08 15:26:43 +05:30
karanh37
d5a0aa9af6
fix(ui): glossary improvements (#10823)
* fix: glossary right panel position fix

* fix: review comments

* feat: add deeplinks to tabs in glossary terms page

https://github.com/open-metadata/OpenMetadata/issues/10713

* fix: glossary feedback

* chore: update svg icon

* fix: missing localization keys

* fix: review comments

* fix: missing localization keys

* fix: review comments

* fix: jest tests

* feat: glossary ui improvements

* fix: missing localization keys

* fix: added error placeholder for assets

* fix: add icon to references

* fix: table issues

* fix: remove display name validations

* fix: localization keys

* fix: button alignment

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-07 20:55:49 +05:30
Chirag Madlani
8c6ae7f682
fixes: #10604: json viewer not loading properly (#10868)
* fix(ui): owner assignment issue
fix refresh token frame timeout issue
improve tier card
 - Remove clear all button
 - add remove button at tier level
fix: #10604

* fix tier select button styling
fix follow unfollow for dashboard

* fix unit tests

* fix unit tests

* change active tab based on owner

* fix sonar-cloud code smells

* fix edit owner cy failure

* fix cypress

* fix cypress for service and entityDetails

* fix cypress

* fix dashboard entityName issue

* fix unit tests

* fix cypress tests

* fix owner assigning cypress
2023-04-07 19:44:37 +05:30
Teddy
203f17fa49
fix: add rollback logic to custom sql query to exit out of transaction (#10968) 2023-04-07 14:46:05 +02:00
Aniket Katkar
d112b40a3f
fix(ui): API endpoints to fetch elastic search data on settings page. (#10946)
* Made changes to use the newly created APIs for fetching elasticSearch re-indexing data

* DOcs Fix and add validation

* Fixed APIs to fetch the batchJob reIndex data
worked on comments

---------

Co-authored-by: Sriharsha Chintalapani <harshach@users.noreply.github.com>
Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
2023-04-07 11:53:51 +05:30
Ashish Gupta
c997d8c80b
Feat #10584 : Support Activity tab for DataModel Entity (#10941)
* Supported DataModel in Dashboard Page

* url fqn changes

* Support Activity tab for DataModel Entity

* Remove dataModel resource descriptor

* Fix tasks for dashboard data models

* changes as per comments

* minor fix

* changes as per comments and minor improvements

---------

Co-authored-by: Nahuel Verdugo Revigliono <nahuel@getcollate.io>
2023-04-06 23:05:40 -07:00
Keith Sirmons
27984c25f3
Fixes 10959: MSSQL profile has error when averaging large integer column (#10960)
* updated metadata to work with the impala query engine.
Uses the describe function to grab column names, data types, and comments.

* added the ordinalPosition data point into the Column constructor.

* renamed variable to better describe its usage.

* updated profile errors.
Hive connections now comment columns by default.

* removed print statements

* Cleaned up code by pulling check into its own function

* Updated median function to return null when it is being used for first and third quartiles.

* updated metadata to work with the impala query engine.
Uses the describe function to grab column names, data types, and comments.

* added the ordinalPosition data point into the Column constructor.

* renamed variable to better describe its usage.

* updated profile errors.
Hive connections now comment columns by default.

* removed print statements

* Cleaned up code by pulling check into its own function

* Updated median function to return null when it is being used for first and third quartiles.

* removed print statements and ran make py_format

* updated to fix some pylint errors.
imported Dialects to remove string compare to "impala" engine

* moved huge comment into function docstring.
This comment shows us the sql to get quartiles in Impala

* added cast to decimal for column when running average in mean.py

* fixed lint error
2023-04-07 06:48:18 +02:00
Sriharsha Chintalapani
7c6b9b3c56
Update python sdk client connection details (#10963)
* Update python sdk client connection details

* Update index.md
2023-04-06 20:44:36 -07:00
Pere Miquel Brull
ac9979070a
[WIP] - Fixes #10725 - Fix extension in ingestion pipeline and delete statuses api (#10866)
* Fix extension in ingestion pipeline and delete statuses api

* Add tests for ingestion pipeline status

* Format
2023-04-06 19:12:18 +00:00
Hemal Mamtora
0206af0303
[WIP] Fixes #10721: created client file for metabase and moved get request to client file (#10838)
* ingestion/metadata - created client file and moved get request to client file

* moved code to client.py, created models.py

* added, self to MetabaseClient constructor

* added status_code in metabase client functions and handled Optional datatype in metabase metadata functions

* moved api calls to client

* passing service_connection and metabase_session from constructor to MetabaseClient

* renamed client to metabaseClient to avoid rewriting DashboardServiceSource.client

* moved post request from connection.py to client.py

* run make py_format

* moved client code to init constructor

* added Dashboard Model for Metabase

* updated client type to MetabaseClient and used get_dashboards_list() function in custom_executor

* updated client type to MetabaseClient and used get_dashboards_list() function in custom_executor

* make py_format

* pylint issues resolved

* pylint and run make py_format

* calling init method in Metabase source

* removed init method
2023-04-06 19:26:52 +02:00
karanh37
c1cbee3d1b
fix: user selectable list popover issues (#10799)
* fix: user selectable list popover issues

* fix: skip glossary tests

* fix: team cypress tests

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-06 22:55:45 +05:30
Keith Sirmons
42000053aa
Fixed Issue #10943: Impala query engine metadata ingestion and median function profiler (#10944)
* updated metadata to work with the impala query engine.
Uses the describe function to grab column names, data types, and comments.

* added the ordinalPosition data point into the Column constructor.

* renamed variable to better describe its usage.

* updated profile errors.
Hive connections now comment columns by default.

* removed print statements

* Cleaned up code by pulling check into its own function

* Updated median function to return null when it is being used for first and third quartiles.

* removed print statements and ran make py_format

* updated to fix some pylint errors.
imported Dialects to remove string compare to "impala" engine

* moved huge comment into function docstring.
This comment shows us the sql to get quartiles in Impala
2023-04-06 18:07:42 +02:00
Ashish Gupta
6f055fdb34
Fixes : #8732 Support displayName field in at Tags (#10767)
* Added displayName field in Tags

* localisation key added

* minor changes

* added tooltip

* remove rename option from outside and added it inside the form

* minor changes

* fix cypress issue

* changes as per comments

* fix cypress issue

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-06 21:15:37 +05:30
Pere Miquel Brull
cdd473c3b7
Add ingestionIpInfoEnabled configuration (#10870)
* Add ingestionIpInfoEnabled configuration

* Format

* hide ip address if api response if not 200

* removing dependancy on ip-modal and checking default state

* updated status code for ip to 204 to check default state

* fixed failing cypress

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
2023-04-06 16:27:07 +02:00
Aniket Katkar
942649f3b6
fixes #10755: Changed description change method for service connections from 'Put' to 'PATCH' (#10876)
* Changed description change method for service connections from 'Put' to 'PATCH'

* worked on comments

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-06 19:42:17 +05:30
Ashish Gupta
8e3e0002db
Feat #10584: Support Lineage for DataModel Entity (#10936)
* Supported DataModel in Dashboard Page

* url fqn changes

* Support Lineage for DataModel Entity

* added datamodel icon

* minor changes

* changes as per comments

* remove unwanted lineage code
2023-04-06 19:33:49 +05:30
Shailesh Parmar
c45d889d5f
cypress: fix failing cypress test (#10953) 2023-04-06 12:22:11 +00:00
Ashish Gupta
059f53b0da
Change object label and added container filter pattern in Metadata (#10861)
Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-06 17:26:06 +05:30
Ashish Gupta
8fb2f13f1e
Feat #10584 : Support SQL tab in Data Model Entity (#10938)
* Supported DataModel in Dashboard Page

* url fqn changes

* Added Sql tab in Data Model Entity

* if sql is not there tab will not be shown

* fix the delete entity failure
2023-04-06 17:23:09 +05:30
Aniket Katkar
d0c0942e1b
fix 10685: test suite related bug fixes and improvements (#10899)
* made changes to redirect user to test suite listing page after test suite deletion instead of homepage

* removed unnecessary fields being passed to API call for fetching for entity summary panel

* removed unnecessary fields being passed to API call for fetching test case results in dataset details page

* Added action column to the test suite list page inside tables for delete action

* fixed an issue with the test case form where going back and forth through steps was making fields unresponsive

* fixed unit tests

* fixed test suite deletion issue

* Revert changes for TableProfilerV1
2023-04-06 15:19:53 +05:30
Ashish Gupta
4001aa0ccc
feat #10584 : Supported DataModel in Dashboard Page (#10931)
* Supported DataModel in Dashboard Page

* url fqn changes

* changes as per comments
2023-04-06 15:03:30 +05:30
Nahuel
62b88b0404
Fix#10584: Add lineage for Tableau data models (#10923)
* Refactor Tableau ingestion

* Add lineage from DB -> DataModel -> Dashboard

* Address PR comments

* Address PR comments
2023-04-06 07:28:41 +02:00
Mohit Yadav
ec6ff78b80
fixes for Reindex (#10948)
* fixes for Reindex

* review comments
2023-04-06 10:50:08 +05:30
Pere Miquel Brull
c53c7b680d
Rel #10828 - Update container index and fix airflow ingestion (#10873)
* Update container index and fix airflow ingestion

* Fix lint

---------

Co-authored-by: Ayush Shah <ayush@getcollate.io>
2023-04-06 07:09:38 +02:00
Deepa Rao
38d4afb6cb
Fixes #10924 - Trim the redundant permissions in the permission list (#10928)
* Fixes #10924 - Trim the redundant permissions in the permission list

* Fixes #10924 - Trim the redundant permissions in the permission list
2023-04-05 19:01:27 -07:00
Sachin Chaurasiya
922a8079b1
fix(#10905):API documentation does not show bullets from Markdown (#10932) 2023-04-05 23:00:30 +05:30
Teddy
06b8d8e7ce
fix: explicitly state USE CATALOG for databricks connection (#10940) 2023-04-05 18:47:18 +02:00
Teddy
4683bee91a
Fixes #10911 - Improve Data Insight Logging (#10915) 2023-04-05 18:46:39 +02:00
Shailesh Parmar
8ac6ce9f7a
cypress: fix flaky cypress test from main (#10937)
* cypress: fix flaky cypress test from main

* fixed tags spec

* skipping `Add tag at DatabaseSchema level with task & suggestions` test
2023-04-05 20:32:48 +05:30
Sriharsha Chintalapani
eb92ea9069
Fix #10808: Add configuration to enable HSTS, X-Frame-Options, X-Cont… (#10809)
* Fix #10808: Add configuration to enable HSTS, X-Frame-Options, X-Content-Type-Options etc..

* Fix #10808: Add configuration to enable HSTS, X-Frame-Options, X-Content-Type-Options etc..
2023-04-05 16:50:12 +02:00
Akash Jain
bac0b637ce
fix(CI): Run on main branch with all changes except docs (#10942) 2023-04-05 20:01:21 +05:30
Onkar Ravgan
c3e28bcf56
Remove the non-required fields from manifest file (#10935)
* remove non required manifest keys

* Added comment

* Addressed review comments
2023-04-05 19:39:53 +05:30
Mohit Yadav
07b821844a
Restructured Reindexing + Added Automated Reindexing on Glossary import (#10882)
* Restructured Reindexing + Added Automated Reindexing on Glossary import

* Revert Openmetadata yaml

* Fix pending issues

* Fix stats

* Refactor to workflows and SearchIndex

* Fix Failing tests

* Get status for stream and push status with

* fix UI build failing

* replace all with entity list before hit api

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-05 18:47:51 +05:30
Sriharsha Chintalapani
b1c2040cb2
Fix #10904, Glossary Search: no Matches info for Synonyms (#10909) 2023-04-05 05:57:20 -07:00
Anuj359
d9b56b4e6b
Fixing the Typo error (#10939) 2023-04-05 18:24:32 +05:30
Ashish Gupta
53a2f32de7
Fixes #10612 : Change error message for already exist entity (#10785)
* Change error message for already exist in glossary/term and user

* localisation key added

* change error for user,bots,roles and policies

* localisation key added

* minor changes

* localisation key added

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-05 10:44:53 +00:00
NiharDoshi99
c44b0bbcea
adding timeout option for Dagster and Amundsen changes (#10934)
* adding timeout option for dagster and amundsen changes

* Update ingestion/src/metadata/ingestion/source/pipeline/dagster/connection.py

Co-authored-by: Mayur Singal <39544459+ulixius9@users.noreply.github.com>

---------

Co-authored-by: Mayur Singal <39544459+ulixius9@users.noreply.github.com>
2023-04-05 10:33:30 +00:00
Chirag Madlani
4ef86a1694
update ui codeowners 2023-04-05 14:56:19 +05:30
Mayur Singal
9ed1fc4e17
Test Connection Improvements: Short Circuit Test Connection & Improve Error Messages (#10913) 2023-04-05 13:23:57 +05:30
07Himank
b97d6d9014
solved url isse when space is involed in fqn (#10929)
Co-authored-by: Himank Mehta <himankmehta@Himanks-MacBook-Air.local>
Co-authored-by: Mohit Yadav <105265192+mohityadav766@users.noreply.github.com>
2023-04-05 13:14:41 +05:30
Mayur Singal
d7e0153000
Fix #10896: Fix snappy coded issue (#10919) 2023-04-05 12:12:47 +05:30
Sachin Chaurasiya
31a5464090
chore(ui): Show error message if test definition API fails (#10885)
* chore(ui): Show error message if test definition API fails

* test: add unit test

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-05 11:03:19 +05:30
Shailesh Parmar
d5a072d83b
Fixes #7044 Handle database filter in ingestion pipeline when connection specifies a database from UI side #7044 (#10766)
* Fixes Handle databse filter in ingestion pipeline when connection specifies a database  #7044

* fix: Handle databse filter in ingestion pipeline when connection specifies a database  #7044

* sync-translation

* fixed unit test

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-05 11:01:19 +05:30
Chirag Madlani
abb3c8259f
fix(ui): setting page issue with language change (#10842)
teams selection issue on user page
2023-04-05 10:51:42 +05:30
Chirag Madlani
774a3346c0
fix(ui): show system badge for system tags (#10654)
* fix(ui): show system badge for system tags

* rename file to coding standards

* fix cypress failure

* update badge styling to details

* update badge styling
added unit tests
2023-04-05 10:51:07 +05:30
Chirag Madlani
5a9173df0f
fix(ui): entity selection for es re-indexing (#10783)
* fix(ui): entity selection for es re-indexing

* Add query and container for reindexing

* add tree view for entity selection

* fix tree view for entities

---------

Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
2023-04-05 10:49:57 +05:30