5 Commits

Author SHA1 Message Date
Ashish Gupta
c406cceb9a
#19432: fix the description renderer in glossary import (#19450)
* fix the description renderer in glossary import

* added test for the same
2025-01-22 16:22:44 +05:30
Sachin Chaurasiya
4f3ae5d083
feat(#15380): replace description editor with block editor (#19003)
* feat(#15380): replace the description editor with a new block editor.

* chore: Add placeholder support to BlockEditor

* feat: Add autofocus support to BlockEditor

* chore: implement block editor in richtext editor

* chore: Remove unused CSS import in RichTextEditor

* fix: ensure safe access to getEditorContent in Markdown editor components

* minor change

* fix: add support for ttf file extension in pom.xml

* fix: adjust block editor styles for better usability and overflow handling

* fix: update RichTextEditorPreviewer to RichTextEditorPreviewerV1 and adjust block editor styles

* fix: update description box selector to use om-block-editor for consistency

* fix: disable autoFocus on BlockEditor in RichTextEditorPreviewerV1

* refactor: update RichTextEditorPreviewer references to RichTextEditorPreviewerV1 in tests

* test: update timer handling in ApplicationCard and SuggestionsAlert tests

* fix(diff): update diff view rendering and attributes for consistency

* fix(RichTextEditor): add placeholder for empty markdown descriptions

* Add data-diff in <span>

* Fix test

* fix: update description box selector to use locator method for better reliability

* feat: integrate RichTextEditorPreviewerV1 for description rendering in Notification and Observability Alerts pages

* feat: add markdown conversion for mentions and hashtags in BlockEditorUtils

* fix: update initial value handling in TagsForm and formUtils

* MINOR - Update description handling in Playwright tests and utilities

* Refactor Playwright tests to use descriptionBox for tag and team descriptions

* Refactor custom property handling and update description check logic

* Enhance entity version page tests by adding description box read-only check and updating data-testid attributes

* Refactor description handling and improve diff rendering logic in task pages

* Fix user description clearing logic in UserDetails.spec.ts

* Enhance Rich Text Editor by adding custom styles and converting markdown to HTML for backward compatibility

* Remove test for rendering alert description when not present in AlertDetailsPage

* Clean up RichTextEditorPreviewerV1 by removing unnecessary comments and improving readability

* Update SearchIndexApplication.spec.ts to select 'Table' instead of 'Topic' in the tree widget

* Refactor BlockEditor and FeedUtils to improve code organization and readability

* Fix regex in getTextFromHtmlString to correctly remove HTML tags

* Add tests for getTextFromHtmlString and improve HTML tag removal regex

---------

Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
2024-12-27 20:57:37 +05:30
sonika-shah
30497528bc
feat: add Import/export support for table type custom property in glossary (#18262)
* import/export support for table type custom property

* remove logs

* Add backend tests

* ui: add custom type property parsing

* print rows in the order of columns defined in config

* ui: handle special chars pasring for custom property import/export

* ui:improve table type property parsing

* ui:fix sql input styling

* ui: improve the parsing for table type property

* ui: fix parsing for markdown, string and sqlQuery properties

* ui: fix parsing for table type property

* ui: fix unit test

* fix backend tests

* remove unwanted comments

* ui: add playwright test for table type import/export part1

---------

Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com>
2024-10-16 15:44:38 +05:30
sonika-shah
7d736f6195
Feature : Add table-type custom property (#18135)
* Feature : Add table-type custom property

* ui: remove enumWithDescriptions property

* Refactor AddCustomProperty component to remove unused EnumWithDescriptionsConfig import and property

* ui: add support for creating and updating the table-type property

* add rowCount field in table-type and clean logic of validation

* add rowCount field in table-type and clean logic of validation

* add rowCount field in table-type and clean logic of validation

* ui: add support for adding value to table type property part 1

* use rowCount from the API

* default row-count to 10

* fix tooltip to read rowcount from the props

* fix empty row issue

* rename from table-type to table-cp

* Refactor table type property to handle empty rows and display in modal

* Refactor table type property to handle empty rows and display in modal

* use locales for messages

* minor change

* ui: use column layout for rendering custom properties cards

* remove enumwithDescriptions from backend and add tests for table type

* fix unit test

* fix playwright

---------

Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com>
2024-10-10 13:43:19 -07:00
sonika-shah
1d727d57bd
Feature: Allow Custom Property Update in Glossary Bulk Import/export (#17919)
* fix import issue

* Feat : Allow Custom Property Update in Bulk Upload

* Feat : Allow Custom Property Update in Bulk Upload

* supported editable imports in glossary page

* added remaning localizaion keys

* update logic of fieldToExtensionStrings to use csvparser

* update json and partialStatus condition

* fix tests for partialSuccess status change

* supported customProperty editable field

* fix error in custom property edit modal on new line empty custom property

* added entity type from root to support other bulk import entity as well

* fix the quote removing due to the regex in the string type

* Add backend tests , and error msg improvements

* GlossaryStatus header change

* fix unit test and dry run in case of synonyms having quotes in it

* Remove extension column in CSVs for all entities except glossaryTerm

* added editor for reviewers

* unit test around csv utils

* added escape for string too, in case of semicolon comes

* added playwright test without extension and supported relatedTerm as editable

* added unit test around csv util logic

* resolve conflicts

* Backend - add support for enumWithDescriptions in bulk import

* add tests and other error handling improvements related to enumWithDescriptions

* fix the custom property modal header and render the layout as per right panel in entities

* parese enumWithDescription for the customProperty modal while editable

* fix description data in enumWithDescription one

* fix: Handle NullPointerException when adding custom properties to ensure loop continues for other schemas of the same type for addToRegistry

* added extension playwrigth test and fix enumWithDescription object failure

* descrease the size of extension  modal

* remove additional comments

* fix the escape in parent key

* improve custom property layout

* improve ui for inline properties

* fix description, glossary and relatedTerm escape char issue

* fix some customProperty ui changes

* fix sonar issue

* minor layout changes

* minor label improvements for entity ref and list

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com>
2024-10-01 00:12:43 +05:30