92 Commits

Author SHA1 Message Date
Chirag Madlani
98f3f0708c
[WIP] Cypress organise (#14419)
* chore(test): organise cypress tests

* improve entity tests

* update tests

* support service spec

* fixed glossary term issue

* support custom properties

* fix tier flakiness

* fix failing tests

* fix service spec and add search index tests

* update tests

* enhance tests to cover Database related entities

* fix database spec

* fix tests

* add dashabord datamodel entity

* run all the specs

* fix import error

* fix test

* fix some tests

* support soft deleted checks

* address comments

* fix test failures

* fix test failures

* reduce test results count to avoid cypress limit

* fix test issues

* fix updateDisplayName spec

* fix custom property and visit entity issues

* Fix DQ tests
2024-01-08 15:23:39 +05:30
Abhishek Porwal
4c1c91e6ba
fix: issue-12540 and issue-13992 (apply highlights and sort in summary column as well as for tags). (#14253)
* sort the summarylist items based on the
glossary-term-page and applied tags in explore page

* change path split logic to get the current glossary term

* sort the tags in summaryItem based on current glossary

* prettier-fix

* minor changes

* variable name changed

* unit test update for the sorting items based on tags in entity-summary-panel-utils

* added tag highlight for column tags

* fix: existing e2e test break in glossary.spec file

* e2e for checking the column sort based on current term page in right panel

* minor changes

* e2e for checking columnTagHighlight with sort on term page

* add page tag sort functionality based on filter applied in explore page and based on current term in glossary term page

* minor change

* implement summaeryItem  highlight and sort on global search + also when apply filter

* fix: for the first render after search first elements right panel name, description etc not get highlighted

* Revert "fix: for the first render after search first elements right panel name, description etc not get highlighted"

This reverts commit e69512d625f412263e925598846a0e104561a07c.

* minor change

* add tags sort and highlight functionality in StoreProcedure Page

* add tag sort and highlight functionality in dashboard

* add summary list and tags sort and highlight functionality in Dashboard Data Modal

* remove repeated code and optimize the getFormatEntityData method

* add sort and highlight for global search and filter in Pipeline component

* minor change to fix the entity details value not get parse in some cases

* add sort and highlight for topics in explore page

* added sort and highlight fn for MlModels in explore page

* added sort and highlight functionality for Containers in explore page

* add sort and highlights for charts data

* add sort and filter functionality for searchIndexs in explore page

* cleanup first

* cleanup 2

* move constant in separate file

* some type fix and cleanup

* minor fix

* fix unit test for EntitySummaryPanelUtils

* minor fix

* revert some change and fix unit test in SearchIndexSummary component

* revert some change

* constant file name change

* update the highlight keys constant and add sort and highlight summary list based on column description also

* cleanup in EntitySummaryPanelUtils

* type errors fixing

* fixing type issues wip

* revert a change

* change a variable name and fix type error

* change the sequence of parameter in getFormattedEntityData fn

* fix unit test

* fix type issues

* fix e2e test for sorting and highlighting summaryList and its tag

* added sort and highlight for DatabaseSummary component

* added sort and highlight for DatabaseSchemaSummary component

* added sort and highlight in different service-summary component

* fix: right panel entity display name and description not get highlight on search until we select a entity card

* address comments

* address comments

* address comments 3

* fix: unit test fail after addressing comments

* address comments

* revert some change

* added unit test for newly added methods in EntitySummaryPanelUtils

* added unit test for highlightEntityNameAndDescription method

* fix conflict after taking pull and some cleanup

---------

Co-authored-by: karanh37 <33024356+karanh37@users.noreply.github.com>
2023-12-20 10:57:59 +05:30
karanh37
a215f03a28
Assets improvements part 2 (#14255)
* fix: make filters consistent

* disable if no selection

* fix: hide notification

* fix: failed status data

* localization

* fix notification loading

* remove close icon here

* fix: cypress

* update error alert design

* fix alert styling

* fix: minor issues

* fix: redirect link of data product

* fix: minor suggestion prompt

* complete user flow

* fix: glossary cypress

* update alert view

* fix tags manipulation

* fix: domain reload fixes

Co-Authored-By: Ashish Gupta <ashish@getcollate.io>

* fix: minor loading issue on delete

* fix: add admin check for activity feed

Co-Authored-By: Ashish Gupta <ashish@getcollate.io>

* fix: minor css fixes

* fix: localisation

* fix: minor issue

* miner cypress fix

* add mlmodelservice as mlmodel parent

* fix: added null checks

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
Co-authored-by: 07Himank <himank07mehta@gmail.com>
2023-12-06 23:25:40 +05:30
karanh37
f32b4d4c47
Assets filters (#14229)
* assets filter

* localisation

* update filters

* fix: update filters on teams page

* hide searchbar & restrict adding assets for draft

* fix: code smells

* fix: encoding decoding issues

* fix: css

* fix: add permissions check

* fix(ui): throw validation errors while modifying glossary term (#14236)

* fix(ui): throw validation errors while modifying glossary term

* update modal layout

* fix: domain cypress

* minor update

* update modal

* fix: glossary cypress

* fix: show inline errors

* fix comments

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-12-05 23:55:06 +05:30
Mohit Yadav
64a56b0183
FEAT Fix Issues in Glosary (#14197)
* Fix User Startup Email

* Add Apis for validation and addtion glossary tags and assets

* Update Status to ApiStatus

* Unique Tags to be listed

* Fix in tag additon

* fix: asset selection modal improvements (#14152)

* fix: assets fqn issue (#14140)

* fix: assets fqn issue

* fix: unit tests

* fix: escape fqn in remaining areas

* fix: domain cypress for adding assets

* fix: add assets to data products cypress

* update imports

* add cypress for glossary term

* fix: loading in asset modal and add cypress

* fix: unit tests

* fix: reintroduce filters in asset selection modal

* fix: update assets

* localization

* Fixes and Refactor redundant code

* Revert

* Add Delete API for removing tags from assets

* ADd ES calls

* Fix Assests added in case of errors

* ui updates

* ui changes

* Add Conditional Validate for SubFields

---------

Co-authored-by: karanh37 <33024356+karanh37@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>
2023-12-03 00:57:03 +05:30
Aniket Katkar
308381c56b
chore(ui): added cypress tests for soft delete entity flow (#13951)
* Added cypress for soft delete and entity edit actions check flow

* added cypress tests for teams page for soft deletion flow

* fixed entity deleting without entering confirmation text

* localization changes for other languages

* added cypress changes for delete widget confirmation text check

* fixed delete text retaining after closing modal

* refactored the cypress for soft delete flow to

* renamed the files according to the naming convention

* worked on comments and cypress test improvements

* fixed failing cypress

* fixed TagsAddRemove spec

* test code improvements

* moved util functions to appropriate files
reference type cypress comment fix

* replaced react router Link component with anchor tag

* Delete widget code refactoring

* fixed issue with child assets not updating correctly after soft deletion of database, database schema and service pages

* Fixed cypress imports

* Fixed delete modal input value retaining issue

* fixed import issue in dataQualityTest

---------

Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
2023-11-27 15:31:52 +05:30
Shailesh Parmar
6dc630b685
cypress: fixed cypress AUT failure part 4 (#13840) 2023-11-04 12:37:54 +05:30
Shailesh Parmar
306c8ecfbe
cypress: fixed AUT cypress test part 2 (#13818) 2023-11-02 10:39:10 +05:30
Shailesh Parmar
1bd833d9a2
cypress: fixed failing cypress of main and downgraded cypress version to 12.17.4 (#13656) 2023-10-20 10:07:51 +05:30
Shailesh Parmar
accbc59d76
cypress: fixed failing cypress in main (part-1) (#13623)
* cypress: fixed failing cypress in main (part-1)

* fixed failing cypress

* fixed failing cypress test

* fixed ETE test
2023-10-19 14:09:25 +05:30
Chirag Madlani
5202312f77
move services tests to service folder (#13573)
* move services tests to service folder

* skip DQ cypress

* fix cypress

* fixed some cypress
2023-10-16 23:08:07 +05:30
Shailesh Parmar
b478039207
feat(ui): Add Badge with color or icon for Tags,GlossaryTerm, Domain and DataProducts #9972 (#13349)
* feat(ui): Add Badge with color or icon for Tags,GlossaryTerm, Domain and DataProducts #9972

* added api call to patch style in glossary

* updated and refactor AsyncSelectList and tagsContainerV2

* updated tags in all the pages

* added style object in addGlossaryTerm form

* added style support in domain and tags

* fixed failing unit test

* added cypress for the style feature

* added unit test for new component

* translation-sync

* addressing comment

* fixed edit tags issue

* added style feature for domain

* fixed sonarLint

* fixed merge issue
2023-10-04 21:50:39 +05:30
Ashish Gupta
e879d512d3
fix(ui): initial load tab details in container page (#13399)
* fix intial load tab details in container page

* fix update displayName tests

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-10-02 16:26:01 +05:30
Ashish Gupta
8b37b92ffd
supported cypress for stored procedure and data models (#13312)
* supported cypress for stored procedure and data models

* fix failing cypress

* remove data model cypress
2023-09-25 21:53:03 +05:30
karanh37
54e7e81c09
feat: domains ui part 2 (#13133)
* feat: add domain version page

* added domain index .. . support for domain name .. experts and delete is left

* checkstyle

* domain list

* fix: domain selectable list changes

* fix: add missing fields

* fix: add services support for domain

* fix: review comments

* fix: review comments

---------

Co-authored-by: 07Himank <himank07mehta@gmail.com>
2023-09-12 14:17:36 +05:30
karanh37
b6bab6c7dd
feat(ui): Domains functionality (#12839) 2023-09-07 12:26:25 +05:30
Sachin Chaurasiya
6e2a8d0e4f
feat(ui): generate ingestion workflow form from schema (#12774) 2023-08-20 12:01:06 +05:30
Shailesh Parmar
c88ac0dd5c
ui: replace encodeURI with encodeURIComponent in entity details page (#12827) 2023-08-10 11:33:08 +05:30
Aniket Katkar
db090ec81f
Cypress upgrade tests part 3 (#12626)
* Fixed upgrade cypress tests for AddAndRemoveTierAndOwner and AdvancedSearchQuickFilters specs

* fixed failing cypress tests

* fixed unit test

* updated the cypress config to add `experimentalMemoryManagement` option

* fixed flakiness test

* added wait to avoid flakiness

* changes to avoid flakiness while adding tier
unskipped tests

* worked on comments

* fixed Teams cypress spec

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
2023-07-31 11:23:31 +05:30
karanh37
94d49e1c53
fix: cypress issues (#12620)
* fix: cypress issues

* fix: cypress tests

* fix: tags cypress

* miner fix in tag spec

---------

Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
2023-07-28 14:54:38 +05:30
07Himank
db5f6c594c
added missing aggregation for query API (#12395)
* added  missing aggregation

* fix: update aggregations keys in ui

* added field owner in glossary_search_index

* added filtering on aggregation

* working on filtering aggregation

* fix: update aggregate api

* fix: cypress tests

* fix: excluding cypress folder in sonar properties

* aggregation changes from backend for opensearch and elasticsearch

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>
Co-authored-by: karanh37 <33024356+karanh37@users.noreply.github.com>
2023-07-23 11:28:02 +05:30
Chirag Madlani
2260b8da32
test(ui): e2e tests for recently viewed (#12506) 2023-07-19 21:24:02 +05:30
07Himank
b6d5a438ec
Support '%' in entity Name (#12382)
* added support for the % in entity name

* added support for the % in glossary and glossary term  name

* Added U exclude

* Fixed pytest

* fix: support % in glossary name

* added suppport for % in entityName

* fix % issue in the glossary or term

* fix: glossary with % encoding

* fix: tags redirect issue for glossaries with %

* fix: glossary import path

* fixed CI

* fixed Py Test

* fixed PyTest

* fixed glossary resource test

---------

Co-authored-by: Onkar Ravgan <onkar.10r@gmail.com>
Co-authored-by: karanh37 <karanh37@gmail.com>
Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Co-authored-by: karanh37 <33024356+karanh37@users.noreply.github.com>
2023-07-18 17:58:16 +05:30
Shailesh Parmar
4e217aa00f
ui: worked on skip test of the cypress (#12430)
* ui: worked on skip test of the cypress

* fixed data quality skip test

* fixed failing cypress
- redshiftWithDBT
- DataQuality
2023-07-17 11:27:40 +00:00
Chirag Madlani
6dca644c46
fix(ui): cypress fix for login with email (#12306) 2023-07-05 21:13:29 +05:30
Ashish Gupta
af6cec6c9f
feat(ui): supported pagination and search in tags and term select for both table and entity level (#12155)
* supported pagination and search in tags and term select for both table and entity level

* supported pagination of tags in glossary overiew section for tags

* fix cypress and address comments

* fix cypress issue
2023-06-27 17:40:25 +05:30
Sachin Chaurasiya
6b61d36415
refactor: glossary and glossary terms form (#11780)
* refactor: glossary and glossary terms form

* refactor glossary term form

* fix: types import

* fix: field props

* chore: update name validation message

* fix: cy test

* refactor: glossary term reference field

* fix: code smell

* test: add e2e test
2023-05-29 21:45:52 +05:30
Sachin Chaurasiya
9edbea2b91
refactor: classification and tags form (#11706) 2023-05-24 08:25:58 +00:00
Shailesh Parmar
91ec1e3c38
test: add e2e flow for airflow, mlmodel and s3 storage service (#11680)
* cypress: added cypress for airflow,mlmodel and s3Storage service

* addressing comments

* fixed failing cypress

* updated description of describe block

* fixed failing cypress test

* added wait on pipeline status

* skip the delete test for s3Storage service and remove reload on re-running metadata pipeline
2023-05-22 16:25:03 +05:30
Sachin Chaurasiya
fb315d5122
refactor: custom property form (#11656)
* refactor: custom property form

* fix: unit and cypress test

* test: update cypress test

* update unit test

* add micro interaction

* fix: routing

* fix: code smells

* refactor: types for form handle submit data
2023-05-22 14:22:57 +05:30
Shailesh Parmar
fc4f955b9f
Cypress: Added cypress test for update display name feature and delete service issue (#11643)
* Cypress: Added cypress test for update display name feature and delete service issue

* cypress for datamodel

* rename cypress file

* improve test for update displayName
2023-05-19 10:37:40 +05:30
Shailesh Parmar
4bcc7d9eab
feat: added cypress flow of add and remove owner and tier (#11419)
* feat: added cypress flow of add and remove owner and tier

* fixed failing cypress for service page

* fixed entitydetails spec failure

* addressing comment
2023-05-04 17:36:24 +05:30
Teddy
3524df3389
Use display name in dq (#11200) 2023-04-24 22:12:40 +05:30
Shailesh Parmar
80aa7b27b0
ui: feedback 1.0 part-1 (#11141)
* ui: feedback 1.0 part-1

* fixed failing cypress

* fixed: flow is broken when cancelling the creation of a column level test

* implemented functionality to persist selected tab for table profiler

* fixed failing unit test

* miner fix

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-20 07:05:38 +00:00
karanh37
51bf8cd754
fix: glossary route path for add term (#11000)
* fix: glossary route path for add term

* fix: jest test

* fix: improvements on glossary screen

* fix: glossary comments

* fix: update cypress

* fix: cypress tests

* fix: update cypress tests

* fix: update icon

* fix: tag styles

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-12 11:12:04 +00:00
Ashish Gupta
6f055fdb34
Fixes : #8732 Support displayName field in at Tags (#10767)
* Added displayName field in Tags

* localisation key added

* minor changes

* added tooltip

* remove rename option from outside and added it inside the form

* minor changes

* fix cypress issue

* changes as per comments

* fix cypress issue

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2023-04-06 21:15:37 +05:30
Shailesh Parmar
c45d889d5f
cypress: fix failing cypress test (#10953) 2023-04-06 12:22:11 +00:00
Chirag Madlani
bae95c5314
feat(ui): consistent user dropdown for owner and reviewers (#10617)
* feat(ui): consistent user dropdown for owner and reviewers

* feat(ui): consistent user dropdown for owner and reviewers

* make component working with pages
update styles
add few more components like count details, color update on tags

* remove AddUserModal component

* fix owner edit for netity page

* add tests for selectable list

* remove reference for OwnerWidgetWrapper
update tests to reduce console error on test run

* remove count

* fix sonarcloud and ui

* remove OwnerWidget

* minor fixes

* verify reviewer and owner modal behavior

* fix tests

* fix minor UI glitches

* fix unit tests

* fix cypress

* fix cypress failures

* fix search and glossary cypress failure

* minor fix

* fix remaining cypress tests

* remove intercept for terms

* fix issues

* address comments

* skip falky test to avoid failures
2023-03-28 14:39:41 +05:30
Chirag Madlani
c4c510443b
fix(test): redshiftWithDBT cypress failure for lineage (#10754)
Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
2023-03-25 00:30:17 +05:30
Sachin Chaurasiya
cc27a6ce0d
chore(ui): Bring back the count for services, teams, and users, and remove the count for glossaries on the landing page. (#10719) 2023-03-24 09:23:34 +05:30
Ashish Gupta
f15a752706
UI : Added show deleted table in Database schema level (#10672)
* Added show deleted table in Database scheam level

* Changes as per comments

* fix cypress issue

* make switch label static

* other language

* fix cypress issue
2023-03-22 16:16:08 +05:30
Sachin Chaurasiya
55fde2d775
chore(ui): add glossary and glossary terms count on landing page (#10640)
* chore(ui): add glossary and glossary terms count on landing page

* sync local files

* chore: update icon for glossary term

* fix: cy test

* sync locales

* address comment

* fix: cy test

* fix: cy test

* fix: cy test
2023-03-21 19:33:44 +05:30
Shailesh Parmar
8412ed7545
fixed mydata flaky cypress test (#10540)
* fixed mydata flaky cypress test

* fixed glossary cypress

* fixed tags cypress
2023-03-14 10:33:51 +05:30
Ashish Gupta
c0fe8ec871
UI : Added tags at schema Level (#10471)
* Added tags at schema Level

* Add task handling for Database Schema

* added cypress and unit test

* Changes as per comments

---------

Co-authored-by: Mohit Yadav <105265192+mohityadav766@users.noreply.github.com>
Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
2023-03-13 16:54:35 +00:00
Shailesh Parmar
cb14bb6a63
Cypress: add cypress test for glossary part 2 (#10180)
* Cypress: added cypress for glossary part 2

* fixed add reviewer issue in create glossary term page

* fixed failing cypress
2023-02-22 19:41:40 +05:30
Ashish Gupta
942b553edc
UI : Fix Test cases breaking issue while editing (#10095)
* Fix Test cases while edit

* Added cypress for null test type

* fix unit test issue
2023-02-03 16:30:50 +05:30
Ashish Gupta
ca20029d75
UI : Added cypress for mutually exclusive tags (#9804)
* Added cypress for mutually exclusive tags

* chanegs as per comments

Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com>
2023-01-19 16:47:44 +05:30
Chirag Madlani
ec61e94bb8
chore(ui): support lint & prettier for cypress files (#9728) 2023-01-15 18:24:10 +05:30
Onkar Ravgan
e9ac8ecb85
Fix 7972: Added dbt tag classification name (#9575)
* Added dbt tag classification name

* resolved merge conflicts

* handle ui side change for dbt schema change

* Fixed migration scripts

* fixed failing cypress for dbt

Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
2023-01-06 11:08:21 +05:30
Chirag Madlani
5de9658545
test(ui): cypress added for alerts flow (#9527)
* test(ui): cypress added for alerts flow

* skip flaky user test

* fix failure

* comment addressed

* update datatestid
2022-12-30 15:40:52 +05:30