5356 Commits

Author SHA1 Message Date
Satish
cad41cd445 Merge branch 'domain-revamp' of https://github.com/open-metadata/OpenMetadata into domain-revamp 2025-10-01 15:43:28 +05:30
Satish
c86fe01f59 test: fix Playwright test timeouts in domain and data product selection
- Wait for initial page load before searching in selectDomain
- Wait for initial page load before searching in selectDataProduct
- Use data-testid selector instead of text filter in selectDataProduct
- Add 15s timeout to data product click action

Prevents race conditions where search interferes with initial page load,
fixing "Target page, context or browser has been closed" timeout errors.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-10-01 15:38:26 +05:30
Ushran Gouhar
f2b7447114
Set searchbox width through props (#23655) 2025-10-01 15:02:11 +05:30
Satish
adf6967c40 Update tests and remove domain filter 2025-10-01 12:57:06 +05:30
satish
f16aea3d43
Merge branch 'main' into domain-revamp 2025-10-01 10:14:12 +05:30
Shrushti Polekar
1fb18ef815
fix test (#23412) 2025-09-30 23:26:21 +05:30
Satish
107aeb0383 test: fix Playwright domain and subdomain test selectors
- Add data-testid to table rows for reliable subdomain selection
- Fix race conditions using Promise.all() pattern
- Update search box locator from getByRole to getByPlaceholder
- Add skipDomainSelection parameter to prevent redundant navigation
- Update IngestionBot test to skip domain selection when already on page

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-09-30 22:27:58 +05:30
Ushran Gouhar
f4026d5b84 Move add domain form styles into a new file 2025-09-30 20:40:29 +05:30
Ashish Gupta
dbf482f8da
support owner operation with editOwner and editALL for teams (#23625)
* support owner opertaion with editOwner and editALL for teams

* remove the isAdmin condition here, as for admin there will be editALL permissionby default

* fix the playwright test

* used the getPrioritizedEditPermission method for permission check
2025-09-30 20:12:54 +05:30
Ushran Gouhar
3ad495b47f Add 2px gap between label and info icon 2025-09-30 20:12:34 +05:30
Satish
3967e56c5c test: improve Playwright test reliability with timeouts and race condition fixes
- Fix race condition in subdomain creation test using Promise.all
- Add 15-second timeouts to element visibility checks across domain tests
- Add timeouts to tab clicks and count verification functions
- Prevent flaky test failures in CI/CD environments

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-09-30 20:02:24 +05:30
Shrushti Polekar
d0074d748a
SSO minor improvements around field level errors (#23607)
* remove provider-name from required fields for configured sso

* added live validations for public key url

* update oidc request scope to array field on ui

* added translation files

* address pr comment

* address pr comment
2025-09-30 18:59:42 +05:30
Ushran Gouhar
f093042245
Add default icons for domains and data product (#23633) 2025-09-30 17:39:26 +05:30
Satish
9738a64b6f feat: add closeSnackbar functionality to domain and data product form notifications
- Enable manual dismissal of success/error notifications for form submissions
- Update DataProductListPage and DomainDetailsPage notification calls
- Improve user control over notification lifecycle for key actions

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-09-30 15:22:32 +05:30
satish
883c0d7b29
feat: update domain-related test IDs for better Playwright compatibility (#23630)
- Change add domain button from 'add-entity-button' to 'add-domain'
- Add 'form-heading' test ID to drawer header titles
- Update Playwright domain utilities to use new test IDs
- Update domain spec tests to use correct button test IDs

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Satish <satish@Satishs-MacBook-Pro.local>
Co-authored-by: Claude <noreply@anthropic.com>
2025-09-30 15:10:41 +05:30
Satish
5fd9d357ea feat: add Playwright test compatibility to notistack notifications
- Add data-testid="alert-bar" to snackbar containers using SnackbarProps
- Add data-testid="alert-icon" to notification icons
- Add data-testid="alert-icon-close" to close buttons
- Implement close button functionality for all notification variants
- Update DomainListPage to pass closeSnackbar function
- Ensure compatibility with existing toastNotification test utility

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-09-30 14:27:33 +05:30
Satish
0213e92f65 fix: ensure form resets on cancel and preserves data on error
- Fix form not resetting when drawer is cancelled/closed
- Override closeDrawer in useCompositeDrawer to call onBeforeClose
- Add onCancel callbacks to reset form in all domain/data product drawers
- Prevent form reset on submission errors by rejecting promises
- Ensure form data is preserved when errors occur (e.g., duplicate names)

This ensures proper form state management:
- Forms reset when drawer is closed via X button or Cancel button
- Forms preserve user input when validation or server errors occur
- Users can fix errors and retry without re-entering all data
2025-09-30 13:35:50 +05:30
Dhruv Parmar
98c937ddde
Fix(ui): glossary pagination issue (#23438)
* fixed glossary term pagination issues

* fixed expand all recursive api calls

* removed unused code

* fixed expand all button

* fixed glossary tests

* fixed glossary review issues

* fixed search issue

* fixed playwright failure

* addressed comments
2025-09-30 13:22:12 +05:30
Ashish Gupta
f16b82296e
supported entity column list in contract security form (#23617)
* supported entity column list in contract security form

* supported nested columns
2025-09-30 12:54:10 +05:30
Satish
32145ab9df feat: enhance notification system with MUI styling and customizable messages
- Add MUI-styled snackbar notifications with themed backgrounds and borders
- Create NotificationMessage component with Untitled UI icons and ring effects
- Update notification utilities to accept React.ReactNode for flexible formatting
- Apply Typography with fontWeight: 600 to all domain/subdomain/data product notifications
- Use lightest [25] shade for subtle notification backgrounds
2025-09-30 12:42:09 +05:30
Ushran Gouhar
8a4ee0f239 Merge branch 'main' into domain-revamp 2025-09-30 11:54:30 +05:30
Ushran Gouhar
7394bcf393
Update editor border radius (#23618)
* Update editor border radius

* Update editor border radius to 8px on all side for add domain form
2025-09-30 11:12:04 +05:30
Ashish Gupta
3926595c24
chore(ui): playwright improve contract test to avoid flakiness (#23605)
* chore(ui): playwright improve contract test to avoid flakiness

* fix the contract failing due to persona wait
2025-09-30 10:49:18 +05:30
Ashish Gupta
a852a06166
supported running status in contract execution chart (#23611) 2025-09-30 10:48:57 +05:30
Sriharsha Chintalapani
18677afd39
Add support for Tags customizable rules, capturing feedback (#23289)
* Add support for translations in multi lang

* Add Tag Feedback System

* Update generated TypeScript types

* Fix typing issues and add tests to reocgnizer factory

* Updated `TagResourceTest.assertFieldChange` to fix broken test

This is because change description values had been serialized into strings and for some reason the keys ended up in a different order. So instead of performing String comparison, we do Json comparisons

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Eugenio Doñaque <eugenio.donaque@getcollate.io>
2025-09-30 07:17:18 +02:00
Aniket Katkar
c41a1c9ab5
Chore: Add notify downstream functionality and related tests in the UI. (#23595)
* feat: add notify downstream functionality and related tests in DestinationSelectItem component

* test: enhance tests for DestinationSelectItem and ObservabilityFormTriggerItem components with resource handling
2025-09-30 10:07:38 +05:30
Aniket Katkar
cf62abe256
Add logic to show the platform info banner even in case of status=200 and the API response contains reason in case of Hybrid platform. (#23614) 2025-09-30 08:07:15 +05:30
Sriharsha Chintalapani
bb1395fc72
Implement Modern Fluent API Pattern for OpenMetadata Java Client (#23239)
* Implement Modern Fluent API Pattern for OpenMetadata Java Client

* Add Lineage, Bulk, Search static methods

* Add all API support for Java & Python SDKs

* Add Python SDKs and mock tests

* Add Fluent APIs for sdks

* Add Fluent APIs for sdks

* Add Fluent APIs for sdks, support async import/export

* Remove unnecessary scripts

* fix py checkstyle

* fix tests with new plural form sdks

* Fix tests

* remove examples from python sdk

* remove examples from python sdk

* Fix type check

* Fix pyformat check

* Fix pyformat check

* fix python integration tests

* fix pycheck and pytests

* fix search api pycheck

* fix pycheck

* fix pycheck

* fix pycheck

* Fix test_sdk_integration

* Improvements to SDK

* Remove SDK coverage for Python 3.9

* Remove SDK coverage for Python 3.9

* Remove SDK coverage for Python 3.9
2025-09-29 16:07:02 -07:00
karanh37
77794b5c79 fix permission test 2025-09-29 20:30:20 +05:30
Karan Hotchandani
4a51bbcdf3
Merge branch 'main' into domain-revamp 2025-09-29 19:49:53 +05:30
Ushran Gouhar
9b80e92f6c
Change editor toolbar background color to white for add domain form (#23587) 2025-09-29 19:49:11 +05:30
Keshav Mohta
4528c0c1c4
Fixes #23416: Option To Opt Out of BigQuery Policy Tags Ingestion (#23532)
* fix: added includePolicyTags flag

* feat: added includePolicyTags
2025-09-29 18:24:10 +05:30
satish
8f1e8b47b7
feat: Replace Ant Design toast notifications with MUI notistack (#23608)
- Added notistack dependency to UI packages
- Created NotistackUtils.ts with notification helper functions (error, success, info, warning)
- Created SnackbarContent styled component in ui-core-components package
- Configured SnackbarProvider in App.tsx with custom styled content
- Migrated domain, data product, and sub-domain components to use notistack
- Error notifications display at top-center position
- Success notifications maintain top-right position (default)
- Removed unused MuiSnackbarContent theme override

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Satish <satish@Satishs-MacBook-Pro.local>
Co-authored-by: Claude <noreply@anthropic.com>
2025-09-29 17:24:43 +05:30
Ushran Gouhar
265cb31ba2
Add tooltip for icon (#23588) 2025-09-29 16:01:30 +05:30
karanh37
35092f5d03 fix playwrights 2025-09-29 15:58:16 +05:30
Satish
192ccb6cf1 fix: remove hardcoded SubDomain conditional logic from EntityAvatar
- Remove special case handling for SubDomain icons
- Remove unused SubDomainIcon import
- Let getDefaultIconForEntityType handle all entity types uniformly
- Ensures consistent icon selection across all entity types

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>
2025-09-29 14:43:47 +05:30
satish
f891d09724
feat: add dynamic permission checks for create buttons in listing pages (#23610)
- Update DomainListPage to dynamically check domain.Create permission
- Update DataProductListPage to dynamically check dataProduct.Create permission
- Replace hardcoded createPermission: true with actual permission checks
- Import and use usePermissionProvider hook for both components

🤖 Generated with Claude Code

Co-authored-by: Satish <satish@Satishs-MacBook-Pro.local>
Co-authored-by: Claude <noreply@anthropic.com>
2025-09-29 14:39:04 +05:30
satish
7ffb6df57a
feat: Create reusable EntityAvatar component for consistent icon rendering (#23609)
- Created EntityAvatar component to centralize entity icon rendering logic
- Updated domain and data product detail pages to use EntityAvatar
- Updated useCellRenderer to use EntityAvatar for listing pages
- Supports custom icons via style.iconURL and custom colors via style.color
- Handles URL-based icons, icon names from ICON_MAP, and default icons

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Satish <satish@Satishs-MacBook-Pro.local>
Co-authored-by: Claude <noreply@anthropic.com>
2025-09-29 14:36:00 +05:30
Ushran Gouhar
2b80a885a0
Change helper text background and foreground colors for Domain type (#23594) 2025-09-29 13:49:28 +05:30
Karan Hotchandani
7b698f6a07
Merge branch 'main' into domain-revamp 2025-09-29 11:34:38 +05:30
karanh37
3816eb09f0 fix playwrights 2025-09-29 11:32:29 +05:30
Ashish Gupta
77cfe7849b
Modify ContractExecutionChart to occupy full space and chart bar's start from left (#23602)
* modify contract execution chart to occupy full space

* remove unwanted css

* move the chart bar's to be aligned in left hand side
2025-09-29 11:00:02 +05:30
Ajith Prasad
ed71f3629a
Field level validation in SSO configuration (#23562)
* Field level validation in SSO configuration

* Update generated TypeScript types

* Ldap field error response

* add form field level error validations

* field level error highlight style fix

* fix array field level error highlight issue

* minor style fix for array fields

* resolve merge conflict

* error highlight for text area fields

* fix test

* Fixed tests and improvement

* added unit test

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: shrushti2000 <shrushtipolekar@gmail.com>
2025-09-29 10:54:51 +05:30
Aniket Katkar
acc79aab1e
Chore(UI): Drive service bug fixes and unit tests (#23554)
* feat: Add file type, extension, and version fields to file details

- Updated  in  to include , , and .
- Introduced new test file  to cover the functionality of the .
- Enhanced  to export the  class for testing purposes.
- Created  to implement tests for the  functionality.
- Updated  to include  in the default fields for worksheets.

* feat: Add default filter patterns for directories, files, spreadsheets, and worksheets in Drive service

* fix: Add margin to advanced properties collapse for better spacing

* Update generated TypeScript types

* Add tests for new pages
refactor: Move interface definitions for detail page tabs to their respective utils files to fix circular dependency
Add unit tests for SpreadsheetDetailsUtils and WorksheetDetailsUtils

- Created SpreadsheetDetailsUtils.test.tsx to test the functionality of the SpreadsheetDetailsUtils module, including tab rendering and widget retrieval.
- Created WorksheetDetailsUtils.test.tsx to test the functionality of the WorksheetDetailsUtils module, covering tab rendering and widget handling.
- Implemented various test cases to ensure correct behavior for different scenarios, including edge cases for both modules.
- Mocked necessary components and utilities to isolate tests and ensure reliable results.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-09-29 09:42:16 +05:30
Ashish Gupta
ab11983741
support not_contains in contract semantic form (#23485) 2025-09-28 00:06:03 +02:00
Shrushti Polekar
134ab5d538
fix(ui): SSO feedbacks and improvements (#23553)
* fix dropdown issue

* update breadcrumb icon

* address styling feedbacks

* fix error taost  content panel resize issue

* update doc stylings

* minor style updates

* update doc stylings

* refactor code to avoid global style

* update delete scim modal

* minor style fix

* minor fix

* fix select dropdown styles

* refactor code to remove !important

* improve login experience

* Update generated TypeScript types

* fix unit test

* update scroll behaviour

* remove eslint issues

* remove old icons

* address pr comment

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-09-27 21:19:21 +05:30
Harshit Shah
78c613445b
fix(ui): Typo in landing page and flaky tests (#23601) 2025-09-27 07:46:09 -07:00
Ashish Gupta
40eaae13e7
minor improvement around contract security initial data pick (#23600) 2025-09-27 16:04:38 +05:30
karanh37
73ea261451 fix tests 2025-09-27 15:21:05 +05:30
karanh37
8cd8725c35 fix tests 2025-09-27 14:19:16 +05:30