5356 Commits

Author SHA1 Message Date
Ashish Gupta
6688cf2dc0
fix the contract description being cut (#23598) 2025-09-27 12:48:18 +05:30
Ashish Gupta
46c49a959d
updated contract security form details (#23591)
* updated contract security form details

* modify the security form as per semantic styling

* modify unit test as per form change

* change the place of add-row-filter

* render the description component conditionally and increase the chart fetch limit and and increase the execution number in limited width

* fix the sonar test
2025-09-27 11:21:41 +05:30
Ashish Gupta
b38890cfa4
chore(ui): Fix Data Contract contains flaky test and updated Terms of Service icon (#23570)
* chore(ui): Fix Data Contract contains flaky test

* updated the terms of service tab icon and increase some panel width
2025-09-27 00:16:17 +05:30
Aniket Katkar
1506c29387
Revert "Fix(ui): Force Test Connection (#21734)"\n\nThis reverts commit b1a1cd89a743b321b2726e5c85f66408c8687dc8. (#23567) 2025-09-26 22:12:38 +05:30
Ashish Gupta
dc474e44f6
supported created_by and created_at info to display in UI of DataContract (#23531)
* supported created by and at info of data contract

* re-order sla select unit options

* added unit test for sla component and fix data visibility
2025-09-26 21:16:22 +05:30
Karan Hotchandani
3b55bff46b
Merge branch 'main' into domain-revamp 2025-09-26 20:34:45 +05:30
karanh37
6f0e33dcf7 fix tests 2025-09-26 20:31:39 +05:30
Aniket Katkar
063e37a8d8
fix: improve timestamp sorting logic in IngestionRecentRuns component (#23572) 2025-09-26 20:31:30 +05:30
Ashish Gupta
f934b79d65
supported scroll in certification popover list (#23534) 2025-09-26 20:17:19 +05:30
Ashish Gupta
bcae472cc0
improve playwright test of bulk import/edit (#23538) 2025-09-26 20:17:09 +05:30
sonika-shah
d8a3e5f5ed
UI: Handle deleted flag in /aggregate API to restore dropdown search results (#23558)
* add searchSettings aggregation in searchSettings.json

* refactor: update ExploreQuickFilters and ExploreUtils to include showDeleted and deleted parameters

* feat: enhance ExploreDiscovery tests to handle deleted assets visibility based on showDeleted toggle

* Revert schemaChanges.sql files to match main

---------

Co-authored-by: Aniket Katkar <aniketkatkar97@gmail.com>
2025-09-26 18:17:56 +05:30
karanh37
56a44c5463 minor fixes 2025-09-26 16:14:52 +05:30
Sriharsha Chintalapani
aa7715be0d
Fix #23445: User with Owner role unable to update Incident Status via API (#23448)
* Fix #23445: User with Owner role unable to update Incident Status via API

* fix: failing build

* fix: permission on test case incidents

* playwright: added e2e test for issue #23445 (#23459)

* fix: entitylink parsing for entity resource

* fix: restore severity state in PATCH test

---------

Co-authored-by: Teddy Crepineau <teddy.crepineau@gmail.com>
Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
2025-09-26 15:11:36 +05:30
Chirag Madlani
6e9c0316e5
test(e2e): skip lineage failing tests (#23577) 2025-09-26 15:11:27 +05:30
karanh37
fe11aa22d1 persist filters in url and selection 2025-09-26 13:59:03 +05:30
Ushran Gouhar
7c71be1d07 Revert "Change background color Editor toolbar to white"
This reverts commit a0bdc2231ab0d40a47ef91bd425deb2fb1d2dc87.
2025-09-26 13:06:00 +05:30
karanh37
80e3e70dab show filter selections 2025-09-26 12:44:22 +05:30
Ushran Gouhar
c58c008f21 Fix no data available for glossary tags 2025-09-26 11:41:10 +05:30
Shrushti Polekar
cc265f956b
fix profiler view permission aut failure (#23574) 2025-09-26 10:01:48 +05:30
Ushran Gouhar
a0bdc2231a Change background color Editor toolbar to white 2025-09-25 23:21:51 +05:30
karanh37
039163b7f0 retain filters in url 2025-09-25 22:11:00 +05:30
Pranita Fulsundar
6448f22dbf
fix search preview test (#23555) 2025-09-25 20:40:41 +05:30
Ashish Gupta
e9333fd439
chore(ui): fix ingestion bot playwright timeout issue (#23547) 2025-09-25 20:36:09 +05:30
Ushran Gouhar
ced16b2dd1 Change width of form from 750px to 670px for subdomain and data product 2025-09-25 20:20:58 +05:30
Ushran Gouhar
bc311fb42b Fix search functionality for icons 2025-09-25 19:27:13 +05:30
Keshav Mohta
e77b4d6faf
docs: added drive metadata doc & custom drive doc (#23552) 2025-09-25 15:36:38 +05:30
Ushran Gouhar
9995d1ee22 Add icons 2025-09-25 14:28:42 +05:30
karanh37
202c644acc add explore filter 2025-09-25 12:35:18 +05:30
karanh37
2381de0722 Revert "Reset form on submit and cancel"
This reverts commit e2a19cfd1005d0d967530931287c0a125595eef7.
2025-09-25 11:40:35 +05:30
Sweta Agarwalla
8eaf4f585d
fix(test): flaky tests (#23212)
* fixed fkaky tests

* fix APIs
2025-09-25 10:51:39 +05:30
Ashish Gupta
68f496a2df
chore(ui): fix lineage cycle playwright test (#23545) 2025-09-25 10:47:01 +05:30
Karan Hotchandani
91067467a7
paginate for find search index app (#23540) 2025-09-25 10:38:11 +05:30
Ashish Gupta
7334f529e8
fix the tags playwright test (#23544) 2025-09-25 10:35:28 +05:30
Ushran Gouhar
e2a19cfd10 Reset form on submit and cancel 2025-09-24 22:47:35 +05:30
Ram Narayan Balaji
532f3e5e4e
Undo entity status migration, show entityStatus by default (#23511)
* Revert Entity Status Migrations as we already have the default value

* Batch Migrations and by default show entityStatus field in the response

* Setting default value of enum in the status.json and fixing test cases for new default enum UNPROCESSED

* Update generated TypeScript types

* DataContract by default has Unprocessed status, Overriden method in the GlossaryTermRepository

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-09-24 18:38:03 +05:30
Ushran Gouhar
7d779df790 Clear the form on submit 2025-09-24 14:27:24 +05:30
Aniket Katkar
c6c9eb26e2
Feat: Add drive service (#23018)
* Add the drive service settings option

* Fix the ci error

* Add Directory Details page

* Add Explore page support for new drive assets

* Add Directory Children table

* Update page.json

* Add File details page

* Add spreadsheet details page

* Add Worksheet details page

* Update explore tree name

* Fix the search suggestions not showing for new assets

* Add new assets in missing setting options

* Update service util class base for drive service

* Add version support for directory

* Add version pages for File, Spreadsheet and Worksheet

* Add FQN for worksheet columns

* Add columns table for the worksheet

* Fix the Spreadsheet, Directory and Worksheet version pages not showing children.

* Fix the domain not updating for drive assets

* Fix announcement not working for drive assets

* Add playwright for Directory asset

* Fix the index mappings and failing playwright test for directory

* Add google drive service icon

* Fix the delete and restore functionality for drive assets

* Fix patch tags for worksheet and add tests

* Fix failures

* search indices

* Update service details page for drive service

* Add playwright tests for remaining drive assets

* Fix listing APIs to return when root=true mentioned

* Update API to fetch drive service assets and fix playwright for Worksheet service

* Fix the index mappings

* Add the new fields for advanced search

* Add the playwright tests for drive assets

* fix: drive service test connection

* fix: drive service test connection

* Fix the ServiceDetailsPage tests

* Fix the playwright tests

* Fix the search settings issue for drive assets

* add missing icons, fix search index issue for worksheet, resolve the sonar issues

* Fix the entity permission spec

* Fix FileResourceTest to create GoogleDrive instead of SharePoint to match the type creation in the test

* Work on comments

---------

Co-authored-by: Sriharsha Chintalapani <harsha@getcollate.io>
Co-authored-by: Keshav Mohta <keshavmohta09@gmail.com>
Co-authored-by: Ram Narayan Balaji <ramnarayanb3005@gmail.com>
2025-09-24 13:37:31 +05:30
Ushran Gouhar
ceebabc4cc Add placeholders for owners and experts fields 2025-09-24 13:09:36 +05:30
Chirag Madlani
8deab28071
feat(ui): support impact analysis for lineage (#23231)
* feat(ui): support impact analysis for lineage

* WIP filters

* Add Node Depth and fix downstream and upstream counts

* integrate search / quick filters with api

* fix api calls

* Fix Listing and remove unnecessary call for root entity

* Fix OS

* support column level lineage for impact analysis

* update

* Add Pagination Apis and Node Depth apis

* Fix Looping infinitely

* Add Validation

* Reduce Response size for lineage

* Add node depth upto

* Add Edge Information

* incorporate new apis

* push queryFilter to fetchNodes

* query_filter -> queryFilter

* add export for impact analysis

* update pagination

* fix query_filter param

* Fix issue on upstream lineage result due to filters

* Fix Filters issue

* Update generated TypeScript types

* update unit tests

* fix tests

* address comments

* support impact analysis for all the tabs

* update icon for column customization

* Fix breaking tests

* update test

* update translation

* Fix Wrong Match for UPSTREAM

* clean console

---------

Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
Co-authored-by: Mohit Yadav <105265192+mohityadav766@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2025-09-24 12:53:20 +05:30
Ushran Gouhar
ed558cd371 Remove entity description in row 2025-09-24 11:01:09 +05:30
Sriharsha Chintalapani
e77d1940cb
Domain policy must be evaluated during PolicyEvaluator (#23302)
* Domain Only Access Role to be evaluated as part of PolicyEvaluator

* Domain Only Access Role to be evaluated as part of PolicyEvaluator

* Cleanup unnecessary comments

* Add migration fix for domain only policy

* fix playwright domain rbac

* fix hasDomain role issues for TestCaseResourceContext

* allow user to create only with their domain

* move DomainOnlyAccessPolicy migrations to 1.9.10 from 1.9.9

* For resources that don't support domains (like DataInsights), always returns true

* fix adding test case to bundleSuite

* revert supportsDomains changes in RuleEvaluator and handle it in postFiltering steps

* Inherit domains when creating task from test case incident, and skip few entities for domain check + other remaining DQ related domain fixes

* for CreateResourceContext consider assigned domains + inherited domains

* fix permission for table metrics page

* remove SKIP_DOMAIN_CHECK_ENTITY_LIST

* fix test

---------

Co-authored-by: sonika-shah <58761340+sonika-shah@users.noreply.github.com>
Co-authored-by: sonikashah <sonikashah94@gmail.com>
Co-authored-by: Ayush Shah <ayush@getcollate.io>
2025-09-24 09:56:55 +05:30
Ashish Gupta
11226b2b3f
MINOR: fix the add team error placeholder using wrong permission (#23522)
* fix the team error placeholder using wrong permission

* remvoe the unwanted file
2025-09-24 00:41:55 +05:30
Ashish Gupta
1d4aff0154
fix the redirect path of mention knowledge article and breadcrumb (#23519)
* fix the redirect path of mention knowledge article and breadcrumb

* added data-test id here
2025-09-23 23:41:58 +05:30
Mayur Singal
933802a354
MINOR: Support metabase API Key Auth (#23436) 2025-09-23 22:01:10 +05:30
Keshav Mohta
cb26c91442
Revert "Fixes #23356: Databricks OAuth & Azure AD Auth (#23482)" (#23530)
This reverts commit f1afe8f5f114ee58090168fd7ae5d66b38a01ab0.
2025-09-23 17:44:16 +02:00
Keshav Mohta
f1afe8f5f1
Fixes #23356: Databricks OAuth & Azure AD Auth (#23482)
* feat: databricks oauth and azure ad auth setup

* refactor: add auth type changes in databricks.md

* fix: test after oauth changes

* refactor: unity catalog connection to databricks connection code
2025-09-23 15:22:50 +05:30
Ram Narayan Balaji
3771149fb5
Feat: Add color and iconURL in import and export for glossary (#23477)
* Add color and iconURL in import and export for glossary

* fix tests

* add color and icon url in playwright

---------

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
2025-09-23 14:32:53 +05:30
Shailesh Parmar
38eeb262a0
update playwright config setting to keep tracing on failure (#23517) 2025-09-23 14:30:46 +05:30
satish
1a3339453b Domain, Sub-domain, Data Product listing (#23374)
* Domain, Sub-domain, Data Product listing

* feat: implement atomic design architecture with micro hooks for entity listings

This commit introduces a comprehensive atomic design system that eliminates code duplication while providing maximum flexibility through composable micro hooks.

## Key Features

### Atomic Design Structure
- Created `src/components/common/atoms/` with feature-based organization
- Implemented micro hooks (5-15 lines each) with single responsibilities
- Added comprehensive JSDoc documentation for each micro hook

### Entity Listing Improvements
- Refactored domain, subdomain, and data product listings
- Simplified entity-specific hooks using shared domain atoms
- Implemented flexible `useDataTable({ listing })` interface

### Performance & Stability
- Fixed infinite API calls and re-render loops
- Implemented proper useCallback/useMemo patterns with stable dependencies
- Added error boundaries and proper error handling

### UX Improvements
- Fixed search to trigger on Enter key (eliminated race conditions)
- Updated sidebar navigation to use singular forms for sub-menu items
- Fixed navigation paths for data product details
- Added proper translation keys and removed hardcoded strings

### Bug Fixes
- Fixed filter field mappings to use `.keyword` for exact matching
- Fixed data product navigation paths (`/dataProduct` vs `/data-product`)
- Fixed filter styling to use original SearchDropdown components
- Temporarily disabled problematic domainType filter due to API errors

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(ui): add i18n support and enhance atomic hooks for entity listings

- Add useDelete hook with proper i18n for entity deletion with confirmation modal
- Add useCardView hook for flexible card layout rendering
- Add useViewToggle hook for table/card view switching
- Add useDomainCardTemplates for domain and data product card layouts
- Add TagsCell component for rendering glossary and classification tags
- Refactor useTableRow to use composition with useCellRenderer
- Fix i18n translations for delete confirmation messages
- Update Domain, DataProduct, and SubDomains pages to use new atomic hooks
- Add missing translation keys to en-us.json

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat(ui): implement MUI-based tree select components and atomic design patterns

- Add MUIAsyncTreeSelect component with lazy loading and keyboard navigation
- Implement MUIGlossaryTagSuggestion for hierarchical glossary term selection
- Add MUITagSuggestion for improved tag selection experience
- Create reusable TagChip component for consistent tag display
- Implement atomic drawer hooks for form handling
- Update domain and data product listing pages with new components
- Add comprehensive tree selection hooks (data, expansion, selection, search)
- Enhance form utilities with MUI field types

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat(ui): enhance drawer styling and add MUI form components

- Add gradient background image to drawer header with 30% opacity
- Apply rounded top corners (16px) to drawer for modern appearance
- Add box shadow to drawer footer for visual hierarchy
- Introduce MUIFormItemLabel component for consistent form labels
- Fix TypeScript any type warning in AddDomainForm
- Enhance domain listing pages with improved drawer integration

🤖 Generated with Claude Code

Co-Authored-By: Claude <noreply@anthropic.com>

* feat(ui): implement MUI-based user/team selection component with atomic design

- Add MUIUserTeamSelect component with atomic design patterns
- Create ProfilePicture atomic component for consistent avatar rendering
- Update AddDomainForm to use new MUI components instead of legacy selectors
- Enhance useCellRenderer to use ProfilePicture for owner display
- Add support for user-only, team-only, and mixed selection modes
- Implement smart selection logic preventing user/team conflicts
- Add internationalization support for new selection component

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat(ui): add MUI domain select component and fix drawer close functionality

- Implement MUIDomainSelect component using MUIAsyncTreeSelect for hierarchical domain selection
- Fix drawer close/cancel button functionality with proper onBeforeClose pattern
- Standardize form submission patterns across domain and data product forms
- Enhance MUIAsyncTreeSelect with keyboard navigation and scroll-to-view
- Clean EntityReference objects to match API schema requirements
- Remove duplicate onSubmit handlers in drawer forms

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat(ui): implement MUI-based color and icon picker components for domain forms

- Add MUIColorPicker component with predefined color palette and accessibility features
- Add MUIIconPicker component with icon selection and URL input capabilities
- Update AddDomainForm to use new MUI components with improved layout and responsive design
- Create IconUtils for centralized icon rendering functionality
- Update cell renderer to handle icons properly with fallback support
- Enhance form styling with backdrop blur adjustments and form label theming
- Add missing translation keys for icon-plural and url labels
- Standardize drawer widths across domain and data product forms

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Satish <satish@Satishs-MacBook-Pro.local>
Co-authored-by: Claude <noreply@anthropic.com>
2025-09-23 13:40:10 +05:30
Shrushti Polekar
eebd3bb661
Feat(ui): SSO configuration from UI and Scim bot token generate revoke functionality and Group Mapping in settings page (#21839)
* added scim bot generate revoke token functionality on settings page

* update global setting constant

* minor code refactor

* WIP: SSO Configuration from UI

* Update generated TypeScript types

* Copilot suggestions addressed

* Test Endpoint added

* Added update security configuration test

* added sso configuration rjsf form

* minor  fixes

* Update generated TypeScript types

* update scim component

* Fix Merge Conflicts

* Remove extra comma

* update sso form for oidc client providers

* SAML configuration fixes

* Update generated TypeScript types

* Update generated TypeScript types

* add support for selective schema generation by file name

* fix acces token card issue and array fields ui issue

* Saml registration fix

* Scim configuration saved

* refactor code

* scim config issues fixed

* fix enableSelfSignup

* scim enabling from settings

* Test validation enpoint changes

* fix ldap issues

* minor refactor

* minor updates

* update settings call for scim

* update bot details in scim card

* minor style fixes

* Adding enhanced validators

* update confidential client configurations

* Auth0 validator

* update jwt for saml

* Saml validator changes

* Okta validator fix

* fix saml certificate formatting and select widgets

* remove client type from ui for ldap and saml

* Okta validation rectified

* Google validator improved

* update select component

* fix error messages

* added unit test

* Azure validator rectified

* Validation issues solved for auth0

* add oidc prefix for oidc client fields

* fix type issues

* style fixes for scim token card

* Update cognito validator

* refactor file names

* added e2e tests

* minor fixes

* added content for docs in md files

* implement  new design

* form style updates

* fix doc styles and provider selection styles

* fix provider selection style

* update local file

* group client fields together

* added provider name

* overview tab changes

* update form styles for configure tab

* update toggle styles

* update breadcrumb texts and provider name in text

* minor fix in localization

* minor fix for basic provider

* update breadcrumb styles and minor local file update

* minor fixes

* minor fix for local file

* fix styles for configured form

* minor fixes in styles

* fix redirect issue of my-data for non oidc sso

* fix build issue and refactor code

* update saml and ldap icons

* minor updates in icon

* typo fix

* breadcrumb and style fixes

* fix test

* update patch call

* minor fixes for access token card and code refactor

* refactor code to remove unused files

* added ldap and custom oidc doc content

* fix overview tab issue for scim and enable sso

* Patch issue fixed for authentication Configuration

* Implement unified authentication endpoints across all providers

* Memory leak issue solved

* Mcp md file

* apply spotless

* Added complete flow test for oidc

* refactor css files

* minor style updates

* cancel form functionality

* update placeholders

* update cancel modal

* minor update for saving existing config

* fix minor css issue

* integrate unified api

* remove clientid and callbackurl for confidential client type and added  jwtPrincipalClaimsMapping

* fix breadcrumb issue

* refactor files and folder structure

* minor fix

* refactor code and add disable fields styles and cancel btn functionality for existing sso

* added localization file changes

* Patch operation issue fixed

* Update generated TypeScript types

* update patch call

* patch call update for enable self signup

* remove enable selfsignup from then form since its present in the toggle

* added enable self signup field for non existing sso form

* minor code revert for enabling fields

* Update generated TypeScript types

* Redirect uri, password encoding fixes for basic and ldap

* refactor code and encode password and added /auth/callback in redirecturl

* minor  fixes

* added group mapping

* cancel modal save btn fix and logout fix

* minor fix for save btn functionality for cancel modal

* minor update in localization file

* address pr comments for ssoconfigform and css file names

* address pr comments for sso doc panel

* address pr comments around provider selector

* fix breadcrumb

* update localization file and remove unwanted files

* address pr comments related to basic auth provider

* extracted proxy code into separate func and added dev mode check

* remove unnecessary validate call happening during patch calls

* address pr comment related to tab

* update sso icon

* minor fix

* address parseSchema related pr comment

* address pr comment related to config fields constants

* added default value for callback url

* added default value for response type and clientAuthenticationMethod

* minor fix for callback url

* minor style fix

* Changed response to json for basic and ldap login

* revert unified api changes done for basic login

* made admin principal as required

* fix playwright for llogin test failure

* fix failing unit test

* fix login e2e test

* refresh call

* fix failing unit test

* fix unit test

* fix test

* remove setRefreshToken

* added default values for google

* minor style fixes

* minor text update

* Google credential validation, scope validation

* Discovery uri validation added with Auth0

* Discovery uri check added for okta

* minor style fixes

* minor checkbox fix

* minor required field fix

* minro fix

* AWS cognito validator

* google api depdendency added

* Update generated TypeScript types

* minor fixes

* minor fix for array fields cursor style issue

* Modified saml validator

* Admin principal respected while logging in

* Added tests for validators

* callback url update

* custom oidc validator

* added default values for saml

* custom oidc fix

* Saml validator issue solved

* Custom oidc publickeyurl validation

* validation for prompt

* test fix

* fix test

* TC fixed

* mvn spotless apply

* Addressed review comments

* Static method issue in Security COnfiguration manager fixed

---------

Co-authored-by: aji-aju <ajithprasad770@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mohit Yadav <105265192+mohityadav766@users.noreply.github.com>
Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Co-authored-by: Ajith Prasad <37380177+aji-aju@users.noreply.github.com>
2025-09-23 13:23:46 +05:30