271 Commits

Author SHA1 Message Date
Pere Miquel Brull
e56f477a4a
Fix #19147 - Executable Test Suites (#19221)
* backend

* format & tests

* rename backend

* migrations and ingestion

* format & tests

* format & tests

* tests

* format & tests

* tests

* updated ui side of changes

* addressing comment

* fixed failing unit test

* fix test list

* added e2e test, and fixed existing test

---------

Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
2025-01-07 17:59:54 +01:00
Sweta Agarwalla
0a1ab95f8b
Add utils for login as admin (#19223)
* add utils for login as admin

* update as per comments

* fix java checkstyle issue

---------

Co-authored-by: Shailesh Parmar <shailesh.parmar.webdev@gmail.com>
2025-01-06 13:58:13 +05:30
Ashish Gupta
9edc078027
MINOR: modify and fix some lineage issues (#19107)
* modify and fix some lineage issues

* minor fix

* restrict the node removal in case any error occured

* fix flaky playwright test

* userDetail flaky fix
2025-01-03 10:35:26 +05:30
Chirag Madlani
cdef12c9cd
feat(ui): show count with schema tab for table details page (#19149)
* feat(ui): show count with schema tab for table details page

* fix active state for tab

* fix tests and cover topic details page

* add missing isActive check
2025-01-03 10:19:16 +05:30
Ashish Gupta
87c07f3ecc
#16465 : supported glossary table column resizable (#17918)
* supported glossary table column resizable

* code cleanup

* fix the column resizing affecting other column width

* fix the playwright failure around the glossary due to re-sizable added
2025-01-03 10:09:33 +05:30
Ashish Gupta
ceeba2ad75
fix tag page flaky playwright test (#19150)
* fix tag page flaky playwright failures

* removed commented code
2024-12-31 17:12:15 +05:30
Sachin Chaurasiya
4f3ae5d083
feat(#15380): replace description editor with block editor (#19003)
* feat(#15380): replace the description editor with a new block editor.

* chore: Add placeholder support to BlockEditor

* feat: Add autofocus support to BlockEditor

* chore: implement block editor in richtext editor

* chore: Remove unused CSS import in RichTextEditor

* fix: ensure safe access to getEditorContent in Markdown editor components

* minor change

* fix: add support for ttf file extension in pom.xml

* fix: adjust block editor styles for better usability and overflow handling

* fix: update RichTextEditorPreviewer to RichTextEditorPreviewerV1 and adjust block editor styles

* fix: update description box selector to use om-block-editor for consistency

* fix: disable autoFocus on BlockEditor in RichTextEditorPreviewerV1

* refactor: update RichTextEditorPreviewer references to RichTextEditorPreviewerV1 in tests

* test: update timer handling in ApplicationCard and SuggestionsAlert tests

* fix(diff): update diff view rendering and attributes for consistency

* fix(RichTextEditor): add placeholder for empty markdown descriptions

* Add data-diff in <span>

* Fix test

* fix: update description box selector to use locator method for better reliability

* feat: integrate RichTextEditorPreviewerV1 for description rendering in Notification and Observability Alerts pages

* feat: add markdown conversion for mentions and hashtags in BlockEditorUtils

* fix: update initial value handling in TagsForm and formUtils

* MINOR - Update description handling in Playwright tests and utilities

* Refactor Playwright tests to use descriptionBox for tag and team descriptions

* Refactor custom property handling and update description check logic

* Enhance entity version page tests by adding description box read-only check and updating data-testid attributes

* Refactor description handling and improve diff rendering logic in task pages

* Fix user description clearing logic in UserDetails.spec.ts

* Enhance Rich Text Editor by adding custom styles and converting markdown to HTML for backward compatibility

* Remove test for rendering alert description when not present in AlertDetailsPage

* Clean up RichTextEditorPreviewerV1 by removing unnecessary comments and improving readability

* Update SearchIndexApplication.spec.ts to select 'Table' instead of 'Topic' in the tree widget

* Refactor BlockEditor and FeedUtils to improve code organization and readability

* Fix regex in getTextFromHtmlString to correctly remove HTML tags

* Add tests for getTextFromHtmlString and improve HTML tag removal regex

---------

Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
2024-12-27 20:57:37 +05:30
Shailesh Parmar
f87b0662fa
playwright: reset the profiler bot token in AUT (#19156)
* playwright: reset the profiler bot token in AUT

* addressing comment
2024-12-20 20:19:11 +05:30
Karan Hotchandani
9a76b07025
Fix flaky e2e tests (#19038)
* fix lineage flaky tests

* fix glossary flakiness
2024-12-19 23:05:55 +05:30
Ashish Gupta
7d962d91eb
fix table page breaking due to highligther text (#19146) 2024-12-19 22:45:45 +05:30
Chirag Madlani
4d30c83c55
fix(ui): sync search value with url and state value (#19050)
* fix(ui): sync search value with url and state value

* fix flaky for user spec
2024-12-16 21:02:16 +05:30
Pranita Fulsundar
57e814c15d
test(e2e): Explore page tests (#19074)
* test: add e2e tests

* test for listing of entities when index is dataAsset and all

* fix: validateBucketsForIndex function

* fix: add expect to bucket and its doc_count
2024-12-16 15:47:35 +05:30
Chirag Madlani
605d205f8b
test(e2e): Ingestion bot e2e tests (#19055)
* test(e2e): domain ingestion tests
support for ingestionBot login in playwright

* added tests

* add ingestion bot tests

* update bot tests

* revert unwanted changes

* comment skipped test

* check for service within domain
2024-12-16 15:41:36 +05:30
Ashish Gupta
9e6078f654
supported editUser permission in user tab for team page (#18987)
* supported editUser permission in user tab for team page

* remove edit all permission check in teams add/remove user api

* added playwright test for the editUser permission

* Added playwright test for data consumer user and remove no used field from the advance api call

---------

Co-authored-by: sonikashah <sonikashah94@gmail.com>
Co-authored-by: sonika-shah <58761340+sonika-shah@users.noreply.github.com>
2024-12-13 23:41:40 +05:30
Sweta Agarwalla
ae046c502d
Update auth test (#19031) 2024-12-13 09:41:09 +05:30
Aniket Katkar
4f9627d860
Fix the flaky Tag.spec.ts test (#18984) 2024-12-11 19:56:42 +05:30
Mohit Yadav
08cdc69f30
Fix ES Tag Index failing (#18991)
* Fix ES Tag Index failing

* add tags loading test

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
2024-12-10 21:10:58 +05:30
Mohit Yadav
5263858067
Create Change Events on import and update in es (#18953)
* Create Change Events on import and update in es

* add glossary tests

* minor test cleanup

* Make Change Event Update Async

* Fix Test case

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
Co-authored-by: Sriharsha Chintalapani <harshach@users.noreply.github.com>
2024-12-09 07:45:33 -08:00
Shailesh Parmar
7d7bc5b48b
playwright: fixed aut failure in playwright (#18958)
* playwright: fixed aut failure in playwright

* Temporarily increased the timeout for lineage tests which timeout often

* Fix the flaky tests

* removing linage changes

---------

Co-authored-by: Aniket Katkar <aniketkatkar97@gmail.com>
2024-12-09 18:03:13 +05:30
Sweta Agarwalla
5e525153a5
Fix: Minor glossary term issues (#18937)
* fix minor issues

* add test for glossary term

* add reviewer test

* fix glossary term test
2024-12-06 11:59:23 +05:30
Aniket Katkar
f6b4434e4a
Improvements: Playwright tests (#18849)
* Resolve all the type errors in playwright code

* Fix the playwright tests

* Improve the ingestion test connection logic and autoClassification

* Fix flaky tests

* SearchIndexApplication fix

* Fix the flaky tests

* flaky test fixes and trace on for debugging

* Fix the flaky tests

* update the trace config for data insights setup

* Fix flaky tests

* Fix the flaky tests
2024-12-05 17:53:14 +05:30
Ashish Gupta
00e5d299b9
Support to add and edit primary constraints in Table Constraints modal (#18905)
* suuport to add and edit primary constraints in Table Constraints modal

* added icon in the constraint tab and made primary form similar like foreign one

* added primary tableConstraints in tableClass

* minor fix around the name

* supported type in dropdwon based on Constraint Types

* fix sonar issue

* added playwright test

* added check around the removal of existing constraint and checking the pending one

* fix the sonar issue and single constraints icon not showing

* fix the scroll issue on TableConstrants in right panel while resizing

* fix playwright test
2024-12-05 12:24:50 +05:30
IceS2
46d4e1c77c
MINOR: Fix Glossary Term Consolidation and Flaky Test (#18920)
* Fix Glossary Term Consolidation and Flaky Test

* Fix CheckStyle

* Implement the new entitySpecificUpdate in all repositories
2024-12-05 09:32:50 +05:30
Karan Hotchandani
fe661a2f49
Change lineage positioning algorithm (#18897)
* use elk algorithm to position nodes

* change positioning

* fix spacing

* do not reset zoom value

* minor pw fix

* force click on lineage edge
2024-12-04 21:27:43 +05:30
Shailesh Parmar
dbd9311a2c
GEN-2186: Fix Updating sampling config from deep link issue (#18916) 2024-12-04 18:15:11 +05:30
Pranita Fulsundar
5b72cbc2f0
Fix: show full fqn for reference tables (#18858)
* fix: show full fqn for reference table

* refactor: getEntityLabel function and fix e2e test
2024-12-04 11:20:53 +05:30
Sachin Chaurasiya
811feea515
Minor: improve custom properties e2e test (#18861) 2024-12-02 09:22:22 +05:30
Siddhant
8fcb8ecdd7
Add trigger option 'TestSuiteStatusUpdates' for TestSuite status changes (#18836)
* fix: Provide trigger option as TestSuiteStatusUpdates for TestSuite source

* add the playwright change to test the test suite status field in alert

* localization changes

---------

Co-authored-by: Aniket Katkar <aniketkatkar97@gmail.com>
2024-11-28 23:28:36 +05:30
Shailesh Parmar
4720a8da2b
playwright: added initial db setup for playwright test (#18832)
* playwright: fixed service ingestion aut

* updated the initial start of the playwright test
2024-11-28 20:26:30 +05:30
Karan Hotchandani
e22fc6ddeb
Fix Glossary tree hierarchy state (#18703)
* fix the tree state on edit glossary term

* add playwright tests

* fix permission loading

* fix tests

* adding timeout for in review state

* adding timeout for in review state

* increasing timeout

* fix tests

* update tests

* add a poll for checking tasks created

* testing response

* adding limit

* fix tests

* change user for testing

* Catch Exceptions on the Consumer to avoid losing records

---------

Co-authored-by: Pablo Takara <pjt1991@gmail.com>
2024-11-28 16:36:45 +05:30
Ashish Gupta
7877d5c14c
Allow Asset add and remove operation for editTag permission user (#18786)
* Allow Asset add and remove operation for editTag permission user

* remove edit all permission check in bulkAssetTag api for tag

* fix the permission check by checking specific and the index used to exclude

* check editTag permission before updating assets by bulkTagAsset api

* fix the button not visible for the non admin user

* added playwright for the limited user check aroud asset

* restrict add asset button in certification page

* minor fix

* cleanup aroud tag page and fix usertab count around Team page

* use entity type instead of search index

---------

Co-authored-by: sonikashah <sonikashah94@gmail.com>
Co-authored-by: karanh37 <karanh37@gmail.com>
2024-11-28 16:15:07 +05:30
Pranita Fulsundar
fdd8c5878c
fix: add and remove users in a team (#18776)
* Improvement : Teams api to update and remove users

* fix: add and remove user apis, with e2e test case

* fix: test for Teams page

* fix: e2e test for delete user

* fix: remove user field from fetchTeamAdvancedDetails function

* fix: test for loadAdvancedDetails

* fix: response api for add and remove user

* fix: userCount after delete

* fix: update users call

---------

Co-authored-by: sonikashah <sonikashah94@gmail.com>
Co-authored-by: sonika-shah <58761340+sonika-shah@users.noreply.github.com>
2024-11-27 19:13:16 +05:30
Chirag Madlani
3ff11d8518
Revert "Add alert bar component (#17230)" (#18812)
This reverts commit e32f9cf8623cbe96cce8d0cc6c063b489c3f9590.
2024-11-27 16:43:33 +05:30
Aniket Katkar
c101c7cf30
Minor: Auto classification UI (#18785)
* Add the auto classification pipeline option in the service ingestion

* Localization changes for other languages

* Improve the logic for getSupportedPipelineTypes function and add unit tests for newly added logic

* Add playwright tests for the auto classification feature

* Improve the getSupportedPipelineTypes function logic to reduce the cognitive complexity

* update md docs

* Add classificationFilterPattern in the UI schema form order

* fix logs from backend for auto classification

* Changes to view the auto classification logs

* Fix the sonar errors

---------

Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com>
2024-11-27 14:51:59 +05:30
Sweta Agarwalla
e32f9cf862
Add alert bar component (#17230)
* add alert bar component

* updated as per comments

* updated as per comments

* updated alert bar component

* remove styles attributes

* update styles

* add alert store and use alert in page layout

* update component to have reset method

* refactor: update reset calling method

* update reset method name

* updated as per feedbacks

* refcator: update CrossIcon component usage

* chore: remove condition for CrossIcon

* update animation for opening alert bar.

* add autoCloseTimer to alert banner

* remove cross icon component

* add cross icon svg

* update to fix the height issue

* fix height glitch issue when alert appears

* update the alert notification tests

* update alert transition issue

* revert the changes for height issue

* add alert in mydata

* update alert animation issue

* update alert position in page layout

* update as per feedbacks

* fix tests failure

* update test for toast

* remove dummy alert bar

* made alert fixed to top

* fix check failing issue

* fix activity feed playwright test issue

* update test

* fix test issues

* update page layout

* fix sonar cloud failure

* fix sonar cloud failure

* fix test issues

* resolve sonar issue

* update lineage spec

* update as per comments

* update domain page css

* fix sonar issue

* fix sonar cloud issue

* remove react-toastify

* fix sonar error

* yarn install command run

* update yarn lock

* revert yarn lock changes

* update yarn lock

* revert yarn

* revert yarn changes

* remove toastify instance

* update message type

* fix sonar issue

* add alert bar in Alert details page

* create mock for page layout

---------

Co-authored-by: Sachin Chaurasiya <sachinchaurasiyachotey87@gmail.com>
Co-authored-by: Ashish Gupta <ashish@getcollate.io>
Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2024-11-27 00:35:23 +05:30
Ashish Gupta
490bbf6241
fix: tag page issue around disabled badge and Certification data in ES (#18697)
* fix tag page issue around disabled badge and other

* reset the unwanted code

* modify playwright test for consumer and steward

* modify tag es query to check the prefix in fqn

* fix query and sonar issue

* fix the asset not coming in Tier and Certification page tab

* fix the playwright failure
2024-11-26 19:07:46 +05:30
Aniket Katkar
998cbd1558
Improvements: Alerts bug fixes and improvements (#18753)
* Add and improve the permission logic for the notifications and observability alerts pages
Add logic to update the description from alert details page.
Add logic to set the logged in user as the owner while alert creation

* Remove the permission check for the `/{alertType}/resources` API since it's not necessary

* Update the playwright tests to cover the new alert features

* Add playwright to test the test destinations filter

* Fix the unit tests

* Add unit test for AlertRecentEventsTab component

* update the variable.less import to reference

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
2024-11-26 18:00:58 +05:30
Shailesh Parmar
31c2dee533
GEN-1530: fix DQ Layout Improvements (#18754)
* GEN-1530: fix DQ Layout Improvements

* fixed failing playwright test
2024-11-24 14:16:01 +05:30
Sriharsha Chintalapani
9484d838a4
Minor: fix Lineage export when there is no column / pipeline edge (#18737)
* Minor: fix Lineage export when there is no column / pipeline edge

* add test for lineage export (#18709)

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>

* add lineage export tests

---------

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
Co-authored-by: Sweta Agarwalla <105535990+sweta1308@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>
2024-11-22 08:21:19 -08:00
Shailesh Parmar
cda201b1b8
Minor: supporting PR for UI/UX improvement in DQ (#18663)
* Minor: supporting PR for UI/UX improvement in DQ

* updated feedback

* move incidents tab to data observabilty tab

* fixed failing unit test

* fixed failing unit test

* fixed AUT failure!

* fixed failing aut

* minor fixes

* minor fix

* updated icon

* fixed failing unit test
2024-11-21 16:41:32 +05:30
Teddy
429e48aa3a
#18677 - Added Lineage Field back to SearchLineage (#18687)
* fix: add lineage field back to searchLineage

* add lineage tests

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
2024-11-20 11:13:09 +01:00
Ashish Gupta
484a9584ea
MINOR: added domain data in lineage side panel and fix relatedColumn search TableConstraints modal (#18671)
* added domain data in lineage side panel

* localization keys

* fix unit test

* fix unit test and minor improvement around permission in schema page utils

* added the encoding and escape method to query
2024-11-19 17:03:15 +05:30
sonika-shah
853bbc205b
GEN-1983 : Feat - Support Tag Asset Page (#18505)
* Feat :  Support bulk adding tag to Assets

* remove warnings

* add apis for assets remove

* Fix: Add tag page (#18461)

* add tag page which all Assets

* update as per feedbacks

* update as per feedbacks

* add divider in header badge

* remove styling

* update permission and refactoring code

* updated as per comments

* fix sonar cloud issues

* add delete asset functionality

* refactor entityTypeString

* made the top bar fixed to top

* add tests for tag page

* fix check failures issue

* fix tag page check failure

* fix flaky test issue

* add tag page tests

* update the add asset test

* update playwright tests

* add right panel in tag page

* updated as per feedbacks

* remove usage test

* updated as per feedbacks

---------

* Backend: make bulkAssets api async

* Backend: limit bulkAssets api async to Tag Assets page

* Update Tag page Assets API (#18622)

* create branch

* update add asset API

* add websocket on tags page

---------

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>

* add failed case for socket operation

---------

Co-authored-by: Karan Hotchandani <33024356+karanh37@users.noreply.github.com>
Co-authored-by: Sweta Agarwalla <105535990+sweta1308@users.noreply.github.com>
Co-authored-by: karanh37 <karanh37@gmail.com>
2024-11-18 17:57:07 +05:30
Shrushti Polekar
5cdde2054b
fix glossary column dropdown drag drop integration test (#18662) 2024-11-17 21:44:33 +05:30
Sachin Chaurasiya
be642e7253
GEN-1694: metric entity improvement (#18659)
* GEN-1694: metric entity improvement

* add clike and python language mode in schemaeditor

* add getMetricExpressionLanguageName util to extract the language from metric expression
2024-11-15 20:30:42 +05:30
Shrushti Polekar
393c7a4098
Fix: update glossary terms table stylings and temporarily bypass failing drag-and-drop test (#18653)
* update terms table styling and skip failing drag-drop test

* address pr comments related to styles
2024-11-15 16:05:15 +05:30
Sweta Agarwalla
6cdfff35b5
MINOR: fix owner link and update search index in navbar (#18609)
* fix minor issues

* update owner column component

* update list sequence

* add database search indexes

* add navbar search dropdown tests

* updated owner snapshot

* update wait for response API

* fix tests

---------

Co-authored-by: karanh37 <karanh37@gmail.com>
2024-11-15 13:22:59 +05:30
Mayur Singal
8104c3aec6
MINOR: Fix Redshift DBT Playwright (#18642) 2024-11-14 18:15:23 +05:30
Aniket Katkar
bfc12feafc
GEN-1976: Alert improvements (#18448)
* Move the alert components to the components folder from pages folder

* auto generated localization changes and linting changes

* Fix the imports

* Add AlertConfigDetails component

* Add tabs in the alert details page

* auto generated localization changes

* Apply permissions for alert and add owner update functionality

* Change the alert update method from PUT to PATCH

* Add the recent events tab

* auto generated localization changes

* Improve the recent events tab for alert details

* Implement the logic to show alert events count on the alert details page

* auto generated localization and linting changes

* Add the pagination logic for the recent events list on the alert details page

* Fix the logic for previous click in NextPreviousWithOffset

* Localization change for other languages

* Hide pagination when not required

* Add pagination and permissions to API; create eventsRecord API; fix timestamp issue

* fix: remove publisherName from test destination message.

* Fix the recent events tab error

* fix: Resolve PATCH API issue with destination ID creation.

* fix: Delete associated alert metrics upon alert deletion

* feat: Detailed HTTP Response for Destination Test

* Add the test external destination functionality

* localization changes for other languages

* fix: Set status for testing destination in EmailPublisher

* Add advanced configurations for webhook destinations

* Localization changes for other languages

* Fix the destination status not showing
Add the POST and PUT radio button in advanced configs

* Localization changes for other languages

* Update the API to fetch the alert event diagnostic counts

* Improve the AlertConfigDetails component to show the alert configs properly

* fix: Display displayName instead of fullyQualifiedName in templates

* Fix the test destination result not showing the first time

* Fix the test destination status not showing for already existing destinations

* Fix the unit tests

* Fix playwright tests

* refactor: Separate sendMessage and sendTestMessage methods; add statusContext

* fix: Use name or fqn as fallback if displayName is null or empty

* fix: upsert successfulChangeEvent

* eliminate the GovernanceWorkflowChangeEvent option from external destination

* Add code comments

* Fix the unit test

---------

Co-authored-by: Siddhant <86899184+Siddhanttimeline@users.noreply.github.com>
Co-authored-by: Siddhanttimeline <siddhanttimeline9@gmail.com>
2024-11-14 17:39:45 +05:30
Shrushti Polekar
626464f443
Feat: Support for column customization for Glossary term table (#18584) 2024-11-14 10:22:11 +05:30