mirror of
https://github.com/open-metadata/OpenMetadata.git
synced 2025-07-05 16:19:35 +00:00

* feat: indexed test case results * feat: added indexation logic for test case results * style: ran java linting * fix: IDE warnigns * chore: added test case results migration * style: ran java linting * fix: postgres migration column json ref * empty commit to trigger queued * chore: extracted test case results to its own resource * chore: fix failing tests * chore: move testCaseResult state from testSuite and testCase to dynamic field fetched from test case results search index * chore: clean up test case repository * style: ran java linting * chore: removed testCaseResultSummary and testCaseResult state from db * fix: test failures * chore: fix index mapping type for result value * chore: fix test failure
234 lines
8.7 KiB
Python
234 lines
8.7 KiB
Python
import sys
|
|
from dataclasses import dataclass
|
|
from datetime import datetime
|
|
from typing import List
|
|
|
|
import pytest
|
|
|
|
from _openmetadata_testutils.pydantic.test_utils import assert_equal_pydantic_objects
|
|
from metadata.data_quality.api.models import TestCaseDefinition
|
|
from metadata.generated.schema.entity.services.databaseService import DatabaseService
|
|
from metadata.generated.schema.metadataIngestion.testSuitePipeline import (
|
|
TestSuiteConfigType,
|
|
TestSuitePipeline,
|
|
)
|
|
from metadata.generated.schema.tests.basic import TestCaseResult, TestCaseStatus
|
|
from metadata.generated.schema.tests.testCase import TestCase
|
|
from metadata.ingestion.ometa.ometa_api import OpenMetadata
|
|
from metadata.workflow.data_quality import TestSuiteWorkflow
|
|
from metadata.workflow.metadata import MetadataWorkflow
|
|
|
|
if not sys.version_info >= (3, 9):
|
|
pytest.skip("requires python 3.9+", allow_module_level=True)
|
|
|
|
|
|
@pytest.fixture()
|
|
def get_test_suite_config(workflow_config, sink_config):
|
|
def inner(entity_fqn: str, test_case_definitions: List[TestCaseDefinition]):
|
|
return {
|
|
"source": {
|
|
"type": TestSuiteConfigType.TestSuite.value,
|
|
"serviceName": "MyTestSuite",
|
|
"sourceConfig": {
|
|
"config": TestSuitePipeline(
|
|
type=TestSuiteConfigType.TestSuite,
|
|
entityFullyQualifiedName=entity_fqn,
|
|
)
|
|
},
|
|
},
|
|
"processor": {
|
|
"type": "orm-test-runner",
|
|
"config": {
|
|
"testCases": [obj.model_dump() for obj in test_case_definitions]
|
|
},
|
|
},
|
|
"sink": sink_config,
|
|
"workflowConfig": workflow_config,
|
|
}
|
|
|
|
return inner
|
|
|
|
|
|
@dataclass
|
|
class TestColumnParameter:
|
|
entity_fqn: str
|
|
test_case_definition: TestCaseDefinition
|
|
expected_result: TestCaseResult
|
|
|
|
|
|
@pytest.fixture(
|
|
params=[
|
|
TestColumnParameter(
|
|
entity_fqn="{database_service_fqn}.default.employees.employees",
|
|
test_case_definition=TestCaseDefinition(
|
|
name="first_name_includes_tom_and_jerry_wo_enum",
|
|
testDefinitionName="columnValuesToBeInSet",
|
|
computePassedFailedRowCount=True,
|
|
columnName="first_name",
|
|
parameterValues=[
|
|
{"name": "allowedValues", "value": "['Tom', 'Jerry']"}
|
|
],
|
|
),
|
|
expected_result=TestCaseResult(
|
|
timestamp=int(datetime.now().timestamp() * 1000),
|
|
testCaseStatus=TestCaseStatus.Failed,
|
|
),
|
|
),
|
|
TestColumnParameter(
|
|
entity_fqn="{database_service_fqn}.default.employees.employees",
|
|
test_case_definition=TestCaseDefinition(
|
|
name="value_lengths_between_3_and_5",
|
|
testDefinitionName="columnValueLengthsToBeBetween",
|
|
computePassedFailedRowCount=True,
|
|
columnName="first_name",
|
|
parameterValues=[
|
|
{"name": "minLength", "value": "3"},
|
|
{"name": "maxLength", "value": "5"},
|
|
],
|
|
),
|
|
expected_result=TestCaseResult(
|
|
timestamp=int(datetime.now().timestamp() * 1000),
|
|
testCaseStatus=TestCaseStatus.Failed,
|
|
),
|
|
),
|
|
TestColumnParameter(
|
|
entity_fqn="{database_service_fqn}.default.employees.employees",
|
|
test_case_definition=TestCaseDefinition(
|
|
name="value_lengths_at_most_5",
|
|
testDefinitionName="columnValueLengthsToBeBetween",
|
|
columnName="first_name",
|
|
computePassedFailedRowCount=True,
|
|
parameterValues=[
|
|
{"name": "maxLength", "value": "5"},
|
|
],
|
|
),
|
|
expected_result=TestCaseResult(
|
|
timestamp=int(datetime.now().timestamp() * 1000),
|
|
testCaseStatus=TestCaseStatus.Failed,
|
|
),
|
|
),
|
|
TestColumnParameter(
|
|
entity_fqn="{database_service_fqn}.default.employees.employees",
|
|
test_case_definition=TestCaseDefinition(
|
|
name="value_lengths_at_least_3",
|
|
testDefinitionName="columnValueLengthsToBeBetween",
|
|
columnName="first_name",
|
|
computePassedFailedRowCount=True,
|
|
parameterValues=[
|
|
{"name": "minLength", "value": "3"},
|
|
],
|
|
),
|
|
expected_result=TestCaseResult(
|
|
timestamp=int(datetime.now().timestamp() * 1000),
|
|
testCaseStatus=TestCaseStatus.Success,
|
|
),
|
|
),
|
|
TestColumnParameter(
|
|
entity_fqn="{database_service_fqn}.default.employees.employees",
|
|
test_case_definition=TestCaseDefinition(
|
|
name="id_at_least_0",
|
|
testDefinitionName="columnValuesToBeBetween",
|
|
columnName="emp_no",
|
|
computePassedFailedRowCount=True,
|
|
parameterValues=[
|
|
{"name": "minValue", "value": "0"},
|
|
],
|
|
),
|
|
expected_result=TestCaseResult(
|
|
timestamp=int(datetime.now().timestamp() * 1000),
|
|
testCaseStatus=TestCaseStatus.Success,
|
|
),
|
|
),
|
|
TestColumnParameter(
|
|
entity_fqn="{database_service_fqn}.default.employees.employees",
|
|
test_case_definition=TestCaseDefinition(
|
|
name="id_no_bounds",
|
|
testDefinitionName="columnValuesToBeBetween",
|
|
columnName="emp_no",
|
|
computePassedFailedRowCount=True,
|
|
parameterValues=[],
|
|
),
|
|
expected_result=TestCaseResult(
|
|
timestamp=int(datetime.now().timestamp() * 1000),
|
|
testCaseStatus=TestCaseStatus.Success,
|
|
),
|
|
),
|
|
TestColumnParameter(
|
|
entity_fqn="{database_service_fqn}.default.employees.employees",
|
|
test_case_definition=TestCaseDefinition(
|
|
name="values_between_date",
|
|
testDefinitionName="columnValuesToBeBetween",
|
|
columnName="hire_date",
|
|
computePassedFailedRowCount=True,
|
|
parameterValues=[
|
|
{
|
|
"name": "minValue",
|
|
"value": str(int(datetime(1960, 1, 1).timestamp())),
|
|
},
|
|
],
|
|
),
|
|
expected_result=TestCaseResult(
|
|
timestamp=int(datetime.now().timestamp() * 1000),
|
|
testCaseStatus=TestCaseStatus.Success,
|
|
),
|
|
),
|
|
TestColumnParameter(
|
|
entity_fqn="{database_service_fqn}.default.employees.employees",
|
|
test_case_definition=TestCaseDefinition(
|
|
name="value_between_timestamp",
|
|
testDefinitionName="columnValuesToBeBetween",
|
|
columnName="last_update",
|
|
computePassedFailedRowCount=True,
|
|
parameterValues=[
|
|
{
|
|
"name": "minValue",
|
|
"value": str(int(datetime(2000, 1, 1).timestamp())),
|
|
},
|
|
],
|
|
),
|
|
expected_result=TestCaseResult(
|
|
timestamp=int(datetime.now().timestamp() * 1000),
|
|
testCaseStatus=TestCaseStatus.Failed,
|
|
),
|
|
),
|
|
],
|
|
ids=lambda x: x.test_case_definition.name,
|
|
)
|
|
def parameters(request, db_service):
|
|
request.param.entity_fqn = request.param.entity_fqn.format(
|
|
database_service_fqn=db_service.fullyQualifiedName.root
|
|
)
|
|
return request.param
|
|
|
|
|
|
def test_column_test_cases(
|
|
patch_passwords_for_db_services,
|
|
run_workflow,
|
|
ingestion_config,
|
|
db_service: DatabaseService,
|
|
metadata: OpenMetadata,
|
|
parameters: TestColumnParameter,
|
|
get_test_suite_config,
|
|
cleanup_fqns,
|
|
):
|
|
run_workflow(MetadataWorkflow, ingestion_config)
|
|
test_suite_config = get_test_suite_config(
|
|
parameters.entity_fqn,
|
|
[parameters.test_case_definition],
|
|
)
|
|
run_workflow(TestSuiteWorkflow, test_suite_config)
|
|
test_case: TestCase = metadata.get_by_name(
|
|
TestCase,
|
|
f"{parameters.entity_fqn}.{parameters.test_case_definition.columnName}.{parameters.test_case_definition.name}",
|
|
fields=["*"],
|
|
nullable=False,
|
|
)
|
|
cleanup_fqns(TestCase, test_case.fullyQualifiedName.root)
|
|
parameters.expected_result.timestamp = (
|
|
test_case.testCaseResult.timestamp
|
|
) # timestamp is not deterministic
|
|
assert_equal_pydantic_objects(
|
|
parameters.expected_result,
|
|
test_case.testCaseResult,
|
|
)
|