mirror of
https://github.com/open-metadata/OpenMetadata.git
synced 2025-10-31 10:39:30 +00:00
af0672e4cf
* Update `TableDiffParamsSetter` to move data at table level This means that `key_columns` and `extra_columns` will be defined per table instead of "globally", just like `data_diff` expects * Update `TableDiffValidator` to use table's `key_columns` Call `data_diff` and run validations using each table's `key_columns` * Create migration to update `tableDiff` test definition * Fix Playwright test
62 lines
2.4 KiB
SQL
62 lines
2.4 KiB
SQL
-- Correct the table diff test definition
|
|
-- This is to include the new parameter table2.keyColumns
|
|
UPDATE test_definition
|
|
SET json = JSON_SET(
|
|
json,
|
|
'$.parameterDefinition',
|
|
JSON_ARRAY(
|
|
JSON_OBJECT(
|
|
'name', 'keyColumns',
|
|
'displayName', 'Table 1\'s key columns',
|
|
'description', 'The columns to use as the key for the comparison. If not provided, it will be resolved from the primary key or unique columns. The tuples created from the key columns must be unique.',
|
|
'dataType', 'ARRAY',
|
|
'required', false
|
|
),
|
|
JSON_OBJECT(
|
|
'name', 'table2',
|
|
'displayName', 'Table 2',
|
|
'description', 'Fully qualified name of the table to compare against.',
|
|
'dataType', 'STRING',
|
|
'required', true
|
|
),
|
|
JSON_OBJECT(
|
|
'name', 'table2.keyColumns',
|
|
'displayName', 'Table 2\'s key columns',
|
|
'description', 'The columns in table 2 to use as comparison. If not provided, it will default to `Key Columns`, risking errors if the key columns\' names have changed.',
|
|
'dataType', 'ARRAY',
|
|
'required', false
|
|
),
|
|
JSON_OBJECT(
|
|
'name', 'threshold',
|
|
'displayName', 'Threshold',
|
|
'description', 'Threshold to use to determine if the test passes or fails (defaults to 0).',
|
|
'dataType', 'NUMBER',
|
|
'required', false
|
|
),
|
|
JSON_OBJECT(
|
|
'name', 'useColumns',
|
|
'displayName', 'Use Columns',
|
|
'description', 'Limits the scope of the test to this list of columns. If not provided, all columns will be used except the key columns.',
|
|
'dataType', 'ARRAY',
|
|
'required', false
|
|
),
|
|
JSON_OBJECT(
|
|
'name', 'where',
|
|
'displayName', 'SQL Where Clause',
|
|
'description', 'Use this where clause to filter the rows to compare.',
|
|
'dataType', 'STRING',
|
|
'required', false
|
|
),
|
|
JSON_OBJECT(
|
|
'name', 'caseSensitiveColumns',
|
|
'displayName', 'Case sensitive columns',
|
|
'description', 'Use case sensitivity when comparing the columns.',
|
|
'dataType', 'BOOLEAN',
|
|
'required', false
|
|
)
|
|
),
|
|
'$.version',
|
|
0.2
|
|
)
|
|
WHERE name = 'tableDiff';
|