mirror of
https://github.com/open-metadata/OpenMetadata.git
synced 2025-07-18 22:53:09 +00:00

* Fix #14786: Suggestions API * Handle suggestions in ometa * Minor: Optimise Databricks Client (#14776) * MINOR - Fix SP topology context & Looker usage context (#14816) * MINOR - Fix SP topology context & Looker usage context * MINOR - Fix SP topology context & Looker usage context * Fix tests * Fixes #14598: Fix Tags / Labels ingestion on includeTags as False (#14782) * fix(ui): password error message for char limits (#14808) * fix(ui): password error message for char limits * fix java side code * Fixes #13556: Support for Salesforce table description ingestion (#14733) * ISSUE-13556: Add suport for Salesforce table description ingestion * ISSUE-13556: Remove unnecessary blank line * ISSUE-13556: Fix to get description for each table --------- Co-authored-by: Teddy <teddy.crepineau@gmail.com> * MINOR - Better handling of Ingestion Pipeline Status (#14792) * MINOR - Better handling of Ingestion Pipeline Status * format * format * MINOR: Added table validation for cost analysis data (#14793) * Added validation for cost analysis source * centralized life cycle logic * CYPRESS: simplify side navigation click in cypress (#14818) * simplify side navigation click in cypress * make sidbar item uses common enum * fix cypress failure of outside import * fix(#14326): tier dropdown is not working in advance search (#14780) * improvement in advance search based on custom property * fix a reading undefined property issue * wip: advance search based on tier * some code cleanup and improvement * some fixes * fix: ui flicker when advanceSearched is apply and refresh the page * some cleanup * no need to call customproperty api call, if entity not suppport customProperties * minor change * fix: autocomplete not working in tier search option in advance search modal * added unit test for advance search provider component * some cleanup * added testcase for open modal * added testcase for resetAllFilters method * removed unwanted code * added e2e test for testing tier advance search * fix: e2e search flow for single field * fix: string field not working after giving listValues in TierSearch * fix: group query e2e test fix * used asyncFetch way to get the tierOptions synchronously * some cleanup * remove unwanted lines * some cleanup * fix: selected option show option value instead of option title * fix(minor): update skip icon for executions (#14809) * Fixes #14803: ignore capitalization when confirming deletes (#14804) * ignore case when confirming deletes * Test confirmation of deletes works when case differs Added test case for 'delete' as the confirmation text. * minor(config): update openmetadata-ui code reviewers (#14823) * Add Tests * Add list/accept/reject apis * initial ui changes * localisation * show suggestion for empty description * ui feedbacks * Fix permission check for entities without owner * Fix entityLink and add tests * Add update suggestion WIP * Fix test * Fix PUT and Pagination * Fix styling * update test * Update status * add OM server connection in apps * add permissions check * Fix CI * Remove TODO * Fix feedResourceTest * fix unit tests * add private configs for apps * add private configs for apps * fix update application icons * minor center align icon * add private configs for apps * Format * Fix pydantic gen * Remove token * Update name * Rework private conf * Fix apps * Fix apps * Format * Format * show metapilot only if its installed --------- Co-authored-by: Pere Miquel Brull <peremiquelbrull@gmail.com> Co-authored-by: Mayur Singal <39544459+ulixius9@users.noreply.github.com> Co-authored-by: Ayush Shah <ayush@getcollate.io> Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com> Co-authored-by: kwgdaig <18678754+kwgdaig@users.noreply.github.com> Co-authored-by: Teddy <teddy.crepineau@gmail.com> Co-authored-by: Onkar Ravgan <onkar.10r@gmail.com> Co-authored-by: Ashish Gupta <ashish@getcollate.io> Co-authored-by: Abhishek Porwal <80886271+Abhishek332@users.noreply.github.com> Co-authored-by: Carlo Q <carlo@machina.bio> Co-authored-by: karanh37 <karanh37@gmail.com>
207 lines
6.7 KiB
Python
207 lines
6.7 KiB
Python
# Copyright 2021 Collate
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
"""
|
|
Test helpers module
|
|
"""
|
|
import uuid
|
|
from unittest import TestCase
|
|
|
|
from metadata.generated.schema.entity.data.table import Column, DataType, Table
|
|
from metadata.generated.schema.entity.feed.suggestion import Suggestion, SuggestionType
|
|
from metadata.generated.schema.type.basic import EntityLink
|
|
from metadata.generated.schema.type.tagLabel import (
|
|
LabelType,
|
|
State,
|
|
TagLabel,
|
|
TagSource,
|
|
)
|
|
from metadata.utils.helpers import (
|
|
clean_up_starting_ending_double_quotes_in_string,
|
|
deep_size_of_dict,
|
|
find_suggestion,
|
|
format_large_string_numbers,
|
|
get_entity_tier_from_tags,
|
|
is_safe_sql_query,
|
|
list_to_dict,
|
|
)
|
|
|
|
|
|
class TestHelpers(TestCase):
|
|
"""
|
|
Test helpers module
|
|
"""
|
|
|
|
def test_list_to_dict(self):
|
|
original = ["key=value", "a=b"]
|
|
|
|
self.assertEqual(list_to_dict(original=original), {"key": "value", "a": "b"})
|
|
self.assertEqual(list_to_dict([]), {})
|
|
self.assertEqual(list_to_dict(None), {})
|
|
|
|
def test_clean_up_starting_ending_double_quotes_in_string(self):
|
|
input_ = '"password"'
|
|
output_ = "password"
|
|
|
|
assert clean_up_starting_ending_double_quotes_in_string(input_) == output_
|
|
|
|
def test_get_entity_tier_from_tags(self):
|
|
"""test correct entity tier are returned"""
|
|
table_entity_w_tier = Table(
|
|
id=uuid.uuid4(),
|
|
name="table_entity_test",
|
|
columns=[Column(name="col1", dataType=DataType.STRING)],
|
|
tags=[
|
|
TagLabel(
|
|
tagFQN="Tier.Tier1",
|
|
source=TagSource.Classification,
|
|
labelType=LabelType.Automated,
|
|
state=State.Confirmed,
|
|
),
|
|
TagLabel(
|
|
tagFQN="Foo.Bar",
|
|
source=TagSource.Classification,
|
|
labelType=LabelType.Automated,
|
|
state=State.Confirmed,
|
|
),
|
|
],
|
|
)
|
|
|
|
assert get_entity_tier_from_tags(table_entity_w_tier.tags) == "Tier.Tier1"
|
|
|
|
table_entity_wo_tier = Table(
|
|
id=uuid.uuid4(),
|
|
name="table_entity_test",
|
|
columns=[Column(name="col1", dataType=DataType.STRING)],
|
|
tags=[
|
|
TagLabel(
|
|
tagFQN="Foo.Bar",
|
|
source=TagSource.Classification,
|
|
labelType=LabelType.Automated,
|
|
state=State.Confirmed,
|
|
)
|
|
],
|
|
)
|
|
|
|
assert get_entity_tier_from_tags(table_entity_wo_tier.tags) is None
|
|
|
|
def test_deep_size_of_dict(self):
|
|
"""test deep size of dict"""
|
|
test_dict = {
|
|
"a": 1,
|
|
"b": {"c": 2, "d": {"e": "Hello World", "f": [4, 5, 6]}},
|
|
}
|
|
|
|
assert deep_size_of_dict(test_dict) >= 1000
|
|
assert deep_size_of_dict(test_dict) <= 1500
|
|
|
|
def test_is_safe_sql_query(self):
|
|
"""Test is_safe_sql_query function"""
|
|
|
|
delete_query = """
|
|
DELETE FROM airflow_task_instance
|
|
WHERE dag_id = 'test_dag_id'
|
|
"""
|
|
|
|
drop_query = """
|
|
DROP TABLE IF EXISTS test_table
|
|
"""
|
|
|
|
create_query = """
|
|
CREATE TABLE test_table (
|
|
id INT,
|
|
name VARCHAR(255)
|
|
)
|
|
"""
|
|
|
|
select_query = """
|
|
SELECT * FROM test_table
|
|
"""
|
|
|
|
cte_query = """
|
|
WITH foo AS (
|
|
SELECT * FROM test_table
|
|
)
|
|
SELECT * FROM foo
|
|
"""
|
|
|
|
transaction_query = """
|
|
BEGIN TRAN T1;
|
|
UPDATE table1 ...;
|
|
BEGIN TRAN M2 WITH MARK;
|
|
UPDATE table2 ...;
|
|
SELECT * from table1;
|
|
COMMIT TRAN M2;
|
|
UPDATE table3 ...;
|
|
COMMIT TRAN T1;
|
|
"""
|
|
|
|
self.assertFalse(is_safe_sql_query(delete_query))
|
|
self.assertFalse(is_safe_sql_query(drop_query))
|
|
self.assertFalse(is_safe_sql_query(create_query))
|
|
self.assertTrue(is_safe_sql_query(select_query))
|
|
self.assertTrue(is_safe_sql_query(cte_query))
|
|
self.assertFalse(is_safe_sql_query(transaction_query))
|
|
|
|
def test_format_large_string_numbers(self):
|
|
"""test format_large_string_numbers"""
|
|
assert format_large_string_numbers(1000) == "1.000K"
|
|
assert format_large_string_numbers(1001) == "1.001K"
|
|
assert format_large_string_numbers(1000000) == "1.000M"
|
|
assert format_large_string_numbers(1000000000) == "1.000B"
|
|
assert format_large_string_numbers(1000000000000) == "1.000T"
|
|
|
|
def test_find_suggestion(self):
|
|
"""we can get one possible suggestion"""
|
|
suggestions = [
|
|
Suggestion(
|
|
id=uuid.uuid4(),
|
|
type=SuggestionType.SuggestDescription,
|
|
entityLink=EntityLink(__root__="<#E::table::tableFQN>"),
|
|
description="something",
|
|
),
|
|
Suggestion(
|
|
id=uuid.uuid4(),
|
|
type=SuggestionType.SuggestDescription,
|
|
entityLink=EntityLink(__root__="<#E::table::tableFQN::columns::col>"),
|
|
description="something",
|
|
),
|
|
]
|
|
|
|
self.assertIsNone(
|
|
find_suggestion(
|
|
suggestions=suggestions,
|
|
suggestion_type=SuggestionType.SuggestTagLabel,
|
|
entity_link=...,
|
|
)
|
|
)
|
|
|
|
self.assertIsNone(
|
|
find_suggestion(
|
|
suggestions=suggestions,
|
|
suggestion_type=SuggestionType.SuggestDescription,
|
|
entity_link=...,
|
|
)
|
|
)
|
|
|
|
suggestion_table = find_suggestion(
|
|
suggestions=suggestions,
|
|
suggestion_type=SuggestionType.SuggestDescription,
|
|
entity_link=EntityLink(__root__="<#E::table::tableFQN>"),
|
|
)
|
|
self.assertEqual(suggestion_table, suggestions[0])
|
|
|
|
suggestion_col = find_suggestion(
|
|
suggestions=suggestions,
|
|
suggestion_type=SuggestionType.SuggestDescription,
|
|
entity_link=EntityLink(__root__="<#E::table::tableFQN::columns::col>"),
|
|
)
|
|
self.assertEqual(suggestion_col, suggestions[1])
|