yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-03 12:16:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest): change redash sql parse error to warnining (#14785)

Browse Source
This commit is contained in:
Kevin Karch 2025-09-17 08:06:15 -04:00 committed by GitHub
parent 667b7cb12c
commit 002cc398d0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
metadata-ingestion/src/datahub/ingestion/source/redash.py
View File

@ -447,7 +447,7 @@ class RedashSource(StatefulIngestionSourceBase):
dataset_urns = sql_parser_in_tables.in_tables
if sql_parser_in_tables.debug_info.table_error:
self.report.queries_problem_parsing.add(str(query_id))
self.error(
self.warn(
logger,
"sql-parsing",
f"exception {sql_parser_in_tables.debug_info.table_error} in parsing query-{query_id}-datasource-{data_source_id}",

28
metadata-ingestion/tests/unit/test_redash_source.py
View File

@ -16,6 +16,7 @@ from datahub.metadata.com.linkedin.pegasus2avro.metadata.snapshot import (
DashboardSnapshot,
)
from datahub.metadata.schema_classes import ChartInfoClass, DashboardInfoClass
from datahub.sql_parsing.sqlglot_lineage import SqlParsingDebugInfo
mock_dashboard_response = {
"tags": [],
@ -724,3 +725,30 @@ def test_get_chart_snapshot_parse_table_names_from_sql(mocked_data_source):
)
assert result == expected
@patch("datahub.ingestion.source.redash.create_lineage_sql_parsed_result")
@patch("datahub.ingestion.source.redash.RedashSource._get_chart_data_source")
def test_sql_parsing_error_generates_warning(mocked_data_source, mocked_sql_parser):
mocked_data_source.return_value = {
**mock_mysql_data_source_response,
"syntax": "sql",
}
class MockResult:
def __init__(self):
self.in_tables = []
self.debug_info = SqlParsingDebugInfo()
self.debug_info.table_error = Exception("Invalid SQL syntax")
mocked_sql_parser.return_value = MockResult()
source = redash_source_parse_table_names_from_sql()
result = source._get_datasource_urns(
mocked_data_source.return_value,
{"id": 123, "query": "SELECT * FROM invalid_table;"},
)
assert result is None
assert "123" in source.report.queries_problem_parsing
assert len(source.report.warnings) > 0