yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-24 16:38:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(misc): NPE and GraphQL case fixes (#7149)

Browse Source
This commit is contained in:
david-leifker 2023-01-26 17:41:15 -06:00 committed by GitHub
parent 927d45dda9
commit 07c5d4f6af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/types/common/mappers/UrnToEntityMapper.java
View File

@ -152,8 +152,8 @@ public class UrnToEntityMapper implements ModelMapper<com.linkedin.common.urn.Ur
}
if (input.getEntityType().equals("test")) {
partialEntity = new Test();
((Assertion) partialEntity).setUrn(input.toString());
((Assertion) partialEntity).setType(EntityType.TEST);
((Test) partialEntity).setUrn(input.toString());
((Test) partialEntity).setType(EntityType.TEST);
}
if (input.getEntityType().equals(DATAHUB_ROLE_ENTITY_NAME)) {
partialEntity = new DataHubRole();

7
metadata-io/src/main/java/com/linkedin/metadata/timeline/eventgenerator/EditableSchemaMetadataChangeEventGenerator.java
View File

@ -16,10 +16,12 @@ import com.linkedin.metadata.timeline.data.SemanticChangeType;
import com.linkedin.schema.EditableSchemaFieldInfo;
import com.linkedin.schema.EditableSchemaFieldInfoArray;
import com.linkedin.schema.EditableSchemaMetadata;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Comparator;
import java.util.List;
import java.util.Optional;
import java.util.Set;
import java.util.stream.Collectors;
import java.util.stream.Stream;
@ -147,8 +149,9 @@ public class EditableSchemaMetadataChangeEventGenerator extends EntityChangeEven
.category(ChangeCategory.DOCUMENTATION)
.operation(ChangeOperation.REMOVE)
.semVerChange(SemanticChangeType.MINOR)
.description(String.format(FIELD_DOCUMENTATION_REMOVED_FORMAT, targetFieldInfo.getFieldPath(), datasetFieldUrn,
baseFieldDescription))
.description(String.format(FIELD_DOCUMENTATION_REMOVED_FORMAT,
Optional.ofNullable(targetFieldInfo).map(EditableSchemaFieldInfo::getFieldPath),
datasetFieldUrn, baseFieldDescription))
.auditStamp(auditStamp)
.build();
}