diff --git a/metadata-builders/src/main/java/com/linkedin/metadata/builders/graph/relationship/RelationshipBuilderFromDataJobInputOutput.java b/metadata-builders/src/main/java/com/linkedin/metadata/builders/graph/relationship/RelationshipBuilderFromDataJobInputOutput.java index 819c0b063f..84d07a40ca 100644 --- a/metadata-builders/src/main/java/com/linkedin/metadata/builders/graph/relationship/RelationshipBuilderFromDataJobInputOutput.java +++ b/metadata-builders/src/main/java/com/linkedin/metadata/builders/graph/relationship/RelationshipBuilderFromDataJobInputOutput.java @@ -3,7 +3,6 @@ package com.linkedin.metadata.builders.graph.relationship; import com.linkedin.datajob.DataJobInputOutput; import com.linkedin.common.urn.Urn; import com.linkedin.metadata.builders.graph.GraphBuilder; -import com.linkedin.metadata.relationship.DownstreamOf; import com.linkedin.metadata.relationship.Consumes; import com.linkedin.metadata.relationship.Produces; @@ -23,12 +22,6 @@ public class RelationshipBuilderFromDataJobInputOutput extends BaseRelationshipB @Nonnull @Override public List buildRelationships(@Nonnull Urn urn, @Nonnull DataJobInputOutput inputOutput) { - final List downstreamEdges = inputOutput.getInputDatasets() - .stream() - .flatMap(upstreamDataset -> inputOutput.getOutputDatasets().stream() - .map(downstreamDataset -> new DownstreamOf().setSource(downstreamDataset).setDestination(upstreamDataset))) - .collect(Collectors.toList()); - final List inputsList = inputOutput.getInputDatasets() .stream() .map(inputDataset -> new Consumes().setSource(urn).setDestination(inputDataset)) @@ -40,7 +33,6 @@ public class RelationshipBuilderFromDataJobInputOutput extends BaseRelationshipB .collect(Collectors.toList()); return Arrays.asList( - new GraphBuilder.RelationshipUpdates(downstreamEdges, REMOVE_ALL_EDGES_FROM_SOURCE), new GraphBuilder.RelationshipUpdates(inputsList, REMOVE_ALL_EDGES_FROM_SOURCE), new GraphBuilder.RelationshipUpdates(outputsList, REMOVE_ALL_EDGES_FROM_SOURCE)); } diff --git a/metadata-builders/src/test/java/com/linkedin/metadata/builders/graph/relationship/RelationshipBuilderFromDataJobInputOutputTest.java b/metadata-builders/src/test/java/com/linkedin/metadata/builders/graph/relationship/RelationshipBuilderFromDataJobInputOutputTest.java index ca538be6c9..19bf105a3f 100644 --- a/metadata-builders/src/test/java/com/linkedin/metadata/builders/graph/relationship/RelationshipBuilderFromDataJobInputOutputTest.java +++ b/metadata-builders/src/test/java/com/linkedin/metadata/builders/graph/relationship/RelationshipBuilderFromDataJobInputOutputTest.java @@ -26,50 +26,26 @@ public class RelationshipBuilderFromDataJobInputOutputTest { List operations = new RelationshipBuilderFromDataJobInputOutput().buildRelationships(job, inputOutput); - assertEquals(operations.size(), 3); + assertEquals(operations.size(), 2); - assertEquals(operations.get(0).getRelationships().size(), 4); + assertEquals(operations.get(0).getRelationships().size(), 2); assertEquals( operations.get(0).getRelationships().get(0), - makeDownstreamOf( - makeDatasetUrn("output1"), - makeDatasetUrn("input1"))); + makeConsumes(job, makeDatasetUrn("input1"))); assertEquals( operations.get(0).getRelationships().get(1), - makeDownstreamOf( - makeDatasetUrn("output2"), - makeDatasetUrn("input1"))); - assertEquals( - operations.get(0).getRelationships().get(2), - makeDownstreamOf( - makeDatasetUrn("output1"), - makeDatasetUrn("input2"))); - assertEquals( - operations.get(0).getRelationships().get(3), - makeDownstreamOf( - makeDatasetUrn("output2"), - makeDatasetUrn("input2"))); + makeConsumes(job, makeDatasetUrn("input2"))); assertEquals(operations.get(0).getPreUpdateOperation(), BaseGraphWriterDAO.RemovalOption.REMOVE_ALL_EDGES_FROM_SOURCE); assertEquals(operations.get(1).getRelationships().size(), 2); assertEquals( operations.get(1).getRelationships().get(0), - makeConsumes(job, makeDatasetUrn("input1"))); - assertEquals( - operations.get(1).getRelationships().get(1), - makeConsumes(job, makeDatasetUrn("input2"))); - assertEquals(operations.get(1).getPreUpdateOperation(), - BaseGraphWriterDAO.RemovalOption.REMOVE_ALL_EDGES_FROM_SOURCE); - - assertEquals(operations.get(2).getRelationships().size(), 2); - assertEquals( - operations.get(2).getRelationships().get(0), makeProduces(job, makeDatasetUrn("output1"))); assertEquals( - operations.get(2).getRelationships().get(1), + operations.get(1).getRelationships().get(1), makeProduces(job, makeDatasetUrn("output2"))); - assertEquals(operations.get(2).getPreUpdateOperation(), + assertEquals(operations.get(1).getPreUpdateOperation(), BaseGraphWriterDAO.RemovalOption.REMOVE_ALL_EDGES_FROM_SOURCE); } @@ -93,4 +69,3 @@ public class RelationshipBuilderFromDataJobInputOutputTest { } } -