yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-25 17:08:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): ownership rendering (#2373)

Browse Source 
Co-authored-by: shubham.garg <shubham.garg@thoughtworks.com>
This commit is contained in:
shubham garg 2021-04-10 05:26:42 +05:30 committed by GitHub
parent a19085094a
commit 0b01c7d9dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 39 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
datahub-web-react/src/app/entity/user/UserOwnership.tsx
View File

@ -44,7 +44,7 @@ export default ({ ownerships, entityPath }: Props) => {
renderItem={(item) => {
return (
<ListItem>
{entityRegistry.renderPreview(entityType, PreviewType.PREVIEW, item)}
{entityRegistry.renderPreview(entityType, PreviewType.PREVIEW, item.entity)}
<Divider />
</ListItem>
);

4
datahub-web-react/src/app/entity/user/UserProfile.tsx
View File

@ -35,12 +35,12 @@ export default function UserProfile() {
const ownershipForDetails = useMemo(() => {
Object.keys(ownershipResult).forEach((type) => {
const entities = ownershipResult[type].data?.search?.entities;
const entities = ownershipResult[type].data?.search?.searchResults;
if (!entities || entities.length === 0) {
delete ownershipResult[type];
} else {
ownershipResult[type] = ownershipResult[type].data?.search?.entities;
ownershipResult[type] = ownershipResult[type].data?.search?.searchResults;
}
});
return ownershipResult;

32
datahub-web-react/src/app/entity/user/__tests__/UserDetails.test.tsx
View File

@ -8,24 +8,28 @@ import { Subview } from '../Subview';
const ownerships = {
[EntityType.Dataset]: [
{
name: 'HiveDataset',
origin: 'PROD',
description: 'this is a dataset',
platformNativeType: PlatformNativeType.Table,
platform: {
name: 'hive',
entity: {
name: 'HiveDataset',
origin: 'PROD',
description: 'this is a dataset',
platformNativeType: PlatformNativeType.Table,
platform: {
name: 'hive',
},
tags: [],
},
tags: [],
},
{
name: 'KafkaDataset',
origin: 'PROD',
description: 'this is also a dataset',
platformNativeType: PlatformNativeType.Table,
platform: {
name: 'kafka',
entity: {
name: 'KafkaDataset',
origin: 'PROD',
description: 'this is also a dataset',
platformNativeType: PlatformNativeType.Table,
platform: {
name: 'kafka',
},
tags: [],
},
tags: [],
},
],
};

32
datahub-web-react/src/app/entity/user/__tests__/UserOwnership.test.tsx
View File

@ -7,24 +7,28 @@ import TestPageContainer from '../../../../utils/test-utils/TestPageContainer';
const ownerships = {
[EntityType.Dataset]: [
{
name: 'HiveDataset',
origin: 'PROD',
description: 'this is a dataset',
platformNativeType: PlatformNativeType.Table,
platform: {
name: 'hive',
entity: {
name: 'HiveDataset',
origin: 'PROD',
description: 'this is a dataset',
platformNativeType: PlatformNativeType.Table,
platform: {
name: 'hive',
},
tags: [],
},
tags: [],
},
{
name: 'KafkaDataset',
origin: 'PROD',
description: 'this is also a dataset',
platformNativeType: PlatformNativeType.Table,
platform: {
name: 'kafka',
entity: {
name: 'KafkaDataset',
origin: 'PROD',
description: 'this is also a dataset',
platformNativeType: PlatformNativeType.Table,
platform: {
name: 'kafka',
},
tags: [],
},
tags: [],
},
],
};