yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-11 00:42:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(config) Set search and browse flags default off (#8378)

Browse Source
This commit is contained in:
Chris Collins 2023-07-10 11:57:35 -04:00 committed by GitHub
parent 3e47b3d228
commit 12543bca33
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
metadata-service/factories/src/main/resources/application.yml
View File

@ -266,7 +266,7 @@ bootstrap:
upgradeDefaultBrowsePaths: upgradeDefaultBrowsePaths:
enabled: ${UPGRADE_DEFAULT_BROWSE_PATHS_ENABLED:false} # enable to run the upgrade to migrate legacy default browse paths to new ones enabled: ${UPGRADE_DEFAULT_BROWSE_PATHS_ENABLED:false} # enable to run the upgrade to migrate legacy default browse paths to new ones
backfillBrowsePathsV2: backfillBrowsePathsV2:
enabled: ${BACKFILL_BROWSE_PATHS_V2:true} # Enables running the backfill of browsePathsV2 upgrade step. There are concerns about the load of this step so hiding it behind a flag. enabled: ${BACKFILL_BROWSE_PATHS_V2:false} # Enables running the backfill of browsePathsV2 upgrade step. There are concerns about the load of this step so hiding it behind a flag.
systemUpdate: systemUpdate:
initialBackOffMs: ${BOOTSTRAP_SYSTEM_UPDATE_INITIAL_BACK_OFF_MILLIS:5000} initialBackOffMs: ${BOOTSTRAP_SYSTEM_UPDATE_INITIAL_BACK_OFF_MILLIS:5000}
@ -285,8 +285,8 @@ featureFlags:
alwaysEmitChangeLog: ${ALWAYS_EMIT_CHANGE_LOG:false} # Enables always emitting a MCL even when no changes are detected. Used for Time Based Lineage when no changes occur. alwaysEmitChangeLog: ${ALWAYS_EMIT_CHANGE_LOG:false} # Enables always emitting a MCL even when no changes are detected. Used for Time Based Lineage when no changes occur.
searchServiceDiffModeEnabled: ${SEARCH_SERVICE_DIFF_MODE_ENABLED:true} # Enables diff mode for search document writes, reduces amount of writes to ElasticSearch documents for no-ops searchServiceDiffModeEnabled: ${SEARCH_SERVICE_DIFF_MODE_ENABLED:true} # Enables diff mode for search document writes, reduces amount of writes to ElasticSearch documents for no-ops
readOnlyModeEnabled: ${READ_ONLY_MODE_ENABLED:false} # Enables read only mode for an instance. Right now this only affects ability to edit user profile image URL but can be extended readOnlyModeEnabled: ${READ_ONLY_MODE_ENABLED:false} # Enables read only mode for an instance. Right now this only affects ability to edit user profile image URL but can be extended
showSearchFiltersV2: ${SHOW_SEARCH_FILTERS_V2:true} # Enables showing the search filters V2 experience. showSearchFiltersV2: ${SHOW_SEARCH_FILTERS_V2:false} # Enables showing the search filters V2 experience.
showBrowseV2: ${SHOW_BROWSE_V2:true} # Enables showing the browse v2 sidebar experience. showBrowseV2: ${SHOW_BROWSE_V2:false} # Enables showing the browse v2 sidebar experience.
preProcessHooks: preProcessHooks:
uiEnabled: ${PRE_PROCESS_HOOKS_UI_ENABLED:true} # Circumvents Kafka for processing index updates for UI changes sourced from GraphQL to avoid processing delays uiEnabled: ${PRE_PROCESS_HOOKS_UI_ENABLED:true} # Circumvents Kafka for processing index updates for UI changes sourced from GraphQL to avoid processing delays
showAcrylInfo: ${SHOW_ACRYL_INFO:false} # Show different CTAs within DataHub around moving to Managed DataHub. Set to true for the demo site. showAcrylInfo: ${SHOW_ACRYL_INFO:false} # Show different CTAs within DataHub around moving to Managed DataHub. Set to true for the demo site.

2
smoke-test/tests/cypress/cypress/e2e/browse/browseV2.js
View File

@ -13,6 +13,8 @@ describe("search", () => {
req.reply((res) => { req.reply((res) => {
// Modify the response body directly // Modify the response body directly
res.body.data.appConfig.featureFlags.showBrowseV2 = isOn; res.body.data.appConfig.featureFlags.showBrowseV2 = isOn;
// search and browse both need to be on for browse to show
res.body.data.appConfig.featureFlags.showSearchFiltersV2 = isOn;
}); });
} }
}); });

4
smoke-test/tests/cypress/cypress/e2e/mutations/domains.js
View File

@ -34,10 +34,8 @@ describe("add remove domain", () => {
it("search filter by domain", () => { it("search filter by domain", () => {
cy.login(); cy.login();
cy.goToStarSearchList() cy.goToStarSearchList()
cy.get("[data-testid=filter-dropdown-Domain").click({ force: true });
cy.waitTextVisible(test_domain) cy.waitTextVisible(test_domain)
cy.get(`[data-testid="filter-option-${test_domain}"]`).click({ force: true }); cy.get('[data-testid="facet-domains-' + test_domain_urn + '"]').click()
cy.get("[data-testid=update-filters]").click({ force: true });
cy.waitTextVisible("customers") cy.waitTextVisible("customers")
}) })