yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-17 13:13:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(docker): fix gradle quickstart version parsing (#7614)

Browse Source
This commit is contained in:
Harshal Sheth 2023-03-17 12:10:05 -04:00 committed by GitHub
parent 41d4c0b074
commit 14ecba1e62
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
metadata-ingestion/src/datahub/cli/docker_cli.py
View File

@ -11,7 +11,7 @@ import tempfile
import time
from enum import Enum
from pathlib import Path
from typing import Dict, List, NoReturn, Optional
from typing import Dict, List, Optional
import click
import click_spinner
@ -87,18 +87,6 @@ def docker() -> None:
pass
def _print_issue_list_and_exit(
issues: List[str], header: str, footer: Optional[str] = None
) -> NoReturn:
click.secho(header, fg="bright_red")
for issue in issues:
click.echo(f"- {issue}")
if footer:
click.echo()
click.echo(footer)
sys.exit(1)
@docker.command()
@upgrade.check_upgrade
@telemetry.with_telemetry()

2
metadata-ingestion/src/datahub/cli/quickstart_versioning.py
View File

@ -29,7 +29,7 @@ def _is_it_a_version(version: str) -> bool:
:param version: The string to check.
:return: True if the string is a valid version, False otherwise.
"""
return re.match(r"v?\d+\.\d+(\.\d+)?", version) is not None
return re.match(r"^v?\d+\.\d+(\.\d+)?$", version) is not None
class QuickstartVersionMappingConfig(BaseModel):