From 1dae37a8edc7f24d942236d8a46b895b417f724f Mon Sep 17 00:00:00 2001
From: Harshal Sheth <hsheth2@gmail.com>
Date: Mon, 6 May 2024 16:30:04 -0700
Subject: [PATCH] fix(ingest/bigquery): remove last modified timestamp fallback
 (#10431)

---
 .../datahub/ingestion/source/bigquery_v2/bigquery_schema.py | 6 +++---
 .../tests/integration/mysql/docker-compose.yml              | 1 -
 metadata-ingestion/tests/unit/test_bigquery_source.py       | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_schema.py b/metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_schema.py
index d918782691..ca09496eda 100644
--- a/metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_schema.py
+++ b/metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_schema.py
@@ -275,7 +275,7 @@ class BigQuerySchemaApi:
                 table.get("last_altered") / 1000, tz=timezone.utc
             )
             if table.get("last_altered") is not None
-            else table.created,
+            else None,
             size_in_bytes=table.get("bytes"),
             rows_count=table.get("row_count"),
             comment=table.comment,
@@ -339,7 +339,7 @@ class BigQuerySchemaApi:
                 view.get("last_altered") / 1000, tz=timezone.utc
             )
             if view.get("last_altered") is not None
-            else view.created,
+            else None,
             comment=view.comment,
             view_definition=view.view_definition,
             materialized=view.table_type == BigqueryTableType.MATERIALIZED_VIEW,
@@ -487,7 +487,7 @@ class BigQuerySchemaApi:
                 snapshot.get("last_altered") / 1000, tz=timezone.utc
             )
             if snapshot.get("last_altered") is not None
-            else snapshot.created,
+            else None,
             comment=snapshot.comment,
             ddl=snapshot.ddl,
             snapshot_time=snapshot.snapshot_time,
diff --git a/metadata-ingestion/tests/integration/mysql/docker-compose.yml b/metadata-ingestion/tests/integration/mysql/docker-compose.yml
index 6a46a1b8dc..db7ea3d441 100644
--- a/metadata-ingestion/tests/integration/mysql/docker-compose.yml
+++ b/metadata-ingestion/tests/integration/mysql/docker-compose.yml
@@ -4,7 +4,6 @@ services:
     image: mysql:8
     # image: mariadb:10.5.8 # Uncomment to run on m1
     container_name: "testmysql"
-    command: --default-authentication-plugin=mysql_native_password
     environment:
       MYSQL_ROOT_PASSWORD: example
     ports:
diff --git a/metadata-ingestion/tests/unit/test_bigquery_source.py b/metadata-ingestion/tests/unit/test_bigquery_source.py
index 426d4dc12f..c501593fbe 100644
--- a/metadata-ingestion/tests/unit/test_bigquery_source.py
+++ b/metadata-ingestion/tests/unit/test_bigquery_source.py
@@ -829,7 +829,7 @@ def bigquery_view_2() -> BigqueryView:
     return BigqueryView(
         name="table2",
         created=now,
-        last_altered=now,
+        last_altered=None,
         comment="comment2",
         view_definition="CREATE VIEW 2",
         materialized=True,