Merge pull request #651 from theseyi/master

adds default empty array if columns api values are not returned
This commit is contained in:
Seyi Adebajo 2017-08-09 10:50:43 -07:00 committed by GitHub
commit 1df5b3a57e

View File

@ -141,7 +141,7 @@ export default Route.extend({
*/
getDatasetColumn = id =>
Promise.resolve(getJSON(getDatasetColumnUrl(id)))
.then(({ status, columns }) => {
.then(({ status, columns = [] }) => {
if (status === 'ok') {
if (columns && columns.length) {
const columnsWithHTMLComments = columns.map(column => {
@ -171,7 +171,10 @@ export default Route.extend({
return Promise.reject(new Error('Dataset columns request failed.'));
})
.then(columns => columns.map(({ dataType, fullFieldPath }) => ({ dataType, fieldName: fullFieldPath })))
.catch(() => setProperties(controller, { hasSchemas: false, schemas: null }));
.catch(() => {
setProperties(controller, { hasSchemas: false, schemas: null });
return [];
});
/**
* async IIFE sets the the complianceInfo and schemaFieldNamesMappedToDataTypes