yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-03 12:16:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #651 from theseyi/master

Browse Source 
adds default empty array if columns api values are not returned
This commit is contained in:
Seyi Adebajo 2017-08-09 10:50:43 -07:00 committed by GitHub
commit 1df5b3a57e
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
wherehows-web/app/routes/datasets/dataset.js
View File

@ -141,7 +141,7 @@ export default Route.extend({
*/ */
getDatasetColumn = id => getDatasetColumn = id =>
Promise.resolve(getJSON(getDatasetColumnUrl(id))) Promise.resolve(getJSON(getDatasetColumnUrl(id)))
.then(({ status, columns }) => { .then(({ status, columns = [] }) => {
if (status === 'ok') { if (status === 'ok') {
if (columns && columns.length) { if (columns && columns.length) {
const columnsWithHTMLComments = columns.map(column => { const columnsWithHTMLComments = columns.map(column => {
@ -171,7 +171,10 @@ export default Route.extend({
return Promise.reject(new Error('Dataset columns request failed.')); return Promise.reject(new Error('Dataset columns request failed.'));
}) })
.then(columns => columns.map(({ dataType, fullFieldPath }) => ({ dataType, fieldName: fullFieldPath }))) .then(columns => columns.map(({ dataType, fullFieldPath }) => ({ dataType, fieldName: fullFieldPath })))
.catch(() => setProperties(controller, { hasSchemas: false, schemas: null })); .catch(() => {
setProperties(controller, { hasSchemas: false, schemas: null });
return [];
});
/** /**
* async IIFE sets the the complianceInfo and schemaFieldNamesMappedToDataTypes * async IIFE sets the the complianceInfo and schemaFieldNamesMappedToDataTypes