yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-30 03:56:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(ingest): fix mssql lint (#6453)

Browse Source
This commit is contained in:
Harshal Sheth 2022-11-15 23:11:57 -05:00 committed by GitHub
parent 33fd876421
commit 1ffd24131e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
metadata-ingestion/src/datahub/ingestion/source/sql/mssql.py
View File

@ -136,13 +136,16 @@ class SQLServerSource(SQLAlchemySource):
@staticmethod @staticmethod
def _add_output_converters(conn: Connection) -> None: def _add_output_converters(conn: Connection) -> None:
def handle_sql_variant_as_string(value): def handle_sql_variant_as_string(value):
return value.decode('utf-16le') return value.decode("utf-16le")
# see https://stackoverflow.com/questions/45677374/pandas-pyodbc-odbc-sql-type-150-is-not-yet-supported # see https://stackoverflow.com/questions/45677374/pandas-pyodbc-odbc-sql-type-150-is-not-yet-supported
# and https://stackoverflow.com/questions/11671170/adding-output-converter-to-pyodbc-connection-in-sqlalchemy # and https://stackoverflow.com/questions/11671170/adding-output-converter-to-pyodbc-connection-in-sqlalchemy
try: try:
conn.connection.add_output_converter(-150, handle_sql_variant_as_string) conn.connection.add_output_converter(-150, handle_sql_variant_as_string)
except AttributeError as e: except AttributeError as e:
logger.debug(f"Failed to mount output converter for MSSQL data type -150 due to {e}") logger.debug(
f"Failed to mount output converter for MSSQL data type -150 due to {e}"
)
def _populate_table_descriptions(self, conn: Connection, db_name: str) -> None: def _populate_table_descriptions(self, conn: Connection, db_name: str) -> None:
# see https://stackoverflow.com/questions/5953330/how-do-i-map-the-id-in-sys-extended-properties-to-an-object-name # see https://stackoverflow.com/questions/5953330/how-do-i-map-the-id-in-sys-extended-properties-to-an-object-name