yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-11 08:54:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest): exclude mssql-odbc from "all" extra (#2660)

Browse Source
This commit is contained in:
Harshal Sheth 2021-06-07 14:00:35 -07:00 committed by GitHub
parent 9c030d8325
commit 2123c8b6d7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
docker/datahub-ingestion/Dockerfile
View File

@ -16,13 +16,13 @@ RUN apt-get update && apt-get install -y \
FROM openjdk:8 as prod-build FROM openjdk:8 as prod-build
COPY . /datahub-src COPY . /datahub-src
RUN cd /datahub-src && ./gradlew :metadata-events:mxe-schemas:build # RUN cd /datahub-src && ./gradlew :metadata-events:mxe-schemas:build
FROM base as prod-codegen FROM base as prod-codegen
COPY --from=prod-build /datahub-src /datahub-src COPY --from=prod-build /datahub-src /datahub-src
RUN cd /datahub-src/metadata-ingestion && \ # RUN cd /datahub-src/metadata-ingestion && \
pip install -e ".[base]" && \ # pip install -e ".[base]" && \
./scripts/codegen.sh # ./scripts/codegen.sh
FROM base as prod-install FROM base as prod-install
COPY --from=prod-codegen /datahub-src/metadata-ingestion /datahub-ingestion COPY --from=prod-codegen /datahub-src/metadata-ingestion /datahub-ingestion

16
metadata-ingestion/setup.py
View File

@ -92,6 +92,12 @@ plugins: Dict[str, Set[str]] = {
"glue": {"boto3"}, "glue": {"boto3"},
} }
all_exclude_plugins: Set[str] = {
# SQL Server ODBC requires additional drivers, and so we don't want to keep
# it included in the default "all" installation.
"mssql-odbc",
}
base_dev_requirements = { base_dev_requirements = {
*base_requirements, *base_requirements,
*framework_common, *framework_common,
@ -234,7 +240,15 @@ setuptools.setup(
plugin: list(framework_common | dependencies) plugin: list(framework_common | dependencies)
for (plugin, dependencies) in plugins.items() for (plugin, dependencies) in plugins.items()
}, },
"all": list(framework_common.union(*plugins.values())), "all": list(
framework_common.union(
*[
requirements
for plugin, requirements in plugins.items()
if plugin not in all_exclude_plugins
]
)
),
"dev": list(dev_requirements), "dev": list(dev_requirements),
"dev-airflow2": list(dev_requirements_airflow_2), "dev-airflow2": list(dev_requirements_airflow_2),
}, },