yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-11 00:48:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(url-encoding): fix regression in url encoding (#12601)

Browse Source
This commit is contained in:
david-leifker 2025-02-12 13:58:52 -06:00 committed by GitHub
parent 67a6394a37
commit 21496ef9d0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 119 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/how/updating-datahub.md
View File

@ -22,6 +22,10 @@ This file documents any backwards-incompatible changes in DataHub and assists pe
- #12408: The `platform` field in the DataPlatformInstance GraphQL type is removed. Clients need to retrieve the platform via the optional `dataPlatformInstance` field.
### Known Issues
- #12601: Jetty 12 introduces a stricter handling of url encoding. We are currently applying a workaround to prevent a regression, while technically breaking the official specifications.
### Potential Downtime
### Deprecations

17
metadata-service/war/src/main/java/com/linkedin/gms/CommonApplicationConfig.java
View File

@ -2,7 +2,10 @@ package com.linkedin.gms;
import com.linkedin.metadata.spring.YamlPropertySourceFactory;
import java.lang.management.ManagementFactory;
import java.util.Set;
import javax.management.MBeanServer;
import org.eclipse.jetty.ee10.servlet.ServletHandler;
import org.eclipse.jetty.http.UriCompliance;
import org.eclipse.jetty.jmx.MBeanContainer;
import org.eclipse.jetty.server.Connector;
import org.eclipse.jetty.server.HttpConfiguration;
@ -65,13 +68,27 @@ public class CommonApplicationConfig {
@Bean
public WebServerFactoryCustomizer<JettyServletWebServerFactory> jettyCustomizer() {
return factory -> {
// Configure HTTP
factory.addServerCustomizers(
server -> {
// HTTP Configuration
HttpConfiguration httpConfig = new HttpConfiguration();
httpConfig.setRequestHeaderSize(32768);
// See https://github.com/jetty/jetty.project/issues/11890
// Configure URI compliance to allow encoded slashes
httpConfig.setUriCompliance(
UriCompliance.from(
Set.of(
UriCompliance.Violation.AMBIGUOUS_PATH_SEPARATOR,
UriCompliance.Violation.AMBIGUOUS_PATH_ENCODING)));
// set this for Servlet 6+
server
.getContainedBeans(ServletHandler.class)
.forEach(handler -> handler.setDecodeAmbiguousURIs(true));
// HTTP Connector
ServerConnector connector =
new ServerConnector(server, new HttpConnectionFactory(httpConfig));

98
smoke-test/tests/openapi/v3/entities.json
View File

@ -20,6 +20,13 @@
"method": "delete"
}
},
{
"request": {
"url": "/openapi/v3/entity/dataset/urn%3Ali%3Adataset%3A%28urn%3Ali%3AdataPlatform%3Atest%2Cdataset%2FEntityV3%2CPROD%29",
"description": "Remove test dataset with %2F",
"method": "delete"
}
},
{
"request": {
"url": "/openapi/v3/entity/dataset",
@ -156,5 +163,96 @@
]
}
}
},
{
"request": {
"url": "/openapi/v3/entity/dataset",
"params": {
"async": "false"
},
"description": "Create dataset with %2F",
"json": [
{
"urn": "urn:li:dataset:(urn:li:dataPlatform:test,dataset/EntityV3,PROD)",
"datasetProperties": {
"value": {
"name": "dataset/EntityV3",
"qualifiedName": "entities.dataset/EntityV3",
"customProperties": {},
"tags": []
}
},
"status": {
"value": {
"removed": false
}
}
}
]
}
},
{
"request": {
"url": "/openapi/v3/entity/dataset/urn%3Ali%3Adataset%3A%28urn%3Ali%3AdataPlatform%3Atest%2Cdataset%2FEntityV3%2CPROD%29",
"method": "get",
"description": "Get dataset with %2F",
"json": [
{
"urn": "urn:li:dataset:(urn:li:dataPlatform:test,dataset/EntityV3,PROD)",
"datasetProperties": {
"value": {
"name": "dataset/EntityV3",
"qualifiedName": "entities.dataset/EntityV3",
"customProperties": {},
"tags": []
}
},
"status": {
"value": {
"removed": false
}
}
}
]
},
"response": {
"json": {
"urn": "urn:li:dataset:(urn:li:dataPlatform:test,dataset/EntityV3,PROD)",
"browsePathsV2": {
"value": {
"path": [
{
"id": "Default"
}
]
}
},
"datasetKey": {
"value": {
"name": "dataset/EntityV3",
"platform": "urn:li:dataPlatform:test",
"origin": "PROD"
}
},
"dataPlatformInstance": {
"value": {
"platform": "urn:li:dataPlatform:test"
}
},
"datasetProperties": {
"value": {
"name": "dataset/EntityV3",
"customProperties": {},
"qualifiedName": "entities.dataset/EntityV3",
"tags": []
}
},
"status": {
"value": {
"removed": false
}
}
}
}
}
]