yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-25 08:58:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(build): fix regression in local quickstart builds (#13413)

Browse Source
This commit is contained in:
Chakru 2025-05-05 18:48:31 +05:30 committed by GitHub
parent f83460255a
commit 214d376a96
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docker/build.gradle
View File

@ -224,6 +224,7 @@ quickstart_configs.each { taskName, config ->
config.modules.each { module ->
def moduleProject = project.project(module)
project.ext.isDebug = config.isDebug
def generateBakeSnippetsTask = moduleProject.tasks.getByName("generateBakeSnippet")
bakeSnippets.putAll(generateBakeSnippetsTask.bakeSpec.target)
targets.addAll(generateBakeSnippetsTask.bakeSpec.target.keySet())

10
gradle/docker/docker.gradle
View File

@ -43,6 +43,10 @@ def _cleanLocalDockerImages(String fullImageTag) {
}
}
ext {
isDebug = false; // quickStart configs have an isDebug flag set to indicate debug builds
}
// Create extension object
class DockerPluginExtension {
Project project
@ -61,7 +65,7 @@ class DockerPluginExtension {
// For quickStart debug builds that use APP_ENV=dev like pattern. Not used in matrix builds.
MapProperty<String, String> debugBuildArgs
DockerPluginExtension(Project project) {
this.project = project
@ -261,7 +265,9 @@ project.afterEvaluate {
def dockerTag = project.property("tag")
bake_spec_target.tags = extension.tags.get().values().findAll({ tag -> tag.contains(dockerTag) }).toList()
} else {
bake_spec_target.tags = extension.tags.get().values().toList()
bake_spec_target.tags = extension.tags.get().values().findAll({tag ->
project.ext.isDebug || !tag.contains("debug") //Add the debug tag only if this is this is a debug build.
}).toList()
}
if (extension.buildArgs.get()) {
bake_spec_target.args = extension.buildArgs.get()