feat(bigquery): reduce logging (#4961)

* feat(bigquery): reduce logging

* doc: add entry for behaviour change
This commit is contained in:
Aseem Bansal 2022-05-20 22:12:55 +05:30 committed by GitHub
parent c99b1670c3
commit 2260118232
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 1 deletions

View File

@ -11,6 +11,7 @@ This file documents any backwards-incompatible changes in DataHub and assists pe
### Deprecations
### Other notable Changes
- #4961 Dropped profiling is not reported by default as that caused a lot of spurious logging in some cases. Set `profiling.report_dropped_profiles` to `True` if you want older behaviour.
## `v0.8.35`

View File

@ -20,6 +20,10 @@ class GEProfilingConfig(ConfigModel):
default=None,
description="Offset in documents to profile. By default, uses no offset.",
)
report_dropped_profiles: bool = Field(
default=False,
description="If datasets which were not profiled are reported in source report or not. Set to `True` for debugging purposes.",
)
# These settings will override the ones below.
turn_off_expensive_profiling_metrics: bool = Field(

View File

@ -1295,7 +1295,8 @@ class SQLAlchemySource(StatefulIngestionSourceBase):
schema=schema, entity=table, inspector=inspector
)
if not self.is_dataset_eligible_for_profiling(dataset_name, sql_config):
self.report.report_dropped(f"profile of {dataset_name}")
if self.config.profiling.report_dropped_profiles:
self.report.report_dropped(f"profile of {dataset_name}")
continue
dataset_name = self.normalise_dataset_name(dataset_name)