yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-03 20:27:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix(glossary): owner should be optional as per docs (#3858)" (#3910)

Browse Source 
This reverts commit d59574f671f8599933f5b6072d2a65d5e4f3b341.
This commit is contained in:
Aseem Bansal 2022-01-18 23:03:05 +05:30 committed by GitHub
parent 3d981e69be
commit 22efdec2ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
metadata-ingestion/src/datahub/ingestion/source/metadata/business_glossary.py
View File

@ -52,7 +52,7 @@ class DefaultConfig(ConfigModel):
"""Holds defaults for populating fields in glossary terms""" """Holds defaults for populating fields in glossary terms"""
source: str source: str
owners: Optional[Owners] owners: Owners
url: Optional[str] = None url: Optional[str] = None
source_type: Optional[str] = "INTERNAL" source_type: Optional[str] = "INTERNAL"
@ -80,9 +80,7 @@ def make_glossary_term_urn(path: List[str]) -> str:
return "urn:li:glossaryTerm:" + ".".join(path) return "urn:li:glossaryTerm:" + ".".join(path)
def get_owners(owners: Optional[Owners]) -> Optional[models.OwnershipClass]: def get_owners(owners: Owners) -> models.OwnershipClass:
if owners is None:
return None
owners_meta: List[models.OwnerClass] = [] owners_meta: List[models.OwnerClass] = []
if owners.users is not None: if owners.users is not None:
owners_meta = owners_meta + [ owners_meta = owners_meta + [
@ -141,7 +139,7 @@ def get_mces_from_node(
glossaryNode: GlossaryNodeConfig, glossaryNode: GlossaryNodeConfig,
path: List[str], path: List[str],
parentNode: Optional[str], parentNode: Optional[str],
parentOwners: Optional[models.OwnershipClass], parentOwners: models.OwnershipClass,
defaults: DefaultConfig, defaults: DefaultConfig,
) -> List[models.MetadataChangeEventClass]: ) -> List[models.MetadataChangeEventClass]:
node_urn = make_glossary_node_urn(path) node_urn = make_glossary_node_urn(path)
@ -154,19 +152,9 @@ def get_mces_from_node(
assert glossaryNode.owners is not None assert glossaryNode.owners is not None
node_owners = get_owners(glossaryNode.owners) node_owners = get_owners(glossaryNode.owners)
aspects: List[
Union[
models.GlossaryNodeKeyClass,
models.GlossaryNodeInfoClass,
models.OwnershipClass,
models.StatusClass,
]
] = [node_info, valid_status]
if node_owners is not None:
aspects.append(node_owners)
node_snapshot = models.GlossaryNodeSnapshotClass( node_snapshot = models.GlossaryNodeSnapshotClass(
urn=node_urn, urn=node_urn,
aspects=aspects, aspects=[node_info, node_owners, valid_status],
) )
mces = [get_mce_from_snapshot(node_snapshot)] mces = [get_mce_from_snapshot(node_snapshot)]
if glossaryNode.nodes: if glossaryNode.nodes:
@ -195,7 +183,7 @@ def get_mces_from_term(
glossaryTerm: GlossaryTermConfig, glossaryTerm: GlossaryTermConfig,
path: List[str], path: List[str],
parentNode: Optional[str], parentNode: Optional[str],
parentOwnership: Optional[models.OwnershipClass], parentOwnership: models.OwnershipClass,
defaults: DefaultConfig, defaults: DefaultConfig,
) -> List[models.MetadataChangeEventClass]: ) -> List[models.MetadataChangeEventClass]:
term_urn = make_glossary_term_urn(path) term_urn = make_glossary_term_urn(path)
@ -240,12 +228,11 @@ def get_mces_from_term(
) )
aspects.append(relatedTerms) aspects.append(relatedTerms)
ownership: Optional[models.OwnershipClass] = parentOwnership ownership: models.OwnershipClass = parentOwnership
if glossaryTerm.owners is not None: if glossaryTerm.owners is not None:
assert glossaryTerm.owners is not None assert glossaryTerm.owners is not None
ownership = get_owners(glossaryTerm.owners) ownership = get_owners(glossaryTerm.owners)
if ownership is not None: aspects.append(ownership)
aspects.append(ownership)
term_browse = models.BrowsePathsClass(paths=["/" + "/".join(path)]) term_browse = models.BrowsePathsClass(paths=["/" + "/".join(path)])
aspects.append(term_browse) aspects.append(term_browse)