From 23830423f85cefb8cc07148cf836c705d6358f61 Mon Sep 17 00:00:00 2001 From: Teppo Naakka Date: Mon, 13 Mar 2023 22:31:21 +0200 Subject: [PATCH] feat(ingest): powerbi # store powerbi entity descriptions (#7154) Co-authored-by: John Joyce --- .../ingestion/source/powerbi/powerbi.py | 7 +++-- .../powerbi/rest_api_wrapper/data_classes.py | 3 ++ .../powerbi/rest_api_wrapper/data_resolver.py | 3 +- .../golden_test_admin_access_not_allowed.json | 2 +- .../powerbi/golden_test_admin_only.json | 30 +++++++++---------- .../powerbi/golden_test_container.json | 30 +++++++++---------- .../golden_test_disabled_ownership.json | 18 +++++------ .../powerbi/golden_test_endorsement.json | 18 +++++------ .../powerbi/golden_test_ingest.json | 18 +++++------ .../powerbi/golden_test_lineage.json | 18 +++++------ .../golden_test_lower_case_urn_ingest.json | 18 +++++------ .../powerbi/golden_test_report.json | 30 +++++++++---------- .../golden_test_scan_all_workspaces.json | 20 ++++++------- .../tests/integration/powerbi/test_powerbi.py | 4 +++ 14 files changed, 114 insertions(+), 105 deletions(-) diff --git a/metadata-ingestion/src/datahub/ingestion/source/powerbi/powerbi.py b/metadata-ingestion/src/datahub/ingestion/source/powerbi/powerbi.py index 7a699adc8e..9601820cee 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/powerbi/powerbi.py +++ b/metadata-ingestion/src/datahub/ingestion/source/powerbi/powerbi.py @@ -242,7 +242,8 @@ class Mapper: logger.debug(f"{Constant.Dataset_URN}={ds_urn}") # Create datasetProperties mcp ds_properties = DatasetPropertiesClass( - name=table.name, description=table.name + name=table.name, + description=dataset.description, ) info_mcp = self.new_mcp( @@ -415,7 +416,7 @@ class Mapper: # DashboardInfo mcp dashboard_info_cls = DashboardInfoClass( - description=dashboard.displayName or "", + description=dashboard.description, title=dashboard.displayName or "", charts=chart_urn_list, lastModified=ChangeAuditStamps(), @@ -748,7 +749,7 @@ class Mapper: # DashboardInfo mcp dashboard_info_cls = DashboardInfoClass( - description=report.description or "", + description=report.description, title=report.name or "", charts=chart_urn_list, lastModified=ChangeAuditStamps(), diff --git a/metadata-ingestion/src/datahub/ingestion/source/powerbi/rest_api_wrapper/data_classes.py b/metadata-ingestion/src/datahub/ingestion/source/powerbi/rest_api_wrapper/data_classes.py index d5197bc27f..d1adc28028 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/powerbi/rest_api_wrapper/data_classes.py +++ b/metadata-ingestion/src/datahub/ingestion/source/powerbi/rest_api_wrapper/data_classes.py @@ -63,6 +63,7 @@ class Table: class PowerBIDataset: id: str name: Optional[str] + description: str webUrl: Optional[str] workspace_id: str parameters: Optional[Dict[str, str]] @@ -159,6 +160,7 @@ class Tile: class Dashboard: id: str displayName: str + description: str embedUrl: str webUrl: Optional[str] isReadOnly: Any @@ -187,6 +189,7 @@ def new_powerbi_dataset(workspace_id: str, raw_instance: dict) -> PowerBIDataset return PowerBIDataset( id=raw_instance["id"], name=raw_instance.get("name"), + description=raw_instance.get("description", str()), webUrl="{}/details".format(raw_instance.get("webUrl")) if raw_instance.get("webUrl") is not None else None, diff --git a/metadata-ingestion/src/datahub/ingestion/source/powerbi/rest_api_wrapper/data_resolver.py b/metadata-ingestion/src/datahub/ingestion/source/powerbi/rest_api_wrapper/data_resolver.py index c6a5ad6380..b8bbb5807a 100644 --- a/metadata-ingestion/src/datahub/ingestion/source/powerbi/rest_api_wrapper/data_resolver.py +++ b/metadata-ingestion/src/datahub/ingestion/source/powerbi/rest_api_wrapper/data_resolver.py @@ -167,6 +167,7 @@ class DataResolverBase(ABC): id=instance.get(Constant.ID), isReadOnly=instance.get(Constant.IS_READ_ONLY), displayName=instance.get(Constant.DISPLAY_NAME), + description=instance.get(Constant.DESCRIPTION, str()), embedUrl=instance.get(Constant.EMBED_URL), webUrl=instance.get(Constant.WEB_URL), workspace_id=workspace.id, @@ -249,7 +250,7 @@ class DataResolverBase(ABC): name=raw_instance.get(Constant.NAME), webUrl=raw_instance.get(Constant.WEB_URL), embedUrl=raw_instance.get(Constant.EMBED_URL), - description=raw_instance.get(Constant.DESCRIPTION), + description=raw_instance.get(Constant.DESCRIPTION, str()), pages=self._get_pages_by_report( workspace=workspace, report_id=raw_instance[Constant.ID] ), diff --git a/metadata-ingestion/tests/integration/powerbi/golden_test_admin_access_not_allowed.json b/metadata-ingestion/tests/integration/powerbi/golden_test_admin_access_not_allowed.json index 2865bfba42..580641441c 100644 --- a/metadata-ingestion/tests/integration/powerbi/golden_test_admin_access_not_allowed.json +++ b/metadata-ingestion/tests/integration/powerbi/golden_test_admin_access_not_allowed.json @@ -217,7 +217,7 @@ "workspaceId": "64ED5CAD-7C10-4684-8180-826122881108" }, "title": "test_dashboard", - "description": "test_dashboard", + "description": "Description of test dashboard", "charts": [ "urn:li:chart:(powerbi,charts.B8E293DC-0C83-4AA0-9BB9-0A8738DF24A0)", "urn:li:chart:(powerbi,charts.23212598-23b5-4980-87cc-5fc0ecd84385)" diff --git a/metadata-ingestion/tests/integration/powerbi/golden_test_admin_only.json b/metadata-ingestion/tests/integration/powerbi/golden_test_admin_only.json index 2ee5a82aeb..2e3b2b1d9c 100644 --- a/metadata-ingestion/tests/integration/powerbi/golden_test_admin_only.json +++ b/metadata-ingestion/tests/integration/powerbi/golden_test_admin_only.json @@ -8,7 +8,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "", "tags": [] } }, @@ -41,7 +41,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "", "tags": [] } }, @@ -98,7 +98,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "", "tags": [] } }, @@ -155,7 +155,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "", "tags": [] } }, @@ -252,7 +252,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "", "tags": [] } }, @@ -309,7 +309,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "", "tags": [] } }, @@ -366,7 +366,7 @@ "json": { "customProperties": {}, "name": "dbo_book_issue", - "description": "dbo_book_issue", + "description": "", "tags": [] } }, @@ -423,7 +423,7 @@ "json": { "customProperties": {}, "name": "ms_sql_native_table", - "description": "ms_sql_native_table", + "description": "", "tags": [] } }, @@ -717,7 +717,7 @@ "workspaceId": "64ED5CAD-7C10-4684-8180-826122881108" }, "title": "test_dashboard", - "description": "test_dashboard", + "description": "", "charts": [ "urn:li:chart:(powerbi,charts.B8E293DC-0C83-4AA0-9BB9-0A8738DF24A0)", "urn:li:chart:(powerbi,charts.23212598-23b5-4980-87cc-5fc0ecd84385)" @@ -809,7 +809,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "", "tags": [] } }, @@ -842,7 +842,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "", "tags": [] } }, @@ -899,7 +899,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "", "tags": [] } }, @@ -956,7 +956,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "", "tags": [] } }, @@ -1053,7 +1053,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "", "tags": [] } }, @@ -1110,7 +1110,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "", "tags": [] } }, diff --git a/metadata-ingestion/tests/integration/powerbi/golden_test_container.json b/metadata-ingestion/tests/integration/powerbi/golden_test_container.json index 511b41c77f..a57317ea28 100644 --- a/metadata-ingestion/tests/integration/powerbi/golden_test_container.json +++ b/metadata-ingestion/tests/integration/powerbi/golden_test_container.json @@ -74,7 +74,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "Library dataset description", "tags": [] } }, @@ -122,7 +122,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "Library dataset description", "tags": [] } }, @@ -170,7 +170,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "Library dataset description", "tags": [] } }, @@ -218,7 +218,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "Library dataset description", "tags": [] } }, @@ -266,7 +266,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "Library dataset description", "tags": [] } }, @@ -314,7 +314,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "Library dataset description", "tags": [] } }, @@ -362,7 +362,7 @@ "json": { "customProperties": {}, "name": "dbo_book_issue", - "description": "dbo_book_issue", + "description": "hr pbi test description", "tags": [] } }, @@ -410,7 +410,7 @@ "json": { "customProperties": {}, "name": "ms_sql_native_table", - "description": "ms_sql_native_table", + "description": "hr pbi test description", "tags": [] } }, @@ -725,7 +725,7 @@ "workspaceId": "64ED5CAD-7C10-4684-8180-826122881108" }, "title": "test_dashboard", - "description": "test_dashboard", + "description": "Description of test dashboard", "charts": [ "urn:li:chart:(powerbi,charts.B8E293DC-0C83-4AA0-9BB9-0A8738DF24A0)", "urn:li:chart:(powerbi,charts.23212598-23b5-4980-87cc-5fc0ecd84385)" @@ -832,7 +832,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "Library dataset description", "tags": [] } }, @@ -880,7 +880,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "Library dataset description", "tags": [] } }, @@ -928,7 +928,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "Library dataset description", "tags": [] } }, @@ -976,7 +976,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "Library dataset description", "tags": [] } }, @@ -1024,7 +1024,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "Library dataset description", "tags": [] } }, @@ -1072,7 +1072,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "Library dataset description", "tags": [] } }, diff --git a/metadata-ingestion/tests/integration/powerbi/golden_test_disabled_ownership.json b/metadata-ingestion/tests/integration/powerbi/golden_test_disabled_ownership.json index fde3864603..1cf3ce71e8 100644 --- a/metadata-ingestion/tests/integration/powerbi/golden_test_disabled_ownership.json +++ b/metadata-ingestion/tests/integration/powerbi/golden_test_disabled_ownership.json @@ -8,7 +8,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "Library dataset description", "tags": [] } }, @@ -41,7 +41,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "Library dataset description", "tags": [] } }, @@ -74,7 +74,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "Library dataset description", "tags": [] } }, @@ -107,7 +107,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "Library dataset description", "tags": [] } }, @@ -140,7 +140,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "Library dataset description", "tags": [] } }, @@ -173,7 +173,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "Library dataset description", "tags": [] } }, @@ -206,7 +206,7 @@ "json": { "customProperties": {}, "name": "dbo_book_issue", - "description": "dbo_book_issue", + "description": "hr pbi test description", "tags": [] } }, @@ -239,7 +239,7 @@ "json": { "customProperties": {}, "name": "ms_sql_native_table", - "description": "ms_sql_native_table", + "description": "hr pbi test description", "tags": [] } }, @@ -479,7 +479,7 @@ "workspaceId": "64ED5CAD-7C10-4684-8180-826122881108" }, "title": "test_dashboard", - "description": "test_dashboard", + "description": "Description of test dashboard", "charts": [ "urn:li:chart:(powerbi,charts.B8E293DC-0C83-4AA0-9BB9-0A8738DF24A0)", "urn:li:chart:(powerbi,charts.23212598-23b5-4980-87cc-5fc0ecd84385)" diff --git a/metadata-ingestion/tests/integration/powerbi/golden_test_endorsement.json b/metadata-ingestion/tests/integration/powerbi/golden_test_endorsement.json index 7102e3bf2d..4ea05ea63f 100644 --- a/metadata-ingestion/tests/integration/powerbi/golden_test_endorsement.json +++ b/metadata-ingestion/tests/integration/powerbi/golden_test_endorsement.json @@ -8,7 +8,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "Library dataset description", "tags": [] } }, @@ -60,7 +60,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "Library dataset description", "tags": [] } }, @@ -112,7 +112,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "Library dataset description", "tags": [] } }, @@ -164,7 +164,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "Library dataset description", "tags": [] } }, @@ -216,7 +216,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "Library dataset description", "tags": [] } }, @@ -268,7 +268,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "Library dataset description", "tags": [] } }, @@ -320,7 +320,7 @@ "json": { "customProperties": {}, "name": "dbo_book_issue", - "description": "dbo_book_issue", + "description": "hr pbi test description", "tags": [] } }, @@ -353,7 +353,7 @@ "json": { "customProperties": {}, "name": "ms_sql_native_table", - "description": "ms_sql_native_table", + "description": "hr pbi test description", "tags": [] } }, @@ -623,7 +623,7 @@ "workspaceId": "64ED5CAD-7C10-4684-8180-826122881108" }, "title": "test_dashboard", - "description": "test_dashboard", + "description": "Description of test dashboard", "charts": [ "urn:li:chart:(powerbi,charts.B8E293DC-0C83-4AA0-9BB9-0A8738DF24A0)", "urn:li:chart:(powerbi,charts.23212598-23b5-4980-87cc-5fc0ecd84385)" diff --git a/metadata-ingestion/tests/integration/powerbi/golden_test_ingest.json b/metadata-ingestion/tests/integration/powerbi/golden_test_ingest.json index 8f31ad382e..c15a8bb219 100644 --- a/metadata-ingestion/tests/integration/powerbi/golden_test_ingest.json +++ b/metadata-ingestion/tests/integration/powerbi/golden_test_ingest.json @@ -8,7 +8,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "Library dataset description", "tags": [] } }, @@ -41,7 +41,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "Library dataset description", "tags": [] } }, @@ -74,7 +74,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "Library dataset description", "tags": [] } }, @@ -107,7 +107,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "Library dataset description", "tags": [] } }, @@ -140,7 +140,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "Library dataset description", "tags": [] } }, @@ -173,7 +173,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "Library dataset description", "tags": [] } }, @@ -206,7 +206,7 @@ "json": { "customProperties": {}, "name": "dbo_book_issue", - "description": "dbo_book_issue", + "description": "hr pbi test description", "tags": [] } }, @@ -239,7 +239,7 @@ "json": { "customProperties": {}, "name": "ms_sql_native_table", - "description": "ms_sql_native_table", + "description": "hr pbi test description", "tags": [] } }, @@ -509,7 +509,7 @@ "workspaceId": "64ED5CAD-7C10-4684-8180-826122881108" }, "title": "test_dashboard", - "description": "test_dashboard", + "description": "Description of test dashboard", "charts": [ "urn:li:chart:(powerbi,charts.B8E293DC-0C83-4AA0-9BB9-0A8738DF24A0)", "urn:li:chart:(powerbi,charts.23212598-23b5-4980-87cc-5fc0ecd84385)" diff --git a/metadata-ingestion/tests/integration/powerbi/golden_test_lineage.json b/metadata-ingestion/tests/integration/powerbi/golden_test_lineage.json index 84c52f889f..1aa88797e5 100644 --- a/metadata-ingestion/tests/integration/powerbi/golden_test_lineage.json +++ b/metadata-ingestion/tests/integration/powerbi/golden_test_lineage.json @@ -8,7 +8,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "Library dataset description", "tags": [] } }, @@ -41,7 +41,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "Library dataset description", "tags": [] } }, @@ -98,7 +98,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "Library dataset description", "tags": [] } }, @@ -155,7 +155,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "Library dataset description", "tags": [] } }, @@ -252,7 +252,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "Library dataset description", "tags": [] } }, @@ -309,7 +309,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "Library dataset description", "tags": [] } }, @@ -366,7 +366,7 @@ "json": { "customProperties": {}, "name": "dbo_book_issue", - "description": "dbo_book_issue", + "description": "hr pbi test description", "tags": [] } }, @@ -423,7 +423,7 @@ "json": { "customProperties": {}, "name": "ms_sql_native_table", - "description": "ms_sql_native_table", + "description": "hr pbi test description", "tags": [] } }, @@ -717,7 +717,7 @@ "workspaceId": "64ED5CAD-7C10-4684-8180-826122881108" }, "title": "test_dashboard", - "description": "test_dashboard", + "description": "Description of test dashboard", "charts": [ "urn:li:chart:(powerbi,charts.B8E293DC-0C83-4AA0-9BB9-0A8738DF24A0)", "urn:li:chart:(powerbi,charts.23212598-23b5-4980-87cc-5fc0ecd84385)" diff --git a/metadata-ingestion/tests/integration/powerbi/golden_test_lower_case_urn_ingest.json b/metadata-ingestion/tests/integration/powerbi/golden_test_lower_case_urn_ingest.json index 6533e29409..04842b640d 100644 --- a/metadata-ingestion/tests/integration/powerbi/golden_test_lower_case_urn_ingest.json +++ b/metadata-ingestion/tests/integration/powerbi/golden_test_lower_case_urn_ingest.json @@ -8,7 +8,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "Library dataset description", "tags": [] } }, @@ -41,7 +41,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "Library dataset description", "tags": [] } }, @@ -74,7 +74,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "Library dataset description", "tags": [] } }, @@ -107,7 +107,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "Library dataset description", "tags": [] } }, @@ -140,7 +140,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "Library dataset description", "tags": [] } }, @@ -173,7 +173,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "Library dataset description", "tags": [] } }, @@ -206,7 +206,7 @@ "json": { "customProperties": {}, "name": "dbo_book_issue", - "description": "dbo_book_issue", + "description": "hr pbi test description", "tags": [] } }, @@ -239,7 +239,7 @@ "json": { "customProperties": {}, "name": "ms_sql_native_table", - "description": "ms_sql_native_table", + "description": "hr pbi test description", "tags": [] } }, @@ -509,7 +509,7 @@ "workspaceId": "64ED5CAD-7C10-4684-8180-826122881108" }, "title": "test_dashboard", - "description": "test_dashboard", + "description": "Description of test dashboard", "charts": [ "urn:li:chart:(powerbi,charts.B8E293DC-0C83-4AA0-9BB9-0A8738DF24A0)", "urn:li:chart:(powerbi,charts.23212598-23b5-4980-87cc-5fc0ecd84385)" diff --git a/metadata-ingestion/tests/integration/powerbi/golden_test_report.json b/metadata-ingestion/tests/integration/powerbi/golden_test_report.json index e6404be87c..2095562b95 100644 --- a/metadata-ingestion/tests/integration/powerbi/golden_test_report.json +++ b/metadata-ingestion/tests/integration/powerbi/golden_test_report.json @@ -8,7 +8,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "Library dataset description", "tags": [] } }, @@ -41,7 +41,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "Library dataset description", "tags": [] } }, @@ -74,7 +74,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "Library dataset description", "tags": [] } }, @@ -107,7 +107,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "Library dataset description", "tags": [] } }, @@ -140,7 +140,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "Library dataset description", "tags": [] } }, @@ -173,7 +173,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "Library dataset description", "tags": [] } }, @@ -206,7 +206,7 @@ "json": { "customProperties": {}, "name": "dbo_book_issue", - "description": "dbo_book_issue", + "description": "hr pbi test description", "tags": [] } }, @@ -239,7 +239,7 @@ "json": { "customProperties": {}, "name": "ms_sql_native_table", - "description": "ms_sql_native_table", + "description": "hr pbi test description", "tags": [] } }, @@ -509,7 +509,7 @@ "workspaceId": "64ED5CAD-7C10-4684-8180-826122881108" }, "title": "test_dashboard", - "description": "test_dashboard", + "description": "Description of test dashboard", "charts": [ "urn:li:chart:(powerbi,charts.B8E293DC-0C83-4AA0-9BB9-0A8738DF24A0)", "urn:li:chart:(powerbi,charts.23212598-23b5-4980-87cc-5fc0ecd84385)" @@ -601,7 +601,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "Library dataset description", "tags": [] } }, @@ -634,7 +634,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "Library dataset description", "tags": [] } }, @@ -667,7 +667,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "Library dataset description", "tags": [] } }, @@ -700,7 +700,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "Library dataset description", "tags": [] } }, @@ -733,7 +733,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "Library dataset description", "tags": [] } }, @@ -766,7 +766,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "Library dataset description", "tags": [] } }, diff --git a/metadata-ingestion/tests/integration/powerbi/golden_test_scan_all_workspaces.json b/metadata-ingestion/tests/integration/powerbi/golden_test_scan_all_workspaces.json index c1d1b37a2a..0b250a12e2 100644 --- a/metadata-ingestion/tests/integration/powerbi/golden_test_scan_all_workspaces.json +++ b/metadata-ingestion/tests/integration/powerbi/golden_test_scan_all_workspaces.json @@ -8,7 +8,7 @@ "json": { "customProperties": {}, "name": "public issue_history", - "description": "public issue_history", + "description": "Library dataset description", "tags": [] } }, @@ -41,7 +41,7 @@ "json": { "customProperties": {}, "name": "SNOWFLAKE_TESTTABLE", - "description": "SNOWFLAKE_TESTTABLE", + "description": "Library dataset description", "tags": [] } }, @@ -74,7 +74,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query", - "description": "snowflake native-query", + "description": "Library dataset description", "tags": [] } }, @@ -107,7 +107,7 @@ "json": { "customProperties": {}, "name": "snowflake native-query-with-join", - "description": "snowflake native-query-with-join", + "description": "Library dataset description", "tags": [] } }, @@ -140,7 +140,7 @@ "json": { "customProperties": {}, "name": "job-history", - "description": "job-history", + "description": "Library dataset description", "tags": [] } }, @@ -173,7 +173,7 @@ "json": { "customProperties": {}, "name": "postgres_test_table", - "description": "postgres_test_table", + "description": "Library dataset description", "tags": [] } }, @@ -206,7 +206,7 @@ "json": { "customProperties": {}, "name": "dbo_book_issue", - "description": "dbo_book_issue", + "description": "hr pbi test description", "tags": [] } }, @@ -239,7 +239,7 @@ "json": { "customProperties": {}, "name": "ms_sql_native_table", - "description": "ms_sql_native_table", + "description": "hr pbi test description", "tags": [] } }, @@ -479,7 +479,7 @@ "workspaceId": "64ED5CAD-7C10-4684-8180-826122881108" }, "title": "test_dashboard", - "description": "test_dashboard", + "description": "Description of test dashboard", "charts": [ "urn:li:chart:(powerbi,charts.B8E293DC-0C83-4AA0-9BB9-0A8738DF24A0)", "urn:li:chart:(powerbi,charts.23212598-23b5-4980-87cc-5fc0ecd84385)" @@ -564,7 +564,7 @@ "workspaceId": "64ED5CAD-7C22-4684-8180-826122881108" }, "title": "test_dashboard2", - "description": "test_dashboard2", + "description": "", "charts": [], "datasets": [], "lastModified": { diff --git a/metadata-ingestion/tests/integration/powerbi/test_powerbi.py b/metadata-ingestion/tests/integration/powerbi/test_powerbi.py index 09e4b49232..b36860ec4d 100644 --- a/metadata-ingestion/tests/integration/powerbi/test_powerbi.py +++ b/metadata-ingestion/tests/integration/powerbi/test_powerbi.py @@ -82,6 +82,7 @@ def register_mock_api(request_mock: Any, override_data: dict = {}) -> None: "id": "7D668CAD-7FFC-4505-9215-655BCA5BEBAE", "isReadOnly": True, "displayName": "test_dashboard", + "description": "Description of test dashboard", "embedUrl": "https://localhost/dashboards/embed/1", "webUrl": "https://localhost/dashboards/web/1", } @@ -206,6 +207,7 @@ def register_mock_api(request_mock: Any, override_data: dict = {}) -> None: "json": { "id": "05169CD2-E713-41E6-9600-1D8066D95445", "name": "library-dataset", + "description": "Library dataset description", "webUrl": "http://localhost/groups/64ED5CAD-7C10-4684-8180-826122881108/datasets/05169CD2-E713-41E6-9600-1D8066D95445", }, }, @@ -215,6 +217,7 @@ def register_mock_api(request_mock: Any, override_data: dict = {}) -> None: "json": { "id": "05169CD2-E713-41E6-96AA-1D8066D95445", "name": "library-dataset", + "description": "Library dataset description", "webUrl": "http://localhost/groups/64ED5CAD-7C22-4684-8180-826122881108/datasets/05169CD2-E713-41E6-96AA-1D8066D95445", }, }, @@ -224,6 +227,7 @@ def register_mock_api(request_mock: Any, override_data: dict = {}) -> None: "json": { "id": "ba0130a1-5b03-40de-9535-b34e778ea6ed", "name": "hr_pbi_test", + "description": "hr pbi test description", "webUrl": "http://localhost/groups/64ED5CAD-7C10-4684-8180-826122881108/datasets/ba0130a1-5b03-40de-9535-b34e778ea6ed", }, },