From 23a2788c4ddd1d44582cfedaf6eeda2ed94249e4 Mon Sep 17 00:00:00 2001
From: Tony Ouyang <43738225+TonyOuyangGit@users.noreply.github.com>
Date: Thu, 13 Apr 2023 09:12:22 -0700
Subject: [PATCH] feat: set generateParameterizedFieldsResolvers to false to
 have parameterized queries be generated (#7806)

---
 datahub-graphql-core/build.gradle             |  1 +
 .../resolvers/view/CreateViewResolver.java    | 22 ++++++++++---------
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/datahub-graphql-core/build.gradle b/datahub-graphql-core/build.gradle
index 89f7b72861..12ce7c090c 100644
--- a/datahub-graphql-core/build.gradle
+++ b/datahub-graphql-core/build.gradle
@@ -41,6 +41,7 @@ graphqlCodegen {
     outputDir = new File("$projectDir/src/mainGeneratedGraphQL/java")
     packageName = "com.linkedin.datahub.graphql.generated"
     generateApis = true
+    generateParameterizedFieldsResolvers = false
     modelValidationAnnotation = "@javax.annotation.Nonnull"
     customTypesMapping = [
             Long: "Long",
diff --git a/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/view/CreateViewResolver.java b/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/view/CreateViewResolver.java
index 11dbcc390a..6e39879dd5 100644
--- a/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/view/CreateViewResolver.java
+++ b/datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/view/CreateViewResolver.java
@@ -60,19 +60,21 @@ public class CreateViewResolver implements DataFetcher<CompletableFuture<DataHub
   }
 
   private DataHubView createView(@Nonnull final Urn urn, @Nonnull final CreateViewInput input) {
-    return new DataHubView(
-        urn.toString(),
-        com.linkedin.datahub.graphql.generated.EntityType.DATAHUB_VIEW,
-        input.getViewType(),
-        input.getName(),
-        input.getDescription(),
-        new DataHubViewDefinition(
+    return new DataHubView.Builder()
+        .setUrn(urn.toString())
+        .setType(com.linkedin.datahub.graphql.generated.EntityType.DATAHUB_VIEW)
+        .setViewType(input.getViewType())
+        .setName(input.getName())
+        .setDescription(input.getDescription())
+        .setDefinition(new DataHubViewDefinition(
             input.getDefinition().getEntityTypes(),
             new DataHubViewFilter(
                 input.getDefinition().getFilter().getOperator(),
                 input.getDefinition().getFilter().getFilters().stream().map(filterInput ->
-                    new FacetFilter(filterInput.getField(), filterInput.getCondition(), filterInput.getValues(),
-                        filterInput.getNegated()))
-                    .collect(Collectors.toList()))));
+                        new FacetFilter(filterInput.getField(), filterInput.getCondition(),
+                            filterInput.getValues(),
+                            filterInput.getNegated()))
+                    .collect(Collectors.toList()))))
+        .build();
   }
 }