From 24cb936b5efa9a76e9638a3bc5d84aec4321dbf7 Mon Sep 17 00:00:00 2001
From: Ignacio Bona <ibonapiedrabuena@linkedin.com>
Date: Fri, 14 Sep 2018 17:10:45 -0700
Subject: [PATCH] Fix test failures

---
 .../app/components/avatars/avatar-image.ts    |  4 +-
 wherehows-web/config/dependency-lint.js       |  1 +
 .../search/containers/search-sources-test.js  | 73 -------------------
 3 files changed, 4 insertions(+), 74 deletions(-)
 delete mode 100644 wherehows-web/tests/integration/components/search/containers/search-sources-test.js

diff --git a/wherehows-web/app/components/avatars/avatar-image.ts b/wherehows-web/app/components/avatars/avatar-image.ts
index 0e24ed10f4..1eafc0e8fd 100644
--- a/wherehows-web/app/components/avatars/avatar-image.ts
+++ b/wherehows-web/app/components/avatars/avatar-image.ts
@@ -45,6 +45,8 @@ export default class AvatarImage extends Component {
    * @memberof AvatarImage
    */
   onImageFallback(): void {
-    set(this, 'src', this.avatar.imageUrlFallback);
+    if (!this.isDestroyed) {
+      set(this, 'src', this.avatar.imageUrlFallback);
+    }
   }
 }
diff --git a/wherehows-web/config/dependency-lint.js b/wherehows-web/config/dependency-lint.js
index 0d0a79d50c..c862f04dbb 100644
--- a/wherehows-web/config/dependency-lint.js
+++ b/wherehows-web/config/dependency-lint.js
@@ -7,5 +7,6 @@ module.exports = {
     'ember-concurrency': '^0.8.18', //https://github.com/cibernox/ember-power-calendar/pull/135
     'ember-compatibility-helpers': '0.1.3 || 1.0.0-beta.1 || ^1.0.0',
     'ember-getowner-polyfill': '1.2.5 || ^2.2.0', //https://github.com/asross/dynamic-link/pull/10
+    '@ember-decorators/utils': '0.2.0 || ^2.4.1'
   }
 };
diff --git a/wherehows-web/tests/integration/components/search/containers/search-sources-test.js b/wherehows-web/tests/integration/components/search/containers/search-sources-test.js
deleted file mode 100644
index bdd8e09adb..0000000000
--- a/wherehows-web/tests/integration/components/search/containers/search-sources-test.js
+++ /dev/null
@@ -1,73 +0,0 @@
-import { module, test } from 'qunit';
-import { setupRenderingTest } from 'ember-qunit';
-import { render, find, waitUntil } from '@ember/test-helpers';
-import hbs from 'htmlbars-inline-precompile';
-import sinon from 'sinon';
-
-const platformsResponse = {
-  platforms: [
-    {
-      name: 'platform1'
-    },
-    {
-      name: 'platform2'
-    }
-  ]
-};
-
-module('Integration | Component | search/containers/search sources', function(hooks) {
-  setupRenderingTest(hooks);
-
-  hooks.beforeEach(function() {
-    this.sinonServer = sinon.createFakeServer();
-    this.sinonServer.respondImmediately = true;
-  });
-
-  hooks.afterEach(function() {
-    this.sinonServer.restore();
-  });
-
-  test('it renders', async function(assert) {
-    this.sinonServer.respondWith('GET', /\/api\/v2\/list\/platforms/, [
-      200,
-      { 'Content-Type': 'application/json' },
-      JSON.stringify(platformsResponse)
-    ]);
-
-    await render(hbs`
-      {{#search/containers/search-sources}}
-        <div class="inner-content">Yielded Content</div>
-      {{/search/containers/search-sources}}
-    `);
-
-    await waitUntil(() => find('.inner-content'));
-
-    assert.equal(this.element.textContent.trim(), 'Yielded Content', 'inner content is rendered');
-  });
-
-  test('Platform sources yielded', async function(assert) {
-    this.sinonServer.respondWith('GET', /\/api\/v2\/list\/platforms/, [
-      200,
-      { 'Content-Type': 'application/json' },
-      JSON.stringify(platformsResponse)
-    ]);
-
-    await render(hbs`
-      {{#search/containers/search-sources as |container|}}
-      <span class="inner-content">
-      {{#each container.radioSources as |source|}}
-      {{source.value}}
-      {{/each}}
-      </span>
-      {{/search/containers/search-sources}}
-    `);
-
-    await waitUntil(() => find('.inner-content'));
-
-    const text = document.querySelector('.inner-content').textContent.trim();
-    assert.ok(
-      ['all', 'platform1', 'platform2'].reduce((acc, curr) => acc && text.includes(curr), true),
-      'it yields platform sources and `all`'
-    );
-  });
-});