yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-06-27 05:03:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(searchBarAutocomplete): add feature flag for search bar's autocomplete redesign (#12690)

Browse Source 
Co-authored-by: Victor Tarasevich <v.tarasevitch@invento.by>
This commit is contained in:
v-tarasevich-blitz-brain 2025-03-05 19:54:26 +03:00 committed by GitHub
parent 69981675a5
commit 256e488d28
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/config/AppConfigResolver.java
View File

@ -204,6 +204,8 @@ public class AppConfigResolver implements DataFetcher<CompletableFuture<AppConfi
.setShowNavBarRedesign(_featureFlags.isShowNavBarRedesign()) .setShowNavBarRedesign(_featureFlags.isShowNavBarRedesign())
.setShowAutoCompleteResults(_featureFlags.isShowAutoCompleteResults()) .setShowAutoCompleteResults(_featureFlags.isShowAutoCompleteResults())
.setEntityVersioningEnabled(_featureFlags.isEntityVersioning()) .setEntityVersioningEnabled(_featureFlags.isEntityVersioning())
.setShowSearchBarAutocompleteRedesign(
_featureFlags.isShowSearchBarAutocompleteRedesign())
.build(); .build();
appConfig.setFeatureFlags(featureFlagsConfig); appConfig.setFeatureFlags(featureFlagsConfig);

5
datahub-graphql-core/src/main/resources/app.graphql
View File

@ -593,6 +593,11 @@ type FeatureFlagsConfig {
If turned on, exposes the versioning feature by allowing users to link entities in the UI. If turned on, exposes the versioning feature by allowing users to link entities in the UI.
""" """
entityVersioningEnabled: Boolean! entityVersioningEnabled: Boolean!
"""
If turned on, show the redesigned search bar's autocomplete
"""
showSearchBarAutocompleteRedesign: Boolean!
} }
""" """

1
datahub-web-react/src/appConfigContext.tsx
View File

@ -67,6 +67,7 @@ export const DEFAULT_APP_CONFIG = {
showNavBarRedesign: false, showNavBarRedesign: false,
showAutoCompleteResults: false, showAutoCompleteResults: false,
entityVersioningEnabled: false, entityVersioningEnabled: false,
showSearchBarAutocompleteRedesign: false,
}, },
chromeExtensionConfig: { chromeExtensionConfig: {
enabled: false, enabled: false,

1
datahub-web-react/src/graphql/app.graphql
View File

@ -82,6 +82,7 @@ query appConfig {
showNavBarRedesign showNavBarRedesign
showAutoCompleteResults showAutoCompleteResults
entityVersioningEnabled entityVersioningEnabled
showSearchBarAutocompleteRedesign
} }
chromeExtensionConfig { chromeExtensionConfig {
enabled enabled

1
metadata-service/configuration/src/main/java/com/linkedin/datahub/graphql/featureflags/FeatureFlags.java
View File

@ -36,4 +36,5 @@ public class FeatureFlags {
private boolean showAutoCompleteResults = false; private boolean showAutoCompleteResults = false;
private boolean dataProcessInstanceEntityEnabled = true; private boolean dataProcessInstanceEntityEnabled = true;
private boolean entityVersioning = false; private boolean entityVersioning = false;
private boolean showSearchBarAutocompleteRedesign = false;
} }

1
metadata-service/configuration/src/main/resources/application.yaml
View File

@ -503,6 +503,7 @@ featureFlags:
showNavBarRedesign: ${SHOW_NAV_BAR_REDESIGN:true} # If turned on, show the newly designed nav bar in the V2 experience showNavBarRedesign: ${SHOW_NAV_BAR_REDESIGN:true} # If turned on, show the newly designed nav bar in the V2 experience
showAutoCompleteResults: ${SHOW_AUTO_COMPLETE_RESULTS:true} # If turned on, show the auto complete results in the search bar showAutoCompleteResults: ${SHOW_AUTO_COMPLETE_RESULTS:true} # If turned on, show the auto complete results in the search bar
entityVersioning: ${ENTITY_VERSIONING_ENABLED:false} # Enables entity versioning APIs, validators, and side effects entityVersioning: ${ENTITY_VERSIONING_ENABLED:false} # Enables entity versioning APIs, validators, and side effects
showSearchBarAutocompleteRedesign: ${SHOW_SEARCH_BAR_AUTOCOMPLETE_REDESIGN:false} # If turned on, show the redesigned search bar's autocomplete
entityChangeEvents: entityChangeEvents:
enabled: ${ENABLE_ENTITY_CHANGE_EVENTS_HOOK:true} enabled: ${ENABLE_ENTITY_CHANGE_EVENTS_HOOK:true}