yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-27 18:07:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(build): fix for hana build failure for aarch64. (#5019)

Browse Source
This commit is contained in:
Ravindra Lanka 2022-05-26 15:29:21 -07:00 committed by GitHub
parent b6773e4637
commit 26c0acf786
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
metadata-ingestion/setup.py
View File

@ -201,7 +201,11 @@ plugins: Dict[str, Set[str]] = {
"feast": {"feast==0.18.0", "flask-openid>=1.3.0"},
"glue": aws_common,
# hdbcli is supported officially by SAP, sqlalchemy-hana is built on top but not officially supported
"hana": sql_common | {"sqlalchemy-hana>=0.5.0", "hdbcli>=2.11.20"},
"hana": sql_common
| {
"sqlalchemy-hana>=0.5.0; platform_machine != 'aarch64'",
"hdbcli>=2.11.20; platform_machine != 'aarch64'",
},
"hive": sql_common
| {
# Acryl Data maintains a fork of PyHive

6
metadata-ingestion/tests/integration/hana/test_hana.py
View File

@ -1,3 +1,5 @@
import platform
import pytest
from freezegun import freeze_time
@ -10,6 +12,10 @@ FROZEN_TIME = "2020-04-14 07:00:00"
@freeze_time(FROZEN_TIME)
@pytest.mark.slow_integration
@pytest.mark.skipif(
platform.machine().lower() == "aarch64",
reason="The hdbcli dependency is not available for aarch64",
)
def test_hana_ingest(docker_compose_runner, pytestconfig, tmp_path, mock_time):
test_resources_dir = pytestconfig.rootpath / "tests/integration/hana"

16
metadata-ingestion/tests/unit/test_hana_source.py
View File

@ -1,7 +1,15 @@
import platform
import pytest
from datahub.ingestion.api.common import PipelineContext
from datahub.ingestion.source.sql.hana import HanaConfig, HanaSource
@pytest.mark.skipif(
platform.machine().lower() == "aarch64",
reason="The hdbcli dependency is not available for aarch64",
)
def test_platform_correctly_set_hana():
source = HanaSource(
ctx=PipelineContext(run_id="hana-source-test"),
@ -10,6 +18,10 @@ def test_platform_correctly_set_hana():
assert source.platform == "hana"
@pytest.mark.skipif(
platform.machine().lower() == "aarch64",
reason="The hdbcli dependency is not available for aarch64",
)
def test_hana_uri_native():
config = HanaConfig.parse_obj(
{
@ -22,6 +34,10 @@ def test_hana_uri_native():
assert config.get_sql_alchemy_url() == "hana+hdbcli://user:password@host:39041"
@pytest.mark.skipif(
platform.machine().lower() == "aarch64",
reason="The hdbcli dependency is not available for aarch64",
)
def test_hana_uri_native_db():
config = HanaConfig.parse_obj(
{