yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-08-18 06:06:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Minor fixes to policies redesign (#4309)

Browse Source
This commit is contained in:
John Joyce 2022-03-03 17:05:07 -08:00 committed by GitHub
parent daab31d6ef
commit 2c3effa54d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
datahub-web-react/src/app/policy/AvatarsGroup.tsx
View File

@ -26,7 +26,7 @@ export default function AvatarsGroup({ users, groups, entityRegistry, maxCount =
<div data-testid={`avatar-tag-${user.urn}`} key={`${user.urn}-${key}`}>
<CustomAvatar
size={size}
name={user?.username}
name={entityRegistry.getDisplayName(EntityType.CorpUser, user)}
url={`/${entityRegistry.getPathName(EntityType.CorpUser)}/${user.urn}`}
photoUrl={
user?.editableProperties?.pictureLink || user?.editableInfo?.pictureLink || undefined
@ -41,7 +41,7 @@ export default function AvatarsGroup({ users, groups, entityRegistry, maxCount =
<div data-testid={`avatar-tag-${group.urn}`} key={`${group.urn}-${key}`}>
<CustomAvatar
size={size}
name={group?.name}
name={entityRegistry.getDisplayName(EntityType.CorpGroup, group)}
url={`/${entityRegistry.getPathName(EntityType.CorpGroup)}/${group.urn}`}
isGroup
/>

8
datahub-web-react/src/app/policy/PoliciesPage.tsx
View File

@ -34,7 +34,7 @@ const PoliciesHeaderContainer = styled.div`
const PoliciesTitle = styled(Typography.Title)`
&& {
margin-bottom: 24px;
margin-bottom: 8px;
}
`;
@ -329,7 +329,7 @@ export const PoliciesPage = () => {
<Button
disabled={!record?.editable}
onClick={() => onToggleActiveDuplicate(record?.policy)}
style={{ color: record?.editable ? 'red' : ANTD_GRAY[6] }}
style={{ color: record?.editable ? 'red' : ANTD_GRAY[6], width: 100 }}
>
DEACTIVATE
</Button>
@ -337,7 +337,7 @@ export const PoliciesPage = () => {
<Button
disabled={!record?.editable}
onClick={() => onToggleActiveDuplicate(record?.policy)}
style={{ color: record?.editable ? 'green' : ANTD_GRAY[6] }}
style={{ color: record?.editable ? 'green' : ANTD_GRAY[6], width: 100 }}
>
ACTIVATE
</Button>
@ -381,7 +381,7 @@ export const PoliciesPage = () => {
<PoliciesHeaderContainer>
<PoliciesTitle level={2}>Manage Policies</PoliciesTitle>
<Typography.Paragraph type="secondary">
Manage access for Users & Groups of DataHub using Policies.
Manage access for DataHub Users & Groups using Policies.
</Typography.Paragraph>
</PoliciesHeaderContainer>
</PoliciesContainer>

6
datahub-web-react/src/app/policy/PolicyDetailsModal.tsx
View File

@ -71,7 +71,7 @@ export default function PolicyDetailsModal({ policy, visible, onClose, privilege
const actionButtons = (
<ButtonsContainer>
<Button onClick={onClose}>Cancel</Button>
<Button onClick={onClose}>Close</Button>
</ButtonsContainer>
);
@ -140,7 +140,7 @@ export default function PolicyDetailsModal({ policy, visible, onClose, privilege
<AvatarsGroup
users={policy?.actors?.resolvedUsers}
entityRegistry={entityRegistry}
maxCount={3}
maxCount={50}
size={28}
/>
{policy?.actors?.allUsers ? <Tag>All Users</Tag> : null}
@ -151,7 +151,7 @@ export default function PolicyDetailsModal({ policy, visible, onClose, privilege
<AvatarsGroup
groups={policy?.actors?.resolvedGroups}
entityRegistry={entityRegistry}
maxCount={3}
maxCount={50}
size={28}
/>
{policy?.actors?.allGroups ? <Tag>All Groups</Tag> : null}