yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-27 18:07:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(glossary) Fix dropdown where disabled buttons are still clickable (#5430)

Browse Source 
Co-authored-by: Chris Collins <chriscollins@Chriss-MBP-2.lan>
This commit is contained in:
Chris Collins 2022-07-18 20:14:26 -04:00 committed by GitHub
parent 89ed0fc1e5
commit 386fd146ed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
datahub-web-react/src/app/entity/shared/EntityDropdown/EntityDropdown.tsx
View File

@ -162,35 +162,51 @@ function EntityDropdown(props: Props) {
</Menu.Item>
)}
{menuItems.has(EntityMenuItems.ADD_TERM) && (
<StyledMenuItem key="2" disabled={!canManageGlossaries}>
<MenuItem onClick={() => setIsCreateTermModalVisible(true)}>
<StyledMenuItem
key="2"
disabled={!canManageGlossaries}
onClick={() => setIsCreateTermModalVisible(true)}
>
<MenuItem>
<PlusOutlined /> &nbsp;Add Term
</MenuItem>
</StyledMenuItem>
)}
{menuItems.has(EntityMenuItems.ADD_TERM_GROUP) && (
<StyledMenuItem key="3" disabled={!canManageGlossaries}>
<MenuItem onClick={() => setIsCreateNodeModalVisible(true)}>
<StyledMenuItem
key="3"
disabled={!canManageGlossaries}
onClick={() => setIsCreateNodeModalVisible(true)}
>
<MenuItem>
<FolderAddOutlined /> &nbsp;Add Term Group
</MenuItem>
</StyledMenuItem>
)}
{menuItems.has(EntityMenuItems.MOVE) && (
<StyledMenuItem key="4" disabled={!canManageGlossaries}>
<MenuItem onClick={() => setIsMoveModalVisible(true)}>
<StyledMenuItem
key="4"
disabled={!canManageGlossaries}
onClick={() => setIsMoveModalVisible(true)}
>
<MenuItem>
<FolderOpenOutlined /> &nbsp;Move
</MenuItem>
</StyledMenuItem>
)}
{menuItems.has(EntityMenuItems.DELETE) && (
<StyledMenuItem key="5" disabled={isDeleteDisabled || !canManageGlossaries}>
<StyledMenuItem
key="5"
disabled={isDeleteDisabled || !canManageGlossaries}
onClick={onDeleteEntity}
>
<Tooltip
title={`Can't delete ${entityRegistry.getEntityName(
entityType,
)} with child entities.`}
overlayStyle={isDeleteDisabled ? {} : { display: 'none' }}
>
<MenuItem onClick={onDeleteEntity}>
<MenuItem>
<DeleteOutlined /> &nbsp;Delete
</MenuItem>
</Tooltip>