yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-07 15:04:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest/sqlglot): Make detach_ctes more robust (#11449)

Browse Source
This commit is contained in:
Andrew Sikowitz 2024-09-23 11:42:55 -07:00 committed by GitHub
parent f1be36605b
commit 3c1dcf99b0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
metadata-ingestion/setup.py
View File

@ -101,7 +101,7 @@ usage_common = {
sqlglot_lib = { sqlglot_lib = {
# Using an Acryl fork of sqlglot. # Using an Acryl fork of sqlglot.
# https://github.com/tobymao/sqlglot/compare/main...hsheth2:sqlglot:main?expand=1 # https://github.com/tobymao/sqlglot/compare/main...hsheth2:sqlglot:main?expand=1
"acryl-sqlglot[rs]==25.20.2.dev5", "acryl-sqlglot[rs]==25.20.2.dev6",
} }
classification_lib = { classification_lib = {

3
metadata-ingestion/src/datahub/sql_parsing/sqlglot_utils.py
View File

@ -347,6 +347,9 @@ def detach_ctes(
dialect = get_dialect(platform) dialect = get_dialect(platform)
statement = parse_statement(sql, dialect=dialect) statement = parse_statement(sql, dialect=dialect)
if not cte_mapping:
return statement
def replace_cte_refs(node: sqlglot.exp.Expression) -> sqlglot.exp.Expression: def replace_cte_refs(node: sqlglot.exp.Expression) -> sqlglot.exp.Expression:
if ( if (
isinstance(node, sqlglot.exp.Identifier) isinstance(node, sqlglot.exp.Identifier)