yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-09-17 21:20:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest/tableau): retry when getting 'unexpected error occurred' (#14672)

Browse Source
This commit is contained in:
Michael Maltese 2025-09-09 10:25:49 -04:00 committed by GitHub
parent 5ce93f54b4
commit 3d464941d0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
metadata-ingestion/src/datahub/ingestion/source/tableau/tableau.py
View File

@ -1561,12 +1561,15 @@ class TableauSiteSource:
}}""", }}""",
) )
else: else:
# As of Tableau Server 2024.2, the metadata API sporadically returns a 30-second
# timeout error.
# It doesn't reliably happen, so retrying a couple of times makes sense.
if all( if all(
# As of Tableau Server 2024.2, the metadata API sporadically returns a 30-second
# timeout error.
# It doesn't reliably happen, so retrying a couple of times makes sense.
error.get("message") error.get("message")
== "Execution canceled because timeout of 30000 millis was reached" == "Execution canceled because timeout of 30000 millis was reached"
# The Metadata API sometimes returns an 'unexpected error' message when querying
# embeddedDatasourcesConnection. Try retrying a couple of times.
or error.get("message") == "Unexpected error occurred"
for error in errors for error in errors
): ):
# If it was only a timeout error, we can retry. # If it was only a timeout error, we can retry.
@ -1578,8 +1581,8 @@ class TableauSiteSource:
(self.config.max_retries - retries_remaining + 1) ** 2, 60 (self.config.max_retries - retries_remaining + 1) ** 2, 60
) )
logger.info( logger.info(
f"Query {connection_type} received a 30 second timeout error - will retry in {backoff_time} seconds. " f"Query {connection_type} received a retryable error with {retries_remaining} retries remaining, "
f"Retries remaining: {retries_remaining}" f"will retry in {backoff_time} seconds: {errors}"
) )
time.sleep(backoff_time) time.sleep(backoff_time)
return self.get_connection_object_page( return self.get_connection_object_page(