yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-12-17 04:53:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui) Fix cursor jumping around in search bar (#13743)

Browse Source
This commit is contained in:
Chris Collins 2025-06-10 22:15:48 -04:00 committed by GitHub
parent 7acc41ba63
commit 3f81f90c73
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
datahub-web-react/src/alchemy-components/components/AutoComplete/AutoComplete.tsx
View File

@ -23,7 +23,6 @@ export default function AutoComplete({
}: React.PropsWithChildren<AutoCompleteProps>) { }: React.PropsWithChildren<AutoCompleteProps>) {
const { open } = props; const { open } = props;
const [internalValue, setInternalValue] = useState<string>(value || '');
const [internalOpen, setInternalOpen] = useState<boolean>(!!open); const [internalOpen, setInternalOpen] = useState<boolean>(!!open);
useEffect(() => { useEffect(() => {
@ -34,10 +33,6 @@ export default function AutoComplete({
if (open !== undefined) setInternalOpen(open); if (open !== undefined) setInternalOpen(open);
}, [open]); }, [open]);
useEffect(() => {
if (value !== undefined) setInternalValue(value);
}, [value]);
const onChangeHandler = (newValue: string, option: OptionType | OptionType[]) => { const onChangeHandler = (newValue: string, option: OptionType | OptionType[]) => {
if (!internalOpen && newValue !== '') setInternalOpen(true); if (!internalOpen && newValue !== '') setInternalOpen(true);
onChange?.(newValue, option); onChange?.(newValue, option);
@ -49,12 +44,11 @@ export default function AutoComplete({
if (internalOpen) { if (internalOpen) {
setInternalOpen(false); setInternalOpen(false);
} else { } else {
setInternalValue('');
onClear?.(); onClear?.();
} }
} }
}, },
[internalOpen, setInternalValue, onClear], [internalOpen, onClear],
); );
const onBlur = (event: React.FocusEvent) => { const onBlur = (event: React.FocusEvent) => {
@ -73,7 +67,7 @@ export default function AutoComplete({
> >
<AntdAutoComplete <AntdAutoComplete
open={internalOpen} open={internalOpen}
value={internalValue} value={value}
{...props} {...props}
listHeight={dropdownContentHeight} listHeight={dropdownContentHeight}
data-testid={dataTestId} data-testid={dataTestId}