yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-03 12:16:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(models): remove versions from metrics and hyperparams (#2938)

Browse Source
This commit is contained in:
Kevin Hu 2021-07-22 22:18:45 -07:00 committed by GitHub
parent b064e51a84
commit 43e61d9628
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
11 changed files with 23 additions and 141 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gms/api/src/main/snapshot/com.linkedin.dataset.datasets.snapshot.json
View File

@ -345,7 +345,11 @@
}
}
},
"doc" : "Urn of the applied glossary term"
"doc" : "Urn of the applied glossary term",
"Searchable" : {
"fieldName" : "glossaryTerms",
"fieldType" : "TEXT_PARTIAL"
}
} ]
}, "com.linkedin.common.GlossaryTermUrn", {
"type" : "record",

16
gms/api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json
View File

@ -595,7 +595,11 @@
}
}
},
"doc" : "Urn of the applied glossary term"
"doc" : "Urn of the applied glossary term",
"Searchable" : {
"fieldName" : "glossaryTerms",
"fieldType" : "TEXT_PARTIAL"
}
} ]
}, "com.linkedin.common.GlossaryTermUrn", {
"type" : "record",
@ -2479,11 +2483,6 @@
"type" : "com.linkedin.common.Time",
"doc" : "Date when the MLHyperParam was developed",
"optional" : true
}, {
"name" : "version",
"type" : "com.linkedin.common.VersionTag",
"doc" : "Version of the MLHyperParam",
"optional" : true
} ],
"Aspect" : {
"name" : "mlHyperParam"
@ -2519,11 +2518,6 @@
"type" : "com.linkedin.common.Time",
"doc" : "Date when the mlMetric was developed",
"optional" : true
}, {
"name" : "version",
"type" : "com.linkedin.common.VersionTag",
"doc" : "Version of the mlMetric",
"optional" : true
} ],
"Aspect" : {
"name" : "mlMetric"

16
gms/api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json
View File

@ -815,7 +815,11 @@
}
}
},
"doc" : "Urn of the applied glossary term"
"doc" : "Urn of the applied glossary term",
"Searchable" : {
"fieldName" : "glossaryTerms",
"fieldType" : "TEXT_PARTIAL"
}
} ]
}, "com.linkedin.common.GlossaryTermUrn", {
"type" : "record",
@ -2879,11 +2883,6 @@
"type" : "com.linkedin.common.Time",
"doc" : "Date when the MLHyperParam was developed",
"optional" : true
}, {
"name" : "version",
"type" : "com.linkedin.common.VersionTag",
"doc" : "Version of the MLHyperParam",
"optional" : true
} ],
"Aspect" : {
"name" : "mlHyperParam"
@ -2919,11 +2918,6 @@
"type" : "com.linkedin.common.Time",
"doc" : "Date when the mlMetric was developed",
"optional" : true
}, {
"name" : "version",
"type" : "com.linkedin.common.VersionTag",
"doc" : "Version of the mlMetric",
"optional" : true
} ],
"Aspect" : {
"name" : "mlMetric"

10
gms/api/src/main/snapshot/com.linkedin.ml.mlModels.snapshot.json
View File

@ -615,11 +615,6 @@
"type" : "com.linkedin.common.Time",
"doc" : "Date when the MLHyperParam was developed",
"optional" : true
}, {
"name" : "version",
"type" : "com.linkedin.common.VersionTag",
"doc" : "Version of the MLHyperParam",
"optional" : true
} ],
"Aspect" : {
"name" : "mlHyperParam"
@ -655,11 +650,6 @@
"type" : "com.linkedin.common.Time",
"doc" : "Date when the mlMetric was developed",
"optional" : true
}, {
"name" : "version",
"type" : "com.linkedin.common.VersionTag",
"doc" : "Version of the mlMetric",
"optional" : true
} ],
"Aspect" : {
"name" : "mlMetric"

18
metadata-ingestion/src/datahub/metadata/schema.avsc
View File

@ -3434,15 +3434,6 @@
"name": "createdAt",
"default": null,
"doc": "Date when the MLHyperParam was developed"
},
{
"type": [
"null",
"com.linkedin.pegasus2avro.common.VersionTag"
],
"name": "version",
"default": null,
"doc": "Version of the MLHyperParam"
}
],
"doc": "Properties associated with an ML Hyper Param"
@ -3497,15 +3488,6 @@
"name": "createdAt",
"default": null,
"doc": "Date when the mlMetric was developed"
},
{
"type": [
"null",
"com.linkedin.pegasus2avro.common.VersionTag"
],
"name": "version",
"default": null,
"doc": "Version of the mlMetric"
}
],
"doc": "Properties associated with an ML Metric"

28
metadata-ingestion/src/datahub/metadata/schema_classes.py
View File

@ -5671,7 +5671,6 @@ class MLHyperParamClass(DictWrapper):
description: Union[None, str]=None,
value: Union[None, str]=None,
createdAt: Union[None, int]=None,
version: Union[None, "VersionTagClass"]=None,
):
super().__init__()
@ -5679,7 +5678,6 @@ class MLHyperParamClass(DictWrapper):
self.description = description
self.value = value
self.createdAt = createdAt
self.version = version
@classmethod
def construct_with_defaults(cls) -> "MLHyperParamClass":
@ -5693,7 +5691,6 @@ class MLHyperParamClass(DictWrapper):
self.description = self.RECORD_SCHEMA.field_map["description"].default
self.value = self.RECORD_SCHEMA.field_map["value"].default
self.createdAt = self.RECORD_SCHEMA.field_map["createdAt"].default
self.version = self.RECORD_SCHEMA.field_map["version"].default
@property
@ -5740,17 +5737,6 @@ class MLHyperParamClass(DictWrapper):
self._inner_dict['createdAt'] = value
@property
def version(self) -> Union[None, "VersionTagClass"]:
"""Getter: Version of the MLHyperParam"""
return self._inner_dict.get('version') # type: ignore
@version.setter
def version(self, value: Union[None, "VersionTagClass"]) -> None:
"""Setter: Version of the MLHyperParam"""
self._inner_dict['version'] = value
class MLMetricClass(DictWrapper):
"""Properties associated with an ML Metric"""
@ -5760,7 +5746,6 @@ class MLMetricClass(DictWrapper):
description: Union[None, str]=None,
value: Union[None, str]=None,
createdAt: Union[None, int]=None,
version: Union[None, "VersionTagClass"]=None,
):
super().__init__()
@ -5768,7 +5753,6 @@ class MLMetricClass(DictWrapper):
self.description = description
self.value = value
self.createdAt = createdAt
self.version = version
@classmethod
def construct_with_defaults(cls) -> "MLMetricClass":
@ -5782,7 +5766,6 @@ class MLMetricClass(DictWrapper):
self.description = self.RECORD_SCHEMA.field_map["description"].default
self.value = self.RECORD_SCHEMA.field_map["value"].default
self.createdAt = self.RECORD_SCHEMA.field_map["createdAt"].default
self.version = self.RECORD_SCHEMA.field_map["version"].default
@property
@ -5829,17 +5812,6 @@ class MLMetricClass(DictWrapper):
self._inner_dict['createdAt'] = value
@property
def version(self) -> Union[None, "VersionTagClass"]:
"""Getter: Version of the mlMetric"""
return self._inner_dict.get('version') # type: ignore
@version.setter
def version(self, value: Union[None, "VersionTagClass"]) -> None:
"""Setter: Version of the mlMetric"""
self._inner_dict['version'] = value
class MLModelDeploymentPropertiesClass(DictWrapper):
"""Properties associated with an ML Model Deployment"""

18
metadata-ingestion/src/datahub/metadata/schemas/MetadataAuditEvent.avsc
View File

@ -3384,15 +3384,6 @@
],
"doc": "Date when the MLHyperParam was developed",
"default": null
},
{
"name": "version",
"type": [
"null",
"com.linkedin.pegasus2avro.common.VersionTag"
],
"doc": "Version of the MLHyperParam",
"default": null
}
],
"Aspect": {
@ -3446,15 +3437,6 @@
],
"doc": "Date when the mlMetric was developed",
"default": null
},
{
"name": "version",
"type": [
"null",
"com.linkedin.pegasus2avro.common.VersionTag"
],
"doc": "Version of the mlMetric",
"default": null
}
],
"Aspect": {

18
metadata-ingestion/src/datahub/metadata/schemas/MetadataChangeEvent.avsc
View File

@ -3383,15 +3383,6 @@
],
"doc": "Date when the MLHyperParam was developed",
"default": null
},
{
"name": "version",
"type": [
"null",
"com.linkedin.pegasus2avro.common.VersionTag"
],
"doc": "Version of the MLHyperParam",
"default": null
}
],
"Aspect": {
@ -3445,15 +3436,6 @@
],
"doc": "Date when the mlMetric was developed",
"default": null
},
{
"name": "version",
"type": [
"null",
"com.linkedin.pegasus2avro.common.VersionTag"
],
"doc": "Version of the mlMetric",
"default": null
}
],
"Aspect": {

24
metadata-ingestion/tests/unit/sagemaker/sagemaker_mces_golden.json
View File

@ -1626,15 +1626,13 @@
"name": "parameter-1",
"description": null,
"value": "some-value",
"createdAt": null,
"version": null
"createdAt": null
},
{
"name": "parameter-2",
"description": null,
"value": "another-value",
"createdAt": null,
"version": null
"createdAt": null
}
],
"trainingMetrics": [
@ -1642,15 +1640,13 @@
"name": "another-metric",
"description": null,
"value": "1.0",
"createdAt": null,
"version": null
"createdAt": null
},
{
"name": "some-metric",
"description": null,
"value": "1.0",
"createdAt": null,
"version": null
"createdAt": null
}
],
"onlineMetrics": null,
@ -1708,15 +1704,13 @@
"name": "parameter-1",
"description": null,
"value": "some-value",
"createdAt": null,
"version": null
"createdAt": null
},
{
"name": "parameter-2",
"description": null,
"value": "another-value",
"createdAt": null,
"version": null
"createdAt": null
}
],
"trainingMetrics": [
@ -1724,15 +1718,13 @@
"name": "another-metric",
"description": null,
"value": "1.0",
"createdAt": null,
"version": null
"createdAt": null
},
{
"name": "some-metric",
"description": null,
"value": "1.0",
"createdAt": null,
"version": null
"createdAt": null
}
],
"onlineMetrics": null,

5
metadata-models/src/main/pegasus/com/linkedin/ml/metadata/MLHyperParam.pdl
View File

@ -31,9 +31,4 @@ record MLHyperParam {
* Date when the MLHyperParam was developed
*/
createdAt: optional Time
/**
* Version of the MLHyperParam
*/
version: optional VersionTag
}

5
metadata-models/src/main/pegasus/com/linkedin/ml/metadata/MLMetric.pdl
View File

@ -31,9 +31,4 @@ record MLMetric {
* Date when the mlMetric was developed
*/
createdAt: optional Time
/**
* Version of the mlMetric
*/
version: optional VersionTag
}