yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-11-25 01:06:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Modify tests and remove action decorator

Browse Source
This commit is contained in:
cptran777 2018-08-02 13:00:49 -07:00
parent 3b7f07b54e
commit 449da617d6
3 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
wherehows-web/app/components/datasets/containers/dataset-health.ts
View File

@ -3,7 +3,6 @@ import { get, computed, setProperties, getProperties } from '@ember/object';
import { task, TaskInstance } from 'ember-concurrency'; import { task, TaskInstance } from 'ember-concurrency';
import ComputedProperty from '@ember/object/computed'; import ComputedProperty from '@ember/object/computed';
import { IChartDatum } from 'wherehows-web/typings/app/visualization/charts'; import { IChartDatum } from 'wherehows-web/typings/app/visualization/charts';
import { action } from '@ember-decorators/object';
import healthCategories from 'wherehows-web/mirage/fixtures/health-categories'; import healthCategories from 'wherehows-web/mirage/fixtures/health-categories';
import healthSeverity from 'wherehows-web/mirage/fixtures/health-severity'; import healthSeverity from 'wherehows-web/mirage/fixtures/health-severity';
@ -122,7 +121,6 @@ export default class DatasetHealthContainer extends Component {
}); });
}); });
@action
/** /**
* Triggered when the user clicks on one of the bars in the summary charts child component, will trigger * Triggered when the user clicks on one of the bars in the summary charts child component, will trigger
* a filter for whatever bar they select, unless it already is one in which case we will remove the filter * a filter for whatever bar they select, unless it already is one in which case we will remove the filter

4
wherehows-web/app/templates/components/datasets/containers/dataset-health.hbs
View File

@ -2,5 +2,5 @@
{{datasets/health/metrics-charts {{datasets/health/metrics-charts
categoryData=renderedCategories categoryData=renderedCategories
severityData=renderedSeverity severityData=renderedSeverity
onCategorySelect=(action "onFilterSelect" "category") onCategorySelect=(action onFilterSelect "category")
onSeveritySelect=(action "onFilterSelect" "severity")}} onSeveritySelect=(action onFilterSelect "severity")}}

7
wherehows-web/tests/integration/components/datasets/health/metrics-charts-test.js
View File

@ -23,18 +23,15 @@ test('it provides the correct information', async function(assert) {
{ name: 'Warning', value: 30, customColorClass: 'severity-chart__bar--warning' }, { name: 'Warning', value: 30, customColorClass: 'severity-chart__bar--warning' },
{ name: 'Critical', value: 25, customColorClass: 'severity-chart__bar--critical' } { name: 'Critical', value: 25, customColorClass: 'severity-chart__bar--critical' }
]; ];
const testAction = datum => assert.equal(datum.name, 'Warnisng', 'Action successfully passes along info');
this.setProperties({ this.setProperties({
categoryData, categoryData,
severityData, severityData
testAction
}); });
this.render(hbs`{{datasets/health/metrics-charts this.render(hbs`{{datasets/health/metrics-charts
categoryData=categoryData categoryData=categoryData
severityData=severityData severityData=severityData}}`);
onBarSelect=testAction}}`);
assert.ok(this.$(), 'Still renders without errors'); assert.ok(this.$(), 'Still renders without errors');
assert.equal(this.$(chartClass).length, 2, 'Renders 2 charts'); assert.equal(this.$(chartClass).length, 2, 'Renders 2 charts');