yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2026-01-03 21:35:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(ingest/lookml): fail when nothing was produced (#8464)

Browse Source
This commit is contained in:
Harshal Sheth 2023-07-20 11:04:30 -07:00 committed by GitHub
parent 9df70d7355
commit 47616ff093
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
metadata-ingestion/src/datahub/ingestion/source/looker/lookml_source.py
View File

@ -1853,6 +1853,13 @@ class LookMLSource(StatefulIngestionSourceBase):
yield from self.get_internal_workunits()
if not self.report.events_produced and not self.report.failures:
# Don't pass if we didn't produce any events.
self.report.report_failure(
"<main>",
"No metadata was produced. Check the logs for more details.",
)
def _recursively_check_manifests(
self, tmp_dir: str, project_name: str, project_visited: Set[str]
) -> None:
@ -1976,7 +1983,7 @@ class LookMLSource(StatefulIngestionSourceBase):
if connectionDefinition is None:
self.reporter.report_warning(
f"model-{model_name}",
f"Failed to load connection {model.connection}. Check your API key permissions.",
f"Failed to load connection {model.connection}. Check your API key permissions and/or connection_to_platform_map configuration.",
)
self.reporter.report_models_dropped(model_name)
continue