From 488b88f860eca093e7004350e8c218c60e7e4042 Mon Sep 17 00:00:00 2001 From: "Yi (Alan) Wang" Date: Tue, 20 Mar 2018 12:08:51 -0700 Subject: [PATCH] Modify Compliance Suggestion feedback null value handling (#1050) --- wherehows-frontend/app/controllers/api/v2/Dataset.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wherehows-frontend/app/controllers/api/v2/Dataset.java b/wherehows-frontend/app/controllers/api/v2/Dataset.java index 49d28ea6fb..6581f784c9 100644 --- a/wherehows-frontend/app/controllers/api/v2/Dataset.java +++ b/wherehows-frontend/app/controllers/api/v2/Dataset.java @@ -332,8 +332,8 @@ public class Dataset extends Controller { try { JsonNode record = request().body().asJson(); String feedback = record.hasNonNull("feedback") ? record.get("feedback").asText().toUpperCase() : null; - String uid = record.hasNonNull("uid") ? record.get("uid").asText() : null; - if (uid == null || (!"ACCEPT".equals(feedback) && !"REJECT".equals(feedback))) { + String uid = record.hasNonNull("uid") ? record.get("uid").asText() : ""; + if (!"ACCEPT".equals(feedback) && !"REJECT".equals(feedback)) { return Promise.promise(() -> badRequest(_EMPTY_RESPONSE)); }