yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-30 18:26:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Modify Compliance Suggestion feedback null value handling (#1050)

Browse Source
This commit is contained in:
Yi (Alan) Wang 2018-03-20 12:08:51 -07:00 committed by GitHub
parent fc3a5319e0
commit 488b88f860
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
wherehows-frontend/app/controllers/api/v2/Dataset.java
View File

@ -332,8 +332,8 @@ public class Dataset extends Controller {
try {
JsonNode record = request().body().asJson();
String feedback = record.hasNonNull("feedback") ? record.get("feedback").asText().toUpperCase() : null;
String uid = record.hasNonNull("uid") ? record.get("uid").asText() : null;
if (uid == null || (!"ACCEPT".equals(feedback) && !"REJECT".equals(feedback))) {
String uid = record.hasNonNull("uid") ? record.get("uid").asText() : "";
if (!"ACCEPT".equals(feedback) && !"REJECT".equals(feedback)) {
return Promise.promise(() -> badRequest(_EMPTY_RESPONSE));
}