From 48b6581f12f1cc5e46fe67703942a4a56e767adb Mon Sep 17 00:00:00 2001
From: Peter Wang <40186116+PeteMango@users.noreply.github.com>
Date: Fri, 7 Mar 2025 18:41:27 -0500
Subject: [PATCH] fix(ingest/superset): fixed iterate over int error for
 building urns (#12807)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Sergio Gómez Villamor <sgomezvillamor@gmail.com>
---
 .../src/datahub/ingestion/source/superset.py  |  6 ++---
 .../integration/superset/test_superset.py     | 22 +++++++++----------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/metadata-ingestion/src/datahub/ingestion/source/superset.py b/metadata-ingestion/src/datahub/ingestion/source/superset.py
index 6fc477a1e8..8573ed8b50 100644
--- a/metadata-ingestion/src/datahub/ingestion/source/superset.py
+++ b/metadata-ingestion/src/datahub/ingestion/source/superset.py
@@ -384,7 +384,7 @@ class SupersetSource(StatefulIngestionSourceBase):
     ) -> DashboardSnapshot:
         dashboard_urn = make_dashboard_urn(
             platform=self.platform,
-            name=dashboard_data["id"],
+            name=str(dashboard_data["id"]),
             platform_instance=self.config.platform_instance,
         )
         dashboard_snapshot = DashboardSnapshot(
@@ -416,7 +416,7 @@ class SupersetSource(StatefulIngestionSourceBase):
             chart_urns.append(
                 make_chart_urn(
                     platform=self.platform,
-                    name=value.get("meta", {}).get("chartId", "unknown"),
+                    name=str(value.get("meta", {}).get("chartId", "unknown")),
                     platform_instance=self.config.platform_instance,
                 )
             )
@@ -499,7 +499,7 @@ class SupersetSource(StatefulIngestionSourceBase):
     def construct_chart_from_chart_data(self, chart_data: dict) -> ChartSnapshot:
         chart_urn = make_chart_urn(
             platform=self.platform,
-            name=chart_data["id"],
+            name=str(chart_data["id"]),
             platform_instance=self.config.platform_instance,
         )
         chart_snapshot = ChartSnapshot(
diff --git a/metadata-ingestion/tests/integration/superset/test_superset.py b/metadata-ingestion/tests/integration/superset/test_superset.py
index 7bee6e5bcf..e8f5b54af7 100644
--- a/metadata-ingestion/tests/integration/superset/test_superset.py
+++ b/metadata-ingestion/tests/integration/superset/test_superset.py
@@ -35,7 +35,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
                 "count": 2,
                 "result": [
                     {
-                        "id": "1",
+                        "id": 1,
                         "changed_by": {
                             "first_name": "Test",
                             "id": 1,
@@ -63,7 +63,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
                         "certification_details": "Approved",
                     },
                     {
-                        "id": "2",
+                        "id": 2,
                         "changed_by": {
                             "first_name": "Test",
                             "id": 2,
@@ -95,7 +95,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
                 "count": 4,
                 "result": [
                     {
-                        "id": "10",
+                        "id": 10,
                         "changed_by": {
                             "first_name": "Test",
                             "id": 1,
@@ -109,7 +109,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
                         "params": '{"metrics": [], "adhoc_filters": []}',
                     },
                     {
-                        "id": "11",
+                        "id": 11,
                         "changed_by": {
                             "first_name": "Test",
                             "id": 1,
@@ -123,7 +123,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
                         "params": '{"metrics": [], "adhoc_filters": []}',
                     },
                     {
-                        "id": "12",
+                        "id": 12,
                         "changed_by": {
                             "first_name": "Test",
                             "id": 2,
@@ -137,7 +137,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
                         "params": '{"metrics": [], "adhoc_filters": []}',
                     },
                     {
-                        "id": "13",
+                        "id": 13,
                         "changed_by": {
                             "first_name": "Test",
                             "id": 2,
@@ -393,7 +393,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
                     "schema": "test_schema_name",
                     "table_name": "test_table_name",
                     "database": {
-                        "id": "30",
+                        "id": 30,
                         "database_name": "test_database_name",
                     },
                 },
@@ -576,7 +576,7 @@ def test_superset_stateful_ingest(
                 "count": 1,
                 "result": [
                     {
-                        "id": "1",
+                        "id": 1,
                         "changed_by": {
                             "first_name": "Test",
                             "id": 1,
@@ -613,7 +613,7 @@ def test_superset_stateful_ingest(
                 "count": 3,
                 "result": [
                     {
-                        "id": "10",
+                        "id": 10,
                         "changed_by": {
                             "first_name": "Test",
                             "id": 1,
@@ -627,7 +627,7 @@ def test_superset_stateful_ingest(
                         "params": '{"metrics": [], "adhoc_filters": []}',
                     },
                     {
-                        "id": "11",
+                        "id": 11,
                         "changed_by": {
                             "first_name": "Test",
                             "id": 1,
@@ -641,7 +641,7 @@ def test_superset_stateful_ingest(
                         "params": '{"metrics": [], "adhoc_filters": []}',
                     },
                     {
-                        "id": "12",
+                        "id": 12,
                         "changed_by": {
                             "first_name": "Test",
                             "id": 2,