yujunjun/datahub
2
0
Fork 0
mirror of https://github.com/datahub-project/datahub.git synced 2025-10-19 12:53:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ingest/superset): fixed iterate over int error for building urns (#12807)

Browse Source 
Co-authored-by: Sergio Gómez Villamor <sgomezvillamor@gmail.com>
This commit is contained in:
Peter Wang 2025-03-07 18:41:27 -05:00 committed by GitHub
parent c8347a72ee
commit 48b6581f12
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
metadata-ingestion/src/datahub/ingestion/source/superset.py
View File

@ -384,7 +384,7 @@ class SupersetSource(StatefulIngestionSourceBase):
) -> DashboardSnapshot: ) -> DashboardSnapshot:
dashboard_urn = make_dashboard_urn( dashboard_urn = make_dashboard_urn(
platform=self.platform, platform=self.platform,
name=dashboard_data["id"], name=str(dashboard_data["id"]),
platform_instance=self.config.platform_instance, platform_instance=self.config.platform_instance,
) )
dashboard_snapshot = DashboardSnapshot( dashboard_snapshot = DashboardSnapshot(
@ -416,7 +416,7 @@ class SupersetSource(StatefulIngestionSourceBase):
chart_urns.append( chart_urns.append(
make_chart_urn( make_chart_urn(
platform=self.platform, platform=self.platform,
name=value.get("meta", {}).get("chartId", "unknown"), name=str(value.get("meta", {}).get("chartId", "unknown")),
platform_instance=self.config.platform_instance, platform_instance=self.config.platform_instance,
) )
) )
@ -499,7 +499,7 @@ class SupersetSource(StatefulIngestionSourceBase):
def construct_chart_from_chart_data(self, chart_data: dict) -> ChartSnapshot: def construct_chart_from_chart_data(self, chart_data: dict) -> ChartSnapshot:
chart_urn = make_chart_urn( chart_urn = make_chart_urn(
platform=self.platform, platform=self.platform,
name=chart_data["id"], name=str(chart_data["id"]),
platform_instance=self.config.platform_instance, platform_instance=self.config.platform_instance,
) )
chart_snapshot = ChartSnapshot( chart_snapshot = ChartSnapshot(

22
metadata-ingestion/tests/integration/superset/test_superset.py
View File

@ -35,7 +35,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
"count": 2, "count": 2,
"result": [ "result": [
{ {
"id": "1", "id": 1,
"changed_by": { "changed_by": {
"first_name": "Test", "first_name": "Test",
"id": 1, "id": 1,
@ -63,7 +63,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
"certification_details": "Approved", "certification_details": "Approved",
}, },
{ {
"id": "2", "id": 2,
"changed_by": { "changed_by": {
"first_name": "Test", "first_name": "Test",
"id": 2, "id": 2,
@ -95,7 +95,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
"count": 4, "count": 4,
"result": [ "result": [
{ {
"id": "10", "id": 10,
"changed_by": { "changed_by": {
"first_name": "Test", "first_name": "Test",
"id": 1, "id": 1,
@ -109,7 +109,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
"params": '{"metrics": [], "adhoc_filters": []}', "params": '{"metrics": [], "adhoc_filters": []}',
}, },
{ {
"id": "11", "id": 11,
"changed_by": { "changed_by": {
"first_name": "Test", "first_name": "Test",
"id": 1, "id": 1,
@ -123,7 +123,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
"params": '{"metrics": [], "adhoc_filters": []}', "params": '{"metrics": [], "adhoc_filters": []}',
}, },
{ {
"id": "12", "id": 12,
"changed_by": { "changed_by": {
"first_name": "Test", "first_name": "Test",
"id": 2, "id": 2,
@ -137,7 +137,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
"params": '{"metrics": [], "adhoc_filters": []}', "params": '{"metrics": [], "adhoc_filters": []}',
}, },
{ {
"id": "13", "id": 13,
"changed_by": { "changed_by": {
"first_name": "Test", "first_name": "Test",
"id": 2, "id": 2,
@ -393,7 +393,7 @@ def register_mock_api(request_mock: Any, override_data: Optional[dict] = None) -
"schema": "test_schema_name", "schema": "test_schema_name",
"table_name": "test_table_name", "table_name": "test_table_name",
"database": { "database": {
"id": "30", "id": 30,
"database_name": "test_database_name", "database_name": "test_database_name",
}, },
}, },
@ -576,7 +576,7 @@ def test_superset_stateful_ingest(
"count": 1, "count": 1,
"result": [ "result": [
{ {
"id": "1", "id": 1,
"changed_by": { "changed_by": {
"first_name": "Test", "first_name": "Test",
"id": 1, "id": 1,
@ -613,7 +613,7 @@ def test_superset_stateful_ingest(
"count": 3, "count": 3,
"result": [ "result": [
{ {
"id": "10", "id": 10,
"changed_by": { "changed_by": {
"first_name": "Test", "first_name": "Test",
"id": 1, "id": 1,
@ -627,7 +627,7 @@ def test_superset_stateful_ingest(
"params": '{"metrics": [], "adhoc_filters": []}', "params": '{"metrics": [], "adhoc_filters": []}',
}, },
{ {
"id": "11", "id": 11,
"changed_by": { "changed_by": {
"first_name": "Test", "first_name": "Test",
"id": 1, "id": 1,
@ -641,7 +641,7 @@ def test_superset_stateful_ingest(
"params": '{"metrics": [], "adhoc_filters": []}', "params": '{"metrics": [], "adhoc_filters": []}',
}, },
{ {
"id": "12", "id": 12,
"changed_by": { "changed_by": {
"first_name": "Test", "first_name": "Test",
"id": 2, "id": 2,